From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 515C945FDA; Fri, 3 Jan 2025 22:26:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0F0F4067C; Fri, 3 Jan 2025 22:26:36 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 12FD7402DC for ; Fri, 3 Jan 2025 22:26:35 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 2B0992041AAC; Fri, 3 Jan 2025 13:26:34 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2B0992041AAC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1735939594; bh=S49TNVtXM7IWu8MOvF/OLC0ZQJryeN+znVCWnUI01Yk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=azPGABZ4mbZ7JoVdeGmnr1RVeBQ8KIjmr3clGAaC+dTDtVcox+h+ifg7SvE1A7iY5 gf+Txvb7y5tV5Sw84GUa0sqqtjydYb+20BrzRaYEOWs059pnO7YhYc+HxQ/JKDQC39 MJjr0N8olvrs2YccM5hF9uAazo6lzFR+xMCY8nsM= Date: Fri, 3 Jan 2025 13:26:34 -0800 From: Andre Muezerie To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH v11 0/3] add diagnostics macros to make code portable Message-ID: <20250103212634.GA24552@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1735918611-17374-1-git-send-email-andremue@linux.microsoft.com> <20250103112402.64bf2d96@pi5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250103112402.64bf2d96@pi5> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 03, 2025 at 11:24:02AM -0800, Stephen Hemminger wrote: > On Fri, 3 Jan 2025 07:36:48 -0800 > Andre Muezerie wrote: > > > From: Andre Muezerie > > To: andremue@linux.microsoft.com > > Cc: dev@dpdk.org, stephen@networkplumber.org > > Subject: [PATCH v11 0/3] add diagnostics macros to make code portable > > Date: Fri, 3 Jan 2025 07:36:48 -0800 > > X-Mailer: git-send-email 1.8.3.1 > > > > It was a common pattern to have "GCC diagnostic ignored" pragmas > > sprinkled over the code and only activate these pragmas for certain > > compilers (gcc and clang). Clang supports GCC's pragma for > > compatibility with existing source code, so #pragma GCC diagnostic > > and #pragma clang diagnostic are synonyms for Clang > > (https://clang.llvm.org/docs/UsersManual.html). > > > > Now that effort is being made to make the code compatible with MSVC > > these expressions would become more complex. It makes sense to hide > > this complexity behind macros. This makes maintenance easier as these > > macros are defined in a single place. As a plus the code becomes > > more readable as well. > > Since 90% of these cases are about removing const from a pointer, > maybe it would be better to have a macro that did that? > > Would not work for base driver code which is pretending to be platform independent. Most of the warnings I've seen were about dropping the volatile qualifier, like the one below: ../drivers/net/i40e/i40e_rxtx_vec_sse.c:42:32: warning: cast from 'volatile struct i40e_32byte_rx_desc::(unnamed at ../drivers/net/i40e/base/i40e_type.h:803:2) *' to '__attribute__((__vector_size__(2 * sizeof(long long)))) long long *' drops volatile qualifier [-Wcast-qual] 42 | _mm_store_si128((__m128i *)&rxdp[i].read, | ^ To make sure I understood your suggestion correctly, you're proposing to replace this __rte_diagnostic_push __rte_diagnostic_ignored_wcast_qual _mm_store_si128((__m128i *)&rxdp[i].read, dma_addr0); __rte_diagnostic_pop with something like this? _mm_store_si128(RTE_IGNORE_CAST_QUAL((__m128i *)&rxdp[i].read), dma_addr0); This could be done, and I think it does look better, despite the slight line length increase.