From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB9B845F9B; Sat, 4 Jan 2025 20:12:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CC4D40278; Sat, 4 Jan 2025 20:12:40 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 87DC04014F for ; Sat, 4 Jan 2025 20:12:39 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2163b0c09afso183525095ad.0 for ; Sat, 04 Jan 2025 11:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736017958; x=1736622758; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OUmTn06b0y1LdPt1sQY9z4Jw3HLhsbEGxc/ITcKGV50=; b=JUV0nUILJx9V5Ep+lmm+FOBl6rJGgyIRDGTOleBv+OviiqOiI/L4bqBvI5bci1M2tK A/VipMl1eZ71fcwkPJkkAoam8B8fzpVoKHPttPF61k6k4tQ0l8lprCPWPP7HmmkWMk1q KLcRjybzqVe4UGjbLC6bPSOgEXdFDMaF+rmpPmyCV0mmePv3TqZ2XTKJaJRSlg3Ju2qk LpW1OmX2oz3OevCZv5xOx9N3oCHyvOI4fOaCxmPv5fKQTgbqFJeW1NfPOZ6gCfv9yJ0w /7ptolCN1fTOsRJk4VHLQdt0CsEbtw6b71w5f1hzaUUcSBTiPyKo0Yx+BoFjTn4MqBVm AVvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736017958; x=1736622758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OUmTn06b0y1LdPt1sQY9z4Jw3HLhsbEGxc/ITcKGV50=; b=YpyJ28IQyY8Xk7Con8HELwfZtke3zZhBTRCcviJzfvU0anYXLWdezpltf4swlN/Ypk vZu/ccx0W3eTxLGFc0xLOHZBxNaKvSLu1M01YdIbDAv0VuDPIlqjGv1g0eq0mZkxVap4 tPQuXMT9OkR6fbbplCjz/gShYAMVHwA76C6HtM4R4xRc9oOV35Ao1vnrRu2olzh6Bfbh j+ycDFEXPP6vaFLyYcbFLImnwcXwzR4/7Hx+tPMcGOmFoUPBuBdBV+KFZha4A54jWJBD 1QfsIr0AJZtl4wo98SdCz97tBHe1BM8x7FM4UECSc0QZ5YRbYkrN2PJJ8fm19TBTJ9Vq byVw== X-Gm-Message-State: AOJu0YzuVh+GOfjPmLMTbsoaRC/nQXc8CK5cfxVCnWjWIBFhsuoHb5w/ NrGF9TV7hEtIPurFEyNl1Y3SMBIqV3ucEvwkVCPRdxrSUfySSnEnBIRMBFQQLRUI6OfqocvB2eP L X-Gm-Gg: ASbGnctD7ON0yAiaDE2iUawi13uQO/27E/prjt41gWIMb4G42CM8pVRo14a4MrFj1d+ 8vnFmwnt4GZuwkz6uqBwNFkZDzIeqvrb1CJx1gi3hpuL2pP+PAzopA9PCp+QKrgqeSTOLtSiL+p xfrt1JdIRc+16u/kyF4qVyBigE7Y5e/P0ihCiEv6/0EfVgtT8eSxWwCHpRgarT1VFpJkvRcRo/i nCfnXeqUMj71lZl2rwQe2XpHztKvVm6MyxcD7rqj3zk+chpKvKWE7VL0G7YSWR1kLOH78qbcXxJ qXpLD3fI X-Google-Smtp-Source: AGHT+IE1TJDaCuC4GxJTWUPwoEIsotQDSVnevd74AXBy/RcecRhigCoq5pGOkZ/fiflOUqC1HJiJGA== X-Received: by 2002:a17:903:11cf:b0:216:4cc2:b1e0 with SMTP id d9443c01a7336-219e6e9df19mr763805975ad.20.1736017958486; Sat, 04 Jan 2025 11:12:38 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca01931sm265044605ad.245.2025.01.04.11.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 11:12:38 -0800 (PST) Date: Sat, 4 Jan 2025 11:12:35 -0800 From: Stephen Hemminger To: "WanRenyong" Cc: , , Subject: Re: [PATCH 00/19] XSC PMD for Yunsilicon NICs Message-ID: <20250104111235.7a4c358f@pi5> In-Reply-To: <20240906121405.3404357-1-wanry@yunsilicon.com> References: <20240906121405.3404357-1-wanry@yunsilicon.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 6 Sep 2024 20:13:46 +0800 "WanRenyong" wrote: > This xsc PMD (**librte_net_xsc**) provides poll mode driver for Yunsilicon metaScale > serials NICs. > > Features: > --------- > - MTU update > - TSO > - RSS hash > - RSS key update > - RSS reta update > - L3 checksum offload > - L4 checksum offload > - Inner L3 checksum > - Inner L4 checksum > - Basic stats > > Support NICs: > ------------- > - metaScale-200S Single QSFP56 Port 200GE SmartNIC > - metaScale-200 Quad QSFP28 Ports 100GE SmartNIC > - metaScale-50 Dual QSFP28 Port 25GE SmartNIC > - metaScale-100Q Quad QSFP28 Port 25GE SmartNIC > > > ----- > > WanRenyong (19): > net/xsc: add doc and minimum build framework > net/xsc: add log macro > net/xsc: add PCI device probe and remove > net/xsc: add xsc device init and uninit > net/xsc: add ioctl command interface > net/xsc: initialize hardware information > net/xsc: add representor ports probe > net/xsc: create eth devices for representor ports > net/xsc: initial representor eth device > net/xsc: add ethdev configure and rxtx queue setup ops > net/xsc: add mailbox and structure > net/xsc: add ethdev RSS hash ops > net/xsc: add ethdev start and stop ops > net/xsc: add ethdev Rx burst > net/xsc: add ethdev Tx burst > net/xsc: configure xsc device hardware table > net/xsc: add dev link and MTU ops > net/xsc: add dev infos get > net/xsc: add dev basic stats ops > > .mailmap | 4 + > MAINTAINERS | 9 + > doc/guides/nics/features/xsc.ini | 18 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/xsc.rst | 31 + > drivers/net/meson.build | 1 + > drivers/net/xsc/meson.build | 36 + > drivers/net/xsc/xsc_ctrl.c | 64 ++ > drivers/net/xsc/xsc_ctrl.h | 314 +++++++ > drivers/net/xsc/xsc_defs.h | 61 ++ > drivers/net/xsc/xsc_dev.c | 326 +++++++ > drivers/net/xsc/xsc_dev.h | 99 +++ > drivers/net/xsc/xsc_ethdev.c | 1434 ++++++++++++++++++++++++++++++ > drivers/net/xsc/xsc_ethdev.h | 81 ++ > drivers/net/xsc/xsc_flow.c | 167 ++++ > drivers/net/xsc/xsc_flow.h | 67 ++ > drivers/net/xsc/xsc_log.h | 44 + > drivers/net/xsc/xsc_rxtx.c | 445 +++++++++ > drivers/net/xsc/xsc_rxtx.h | 214 +++++ > drivers/net/xsc/xsc_utils.c | 346 +++++++ > drivers/net/xsc/xsc_utils.h | 27 + > 21 files changed, 3789 insertions(+) > create mode 100644 doc/guides/nics/features/xsc.ini > create mode 100644 doc/guides/nics/xsc.rst > create mode 100644 drivers/net/xsc/meson.build > create mode 100644 drivers/net/xsc/xsc_ctrl.c > create mode 100644 drivers/net/xsc/xsc_ctrl.h > create mode 100644 drivers/net/xsc/xsc_defs.h > create mode 100644 drivers/net/xsc/xsc_dev.c > create mode 100644 drivers/net/xsc/xsc_dev.h > create mode 100644 drivers/net/xsc/xsc_ethdev.c > create mode 100644 drivers/net/xsc/xsc_ethdev.h > create mode 100644 drivers/net/xsc/xsc_flow.c > create mode 100644 drivers/net/xsc/xsc_flow.h > create mode 100644 drivers/net/xsc/xsc_log.h > create mode 100644 drivers/net/xsc/xsc_rxtx.c > create mode 100644 drivers/net/xsc/xsc_rxtx.h > create mode 100644 drivers/net/xsc/xsc_utils.c > create mode 100644 drivers/net/xsc/xsc_utils.h > Please fix the build error: drivers/libtmp_rte_net_xsc.a.p/net_xsc_xsc_vfio.c.o -c ../drivers/net/xsc/xsc_vfio.c ../drivers/net/xsc/xsc_vfio.c:482:26: error: cast from 'volatile struct xsc_cqe (*)[]' to 'void *' drops volatile qualifier [-Werror,-Wcast-qual] 482 | cq_info->cqes = (void *)cqes; | ^ Probably best not to mark that arg as volatile. Do not try and solve the problem by disabling the warning. And address the review feedback and resubmit when ready.