[PATCH] net/memif: Fix memif-rx buffer linking

[PATCH] net/memif: Fix memif-rx buffer linking

[Mike Bly]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Moving where dst_off is set in memif-rx function
Bugzilla ID: 1609
Fixes: aa17df860891 ("net/memif: add a Rx fast path")
Cc: stable@dpdk.org
Cc: Jakub Grajciar <jgrajcia@cisco.com>

Signed-off-by: Mike Bly <bly454@gmail.com>
---
 drivers/net/memif/rte_eth_memif.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/memif/rte_eth_memif.c
b/drivers/net/memif/rte_eth_memif.c
index c0bf1e3bbf..bef1606550 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -414,13 +414,12 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs,
uint16_t nb_pkts)
                                goto no_free_bufs;
                        mbuf = mbuf_head;
                        mbuf->port = mq->in_port;
-
+                       dst_off = 0;
 next_slot2:
                        s0 = cur_slot & mask;
                        d0 = &ring->desc[s0];

                        src_len = d0->length;
-                       dst_off = 0;
                        src_off = 0;

                        do {
-- 
2.43.5

[-- Attachment #2: Type: text/html, Size: 1592 bytes --]

Re: [PATCH] net/memif: Fix memif-rx buffer linking

[Stephen Hemminger]

On Mon, 6 Jan 2025 11:43:28 -0800
Mike Bly <bly454@gmail.com> wrote:

> From: Mike Bly <bly454@gmail.com>
> To: dev@dpdk.org
> Cc: stable@dpdk.org, jgrajcia@cisco.com
> Subject: [PATCH] net/memif: Fix memif-rx buffer linking
> Date: Mon, 6 Jan 2025 11:43:28 -0800
> 
> Moving where dst_off is set in memif-rx function
> Bugzilla ID: 1609
> Fixes: aa17df860891 ("net/memif: add a Rx fast path")
> Cc: stable@dpdk.org
> Cc: Jakub Grajciar <jgrajcia@cisco.com>
> 
> Signed-off-by: Mike Bly <bly454@gmail.com>


Please add more description (from bug report) about what the impact of this is.
Your description says what the change is but the next person looking at in two
years won't know why it was needed.