From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 221114601F; Wed, 8 Jan 2025 16:36:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AAEC4029A; Wed, 8 Jan 2025 16:36:47 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 6A4274014F for ; Wed, 8 Jan 2025 16:36:45 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2ee50ffcf14so1657125a91.0 for ; Wed, 08 Jan 2025 07:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736350604; x=1736955404; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hiD6jA9coKHBkVt1o5RRWgOsFJD2eEGNvbGmstBJ5eI=; b=OPR8Fky+CcKH3sy/aS2eG+co3t0VQi1cEc8abK4W9nJaXY4Jm59bpGaemM/UNFhlH+ SVCvjQfVNHTp72QIIIhf9EuCx0lDV1RXXDw5vq4BhxCS8SdTOtXYaSAKuBJoc2QSZzXI QP03379JcYiyfnzRto0di4CMBrXlvmqLce7PGHq91WzONsDqM66HIBHSaTjSt+5VpD0f ZIx5zVNOspXiSXZGSTWnnXguJpip/l0cNiOjjbjSyBFSO0qZLbire5Ej8bkaMxavnImW a+8RlzAV0DK4a00fTwWETh5y46qNy81Z7NDu8vGUQkeiCDMU/P3exg7BaqjfWPH9eby3 yrbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736350604; x=1736955404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hiD6jA9coKHBkVt1o5RRWgOsFJD2eEGNvbGmstBJ5eI=; b=k7WBaoscEUCqP0gUR6OcHBX+KW8OoO2SFAuRa7JBIAkIEBZF0fDtZaLkZO5PytpfSG ayUgEUG4mlYKaLgVdMJlqY7ycpZiF+mf3suqEztNXtQxiGnyRkkR/cFGwHP+f2jup9cZ Yto76vQuyNpFlyEYKZAh+ON9sfNPeQ4ml7Xc5JgSr5xw4fGSPxdz85kiYganF0jdeTOC R0MXzf1+RSMS+2ynVhIoMMocP4bLndGt4CFcHzfBENt/XX5kz/E1dx1f/A6d4Bzyub6g en5DMNkQCRXA16bs8lWGIG27N6WT5/nDjpGmvrYXzw79oVUyX7FyFj5eYecKNY4v8epf HBFQ== X-Gm-Message-State: AOJu0YzTF1zjOgBj9PsvtTjzwbzyQ9P4sJZorMfi7K2eMr4XJYeUlQKJ LT6F7/l5jRjjkz4IUG60K2huXT9Bzv7pMSErQ1VATbzt8mXd9ed+otVIj0otYjI= X-Gm-Gg: ASbGnctIKXGxWjMMAmYrnYq+OthondXne2JodbMOakYbG5SAhvcxwusEtLfF2/FEXXM kX/6HLy2sk0m0U8Hagq82pM7F4w33nvs1tLUjllANW5uLaL91kSluS24obkYpJy4H97OqnyLM64 2uNMvkilGtRygBYy64AWFMg88JDubySUeT6IycpbenF6DL+xjCq0kEiOjL2rkwlG9IlT1Zvy3sg 3hH4j1bbVGJuAruXdpE9gt8QARJID7S+ABbs5Nv/DnmKJXKLmJiUuvfOYLC7jglrXcouVgsqfLT wNiI2+hf X-Google-Smtp-Source: AGHT+IF9fTDz9HEvxLf/8a+iieCHJpP3UB7RVkE1eUEPKjda7Qo6S12t2fcBYPs1oO6Hn7eKft6MzQ== X-Received: by 2002:a17:90b:518d:b0:2ee:9661:eafb with SMTP id 98e67ed59e1d1-2f54869130cmr5148001a91.12.1736350604300; Wed, 08 Jan 2025 07:36:44 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f54a26590bsm1691914a91.4.2025.01.08.07.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 07:36:44 -0800 (PST) Date: Wed, 8 Jan 2025 07:36:41 -0800 From: Stephen Hemminger To: Mike Bly Cc: dev@dpdk.org, stable@dpdk.org, jgrajcia@cisco.com Subject: Re: [PATCH v2] net/memif: Fix memif-rx buffer linking Message-ID: <20250108073641.5e9d89e3@pi5> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 7 Jan 2025 10:22:10 -0800 Mike Bly wrote: > Cc: stable@dpdk.org, jgrajcia@cisco.com > Subject: [PATCH v2] net/memif: Fix memif-rx buffer linking > Date: Tue, 7 Jan 2025 10:22:10 -0800 > > Moving where dst_off is set in memif-rx function. It should be > initialized for each new dpdk-mbuf, not each memif-buffer. > Bugzilla ID: 1609 > Fixes: aa17df860891 ("net/memif: add a Rx fast path") > Cc: stable@dpdk.org > Cc: Jakub Grajciar > > Signed-off-by: Mike Bly > --- > drivers/net/memif/rte_eth_memif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/memif/rte_eth_memif.c > b/drivers/net/memif/rte_eth_memif.c > index c0bf1e3bbf..bef1606550 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -414,13 +414,12 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > goto no_free_bufs; > mbuf = mbuf_head; > mbuf->port = mq->in_port; > - > + dst_off = 0; > next_slot2: > s0 = cur_slot & mask; > d0 = &ring->desc[s0]; Looks like mailer whitespace corruption again.