From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C7084601F; Wed, 8 Jan 2025 16:43:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 338354014F; Wed, 8 Jan 2025 16:43:31 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 7638D400D6 for ; Wed, 8 Jan 2025 16:43:30 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2ee67e9287fso24996672a91.0 for ; Wed, 08 Jan 2025 07:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736351009; x=1736955809; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=acCdJHpgMyqoRwyNgDXhB741i4e5oWUOXGQ69aS720k=; b=cpjxA9nFgIiXU3c6YA6k+l0f7A0hqay1H0EhNnTWU0bo9MTNeGBtUIstBZIbwarw1S Df8PNMopqM734EOicPpMWEfNlOv+v+4BBdvZ+BShhr3V+9oCTPwk8QYwSeZ0AkQw3sbe iuWLayl5CqdduaqdvHoHoTuajbkfxjGtHZgn7HuAN622TQ9NpkhQ4o+lt4j+1q5UoVPi szT8tyIUedg6jL1pZDxMK5gWOMIGiKInE78uL8UWdK6h0uVvNFpTrjHPxKZGMQpwudmm b48Wkgi0J7Il0rf7+bn/qE+Dkz4Vkx44xos9Wl7Q6RnZDfATKHaG27YnkbdYmlZ0b7n7 4t1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736351009; x=1736955809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acCdJHpgMyqoRwyNgDXhB741i4e5oWUOXGQ69aS720k=; b=AT/U7euD23SjDnJ+rqDF/puZTZOUA8yWzEtdAHwj4uzxOlYZE15KhyEcpyY6+X9LxG 7LV2c06mVLbVzGE5crQE3nLoUz5GRmF3b2Y0vo0SW3DUBZ80SEN1M9GDxbqmgybaU65x LOEMnbJegzPL+VaccS593L34F3hff8IP5fgbnrUKqHVhsJhLAwNE3DeA6T4dOvDgxYwC GCbiAdMUn9aW03APULlcAagDK1uWDAp3Fxd5e9PqIJEMjz5n+haDTUyhgI4H4LTngZwq Bw87ZkUzAoNgcKPHpsyYftjG2w0ieYrxp9sJAI7uPJxczo66AG9BQrFmsX2yOXG3dOwr +hyQ== X-Gm-Message-State: AOJu0YzgpXskEpyXvnNOnTZi9izYyA9uHorHdNzSqNmiyY+rO92t88wl aSC/0TwywBBl70j+2NiMeEeWlQavpyxxgVv6BAyCn1D7/N76C7s+0722RSl4ffc= X-Gm-Gg: ASbGncsXor5VXfZRDf38hK+muZMBoIIQxK8pqF9Em+LK5lf5vZuKpOpMiUPzelIKAZC cc2vAYH3B7muFl+8hHOgoPsKrmDkA6WTVTBtiZP3UMo0lXr2WnjB1I0V1YJvUsepdyutXtZaWgm HSJoHT5eHxBk2jKmH/QqrCJw9ywvrnrAxdZfXpZ49X9vHq4VFlsBdY1tIWu5inlgiAdQb+0N95N xwHzOBHINSvbXejLWnzMU9tEEKnkGFO0h2JjhC+hoies5TMzgbAwcw6aiMuP1Qv8kjmQZ7qNoQn WmBUQof1 X-Google-Smtp-Source: AGHT+IERrqDydQ2xNwIMmNKKs47I4wQPDXYmUGQwIoS38tBOTrr1Zv0SNI1llDuEgVq7fLbqxPhh0w== X-Received: by 2002:a17:90a:da8e:b0:2ee:a744:a4fe with SMTP id 98e67ed59e1d1-2f548f5f878mr4783539a91.25.1736351009576; Wed, 08 Jan 2025 07:43:29 -0800 (PST) Received: from pi5 (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96eadcsm330358885ad.73.2025.01.08.07.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 07:43:29 -0800 (PST) Date: Wed, 8 Jan 2025 07:43:26 -0800 From: Stephen Hemminger To: Tomasz Duszynski Cc: , "Pascal Mazon" , Subject: Re: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing Message-ID: <20250108074326.193cbf2d@pi5> In-Reply-To: <20250108121011.2949616-1-tduszynski@marvell.com> References: <20250108121011.2949616-1-tduszynski@marvell.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 8 Jan 2025 13:10:11 +0100 Tomasz Duszynski wrote: > From: Tomasz Duszynski > To: , Stephen Hemminger , = "Pascal Mazon" > CC: , Tomasz Duszynski > Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is mi= ssing > Date: Wed, 8 Jan 2025 13:10:11 +0100 > X-Mailer: git-send-email 2.34.1 >=20 > If HAVE_TCA_FLOWER is undefined compilation errors / warnings may > appear. This addresses following spotted issues: >=20 > ../drivers/net/tap/rte_eth_tap.c:2113:1: error: label =E2=80=98disable_rt= e_flow=E2=80=99 > defined but not used [-Werror=3Dunused-label] >=20 > ../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter > =E2=80=98remote_iface=E2=80=99 [-Werror=3Dunused-parameter] >=20 > Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") > Cc: pascal.mazon@6wind.com >=20 > Signed-off-by: Tomasz Duszynski Looks good, but realize that flower was added in kernel 4.2 and the current oldest supported upstream kernel is 4.4. So if you are using a supported kernel, flower will be present.