DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tomasz Duszynski <tduszynski@marvell.com>
To: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
	"Pascal Mazon" <pascal.mazon@6wind.com>
Cc: <jerinj@marvell.com>, Tomasz Duszynski <tduszynski@marvell.com>
Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing
Date: Wed, 8 Jan 2025 13:10:11 +0100	[thread overview]
Message-ID: <20250108121011.2949616-1-tduszynski@marvell.com> (raw)

If HAVE_TCA_FLOWER is undefined compilation errors / warnings may
appear. This addresses following spotted issues:

../drivers/net/tap/rte_eth_tap.c:2113:1: error: label ‘disable_rte_flow’
defined but not used [-Werror=unused-label]

../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter
‘remote_iface’ [-Werror=unused-parameter]

Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
Cc: pascal.mazon@6wind.com

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
 drivers/net/tap/rte_eth_tap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 650ddbd706..8fa708c58d 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1905,7 +1905,7 @@ static const struct eth_dev_ops ops = {

 static int
 eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
-		   char *remote_iface, struct rte_ether_addr *mac_addr,
+		   char *remote_iface __rte_unused, struct rte_ether_addr *mac_addr,
 		   enum rte_tuntap_type type, int persist)
 {
 	int numa_node = rte_socket_id();
@@ -2109,6 +2109,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
 	rte_eth_dev_probing_finish(dev);
 	return 0;

+#ifdef HAVE_TCA_FLOWER
 disable_rte_flow:
 	TAP_LOG(ERR, " Disabling rte flow support: %s(%d)",
 		strerror(errno), errno);
@@ -2118,6 +2119,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
 	}
 	rte_eth_dev_probing_finish(dev);
 	return 0;
+#endif

 #ifdef HAVE_TCA_FLOWER
 error_remote:
--
2.34.1


             reply	other threads:[~2025-01-08 12:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 12:10 Tomasz Duszynski [this message]
2025-01-08 15:43 ` Stephen Hemminger
2025-01-09  7:31   ` [EXTERNAL] " Tomasz Duszynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108121011.2949616-1-tduszynski@marvell.com \
    --to=tduszynski@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pascal.mazon@6wind.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).