From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 907DD4601D; Wed, 8 Jan 2025 13:11:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 651724014F; Wed, 8 Jan 2025 13:11:12 +0100 (CET) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2F469400D6 for ; Wed, 8 Jan 2025 13:11:10 +0100 (CET) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50897qod029232; Wed, 8 Jan 2025 04:11:08 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pfpt0220; bh=5B61l8kuJdQL5tY9QK2tl71 d1h6vFazPFZ3U9pcLR4k=; b=hYeSCQT4+6HH4qdVW0XAo8BpngfRYM7LnSsqKrV XCV9rq/sOi/A3+kpjTJHxDBQ08Rks3YT6qmQCdkRI2x6WbA65nPtxXrAjDVag4ZJ Hexjeuih2zJdRvSwNCm6vm+2eEBVB+O4LJQjIEqGcwYOjUJ9Z2vM+/GoglwGMHFK rxRIPjf90oPPt3Kr2byH4dlCuI9xNRqAM3uAGpDwZzoP+ZRMSowDHa6qFNVSv+M/ BPGirHdV3waAkss20XFCEptvPtjeLPOoKqgQ3nWioFcBkf2XRWGH1uKPlyF0gtEq r0KIn/n8HDnYRzBdpmta0z1ndOX+s/uRx030Mzs4jOGaIig== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 441pf4raur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 04:11:08 -0800 (PST) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 8 Jan 2025 04:11:07 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 8 Jan 2025 04:11:07 -0800 Received: from cavium-optiplex-3070-BM15.. (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 0F0223F7091; Wed, 8 Jan 2025 04:11:05 -0800 (PST) From: Tomasz Duszynski To: , Stephen Hemminger , "Pascal Mazon" CC: , Tomasz Duszynski Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing Date: Wed, 8 Jan 2025 13:10:11 +0100 Message-ID: <20250108121011.2949616-1-tduszynski@marvell.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3vpLC4qsWQt7QS6asIVZriNHEloDIVfl X-Proofpoint-ORIG-GUID: 3vpLC4qsWQt7QS6asIVZriNHEloDIVfl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If HAVE_TCA_FLOWER is undefined compilation errors / warnings may appear. This addresses following spotted issues: ../drivers/net/tap/rte_eth_tap.c:2113:1: error: label ‘disable_rte_flow’ defined but not used [-Werror=unused-label] ../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter ‘remote_iface’ [-Werror=unused-parameter] Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") Cc: pascal.mazon@6wind.com Signed-off-by: Tomasz Duszynski --- drivers/net/tap/rte_eth_tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 650ddbd706..8fa708c58d 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1905,7 +1905,7 @@ static const struct eth_dev_ops ops = { static int eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, - char *remote_iface, struct rte_ether_addr *mac_addr, + char *remote_iface __rte_unused, struct rte_ether_addr *mac_addr, enum rte_tuntap_type type, int persist) { int numa_node = rte_socket_id(); @@ -2109,6 +2109,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, rte_eth_dev_probing_finish(dev); return 0; +#ifdef HAVE_TCA_FLOWER disable_rte_flow: TAP_LOG(ERR, " Disabling rte flow support: %s(%d)", strerror(errno), errno); @@ -2118,6 +2119,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, } rte_eth_dev_probing_finish(dev); return 0; +#endif #ifdef HAVE_TCA_FLOWER error_remote: -- 2.34.1