From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DDD046024; Thu, 9 Jan 2025 01:56:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2717240655; Thu, 9 Jan 2025 01:51:29 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0A5CA40613 for ; Thu, 9 Jan 2025 01:51:28 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 60BE0203E3AD; Wed, 8 Jan 2025 16:51:27 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 60BE0203E3AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1736383887; bh=Y/Ih2xI8Hs/IFgFnyZnrc+nh5fYK4ynLBZFnncO0ynI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KJSpq9pQL+P2nAv5vEyGjJL6087BAyj9HZoQtF9T3hNhG4xr92vo9Blj+qigEJGV6 o5B+6qeQyct803Yp3wPSOGM44Gb9bjrhpIk1owhNpp44swBHQW6jmcVn6sicTKRK+4 wQNJYWZm9prrg21EoQ/WV2amBIodigK34ug3XeSg= Date: Wed, 8 Jan 2025 16:51:27 -0800 From: Andre Muezerie To: David Marchand Cc: roretzla@linux.microsoft.com, aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com Subject: Re: [PATCH v8 02/29] eal/include: add new packing macros Message-ID: <20250109005127.GA32080@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com> <1735670291-23224-3-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 08, 2025 at 12:05:10PM +0100, David Marchand wrote: > On Tue, Dec 31, 2024 at 7:38 PM Andre Muezerie > wrote: > > diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h > > index 4d299f2b36..40592f71b1 100644 > > --- a/lib/eal/include/rte_common.h > > +++ b/lib/eal/include/rte_common.h > > @@ -99,13 +99,32 @@ typedef uint32_t unaligned_uint32_t; > > typedef uint16_t unaligned_uint16_t; > > #endif > > > > +/** > > + * @deprecated > > + * @see __rte_packed_begin > > + * @see __rte_packed_end > > + * > > + * Force a structure to be packed > > + */ > > +#ifdef RTE_TOOLCHAIN_MSVC > > +#define __rte_packed RTE_DEPRECATED(__rte_packed) > > +#else > > +#define __rte_packed (RTE_DEPRECATED(__rte_packed) __attribute__((__packed__))) > > +#endif > > + > > We can't mark __rte_packed as deprecated so "early" in the series. > Instead, this must be moved as a last patch, to avoid breaking > compilations in the middle of the series. > > > -- > David Marchand Thanks for letting me know. I fixed this in the v9 series I sent out now. Andre Muezerie