From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B7AC346025;
	Thu,  9 Jan 2025 03:49:35 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 285C2402F1;
	Thu,  9 Jan 2025 03:49:24 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id E49F640615
 for <dev@dpdk.org>; Thu,  9 Jan 2025 03:49:21 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 394C5206AB6D; Wed,  8 Jan 2025 18:49:21 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 394C5206AB6D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1736390961;
 bh=HxxAOS+cGvDbdCUp64TigxHcj4RtGbtMsPBIOSUjcW4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Gvv6XLjlcJj3r1xh+HmZ7gV03r10+5F1eRx5DH52B5qxLIwLbYZ+iEyCJ6fpdwFnR
 zkGIGC+gHzWDxoBqbWL+KNOCclGHIhOnaBPjQPghsCKeK5wlN/Oiyc7ehOB03FMx1m
 JTkChgfDGep+W1YchYMz64vGVuH+epL+VZed1UwI=
Date: Wed, 8 Jan 2025 18:49:21 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: roretzla@linux.microsoft.com, dev@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>, Robin Jarry <rjarry@redhat.com>
Subject: Re: [PATCH v8 27/29] lib/net: replace packed attributes
Message-ID: <20250109024921.GA15259@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
 <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com>
 <1735670291-23224-28-git-send-email-andremue@linux.microsoft.com>
 <CAJFAV8z+R9LW3y23PqgYAHZoTMbia1a2-OFKBZDwqYhE4aHP2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8z+R9LW3y23PqgYAHZoTMbia1a2-OFKBZDwqYhE4aHP2g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Jan 08, 2025 at 01:01:23PM +0100, David Marchand wrote:
> On Tue, Dec 31, 2024 at 7:40 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> > diff --git a/lib/net/rte_ip6.h b/lib/net/rte_ip6.h
> > index 992ab5ee1f..92558a124a 100644
> > --- a/lib/net/rte_ip6.h
> > +++ b/lib/net/rte_ip6.h
> > @@ -358,7 +358,7 @@ enum rte_ipv6_mc_scope {
> >         RTE_IPV6_MC_SCOPE_ORGLOCAL = 0x08,
> >         /** Global multicast scope. */
> >         RTE_IPV6_MC_SCOPE_GLOBAL = 0x0e,
> > -} __rte_packed;
> > +};
> >
> >  /**
> >   * Extract the IPv6 multicast scope value as defined in RFC 4291, section 2.7.
> 
> Cc: Robin for info.
> 
> This change affects the storage size of a variable of this type (at
> least with gcc).
> I think it is ok from an ABI pov: there is one (inline) helper using
> this type, and nothing else in DPDK takes a IPv6 multicast scope as
> input.
> 
> However, it deserves a mention in the commitlog (maybe a separate
> commit to highlight it?).
> 
> 
> -- 
> David Marchand

Makes sense. I added a note about that to the commit message for that patch in the v10 series.

Thanks,
Andre Muezerie