From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C64F246027; Thu, 9 Jan 2025 05:03:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6BA94068E; Thu, 9 Jan 2025 05:03:42 +0100 (CET) Received: from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22]) by mails.dpdk.org (Postfix) with ESMTP id 35ABA4066C for ; Thu, 9 Jan 2025 05:03:39 +0100 (CET) X-QQ-mid: bizesmtp84t1736395415t3njdu49 X-QQ-Originating-IP: 7kLblwiC+afKp3l9gQT2r7DTwTIYD99ePxy4iFBHNaU= Received: from DSK-zaiyuwang.trustnetic.com ( [218.72.126.41]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 09 Jan 2025 12:03:34 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 14308145773756997034 From: Zaiyu Wang To: dev@dpdk.org Cc: Zaiyu Wang , Jiawen Wu Subject: [PATCH 05/15] net/ngbe: add set MTU ops for VF device Date: Thu, 9 Jan 2025 12:02:15 +0800 Message-Id: <20250109040227.1016-6-zaiyuwang@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20250109040227.1016-1-zaiyuwang@trustnetic.com> References: <20250109040227.1016-1-zaiyuwang@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-QQ-XMAILINFO: NP3iUBCWMtGbA7y55Sl7VaqtejCqqIz1obuNE+Q7t0EkK67WbNuVDZf7 8CrZp0hN97ptKHULXV4HEbiqcydJpUm4kOv589ZeN7oO4xaRFABMHVvp1QrS9DgoUXFawwl t0tMpq8V1GlcmyfMLtUcGDruJx+p3+U5+fH3NNXpCQPoRfymbff/V9OmQQ8LMiZ3uuFl3Hs MYGwc0F9HI3Lh5OrMYy+JC58puc01jPVh00Cfhk2anC8DrRXDYfAVYPufhdEY5YR/xV9l8r ZKgWEwEo7SDn19Ul3o1FG6eSSxEx8l3cJ3UCNnRTvMEkI+mfg0WmDn96T2l6Dk89JIdkxRl lEEWEj6UOAp9Xv7/zbtygNit0rAJY1o/Y1a1R2ZX8UAPOtU8Ur68m2mpgSfc+IB7QWsn1L1 FrnDFTXSV9/Fa0A6APqL6PhmgNypYieNwyaJo6dQ6kKP20CsGtsNwbB5rsY88QWUVFVrMWT 2rie9ioiMP6ZvIk1f/xI+SzWIq+ighqeO6KoCvonvoHx6LVyXWDaPaz73P74UXj/B6kXPIX /Y67njCI3BJ8fnxL1eROoHWygZzj7Q0mtChvXuhqly+C9hX1F3RE3/hdC7egjNY4ENghESh dvkrPN/Azrpu122gyFOIlAj/AcxRZVEHWt70ic3Yg15ZV7qNbtHFUOAS8th23fnSVNGOY6h kx2IEOD4ao/czqK52eEN8kVgQ8MYJ0rppT4jc4eghe5iuwoGPeRpf3x0Kb6dgSeOmz5hvvw PrRANu2iJpuoeDDgxnwSM0CMMJmf4J39wwleOrDa6+nkYOsxwojADPWwxZXhyu7dUNZpsez xRruT0n/juYDGUdOD5l6dFkC2G5GAZo2nJiLH0xgoauWHEca1Y5imFKpbpV8AXVYxUhFF1+ tILN0j48Q4N8IcDxssecb/E3/6ct9BlCNbH4B/z9F/sr+ts0ZVNyNu1+NwyvA2drXW+huEB kaEY/nyI1Xd0CWe39ZvvJuNqHkldvwer7yS5V1LwLFW6eppQ23uy8otFm/QWswBM9BPZ53T 0NKb1qng== X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= X-QQ-RECHKSPAM: 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Support to update MTU for VF device. Signed-off-by: Zaiyu Wang --- doc/guides/nics/features/ngbe_vf.ini | 1 + drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/base/ngbe_vf.c | 24 +++++++++++++++++++ drivers/net/ngbe/base/ngbe_vf.h | 1 + drivers/net/ngbe/ngbe_ethdev_vf.c | 36 ++++++++++++++++++++++++++++ 5 files changed, 63 insertions(+) diff --git a/doc/guides/nics/features/ngbe_vf.ini b/doc/guides/nics/features/ngbe_vf.ini index aa628dfa97..333f02c854 100644 --- a/doc/guides/nics/features/ngbe_vf.ini +++ b/doc/guides/nics/features/ngbe_vf.ini @@ -4,6 +4,7 @@ ; Refer to default.ini for the full list of available PMD features. ; [Features] +MTU update = Y Promiscuous mode = Y Allmulticast mode = Y CRC offload = P diff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h index 29dcd5f912..f780b92efa 100644 --- a/drivers/net/ngbe/base/ngbe_type.h +++ b/drivers/net/ngbe/base/ngbe_type.h @@ -352,6 +352,7 @@ struct ngbe_mac_info { void (*set_vlan_anti_spoofing)(struct ngbe_hw *hw, bool enable, int vf); s32 (*update_xcast_mode)(struct ngbe_hw *hw, int xcast_mode); + s32 (*set_rlpml)(struct ngbe_hw *hw, u16 max_size); /* Flow Control */ s32 (*fc_enable)(struct ngbe_hw *hw); diff --git a/drivers/net/ngbe/base/ngbe_vf.c b/drivers/net/ngbe/base/ngbe_vf.c index 918df6f0dc..2d00d5998d 100644 --- a/drivers/net/ngbe/base/ngbe_vf.c +++ b/drivers/net/ngbe/base/ngbe_vf.c @@ -228,6 +228,29 @@ s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode) return 0; } +/** + * ngbevf_rlpml_set_vf - Set the maximum receive packet length + * @hw: pointer to the HW structure + * @max_size: value to assign to max frame size + **/ +s32 ngbevf_rlpml_set_vf(struct ngbe_hw *hw, u16 max_size) +{ + u32 msgbuf[2]; + s32 retval; + + msgbuf[0] = NGBE_VF_SET_LPE; + msgbuf[1] = max_size; + + retval = ngbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2); + if (retval) + return retval; + if ((msgbuf[0] & NGBE_VF_SET_LPE) && + (msgbuf[0] & NGBE_VT_MSGTYPE_NACK)) + return NGBE_ERR_MBX; + + return 0; +} + /** * ngbevf_negotiate_api_version - Negotiate supported API version * @hw: pointer to the HW structure @@ -339,6 +362,7 @@ s32 ngbe_init_ops_vf(struct ngbe_hw *hw) mac->negotiate_api_version = ngbevf_negotiate_api_version; mac->update_xcast_mode = ngbevf_update_xcast_mode; + mac->set_rlpml = ngbevf_rlpml_set_vf; mac->max_tx_queues = 1; mac->max_rx_queues = 1; diff --git a/drivers/net/ngbe/base/ngbe_vf.h b/drivers/net/ngbe/base/ngbe_vf.h index 79891e8389..a64de9d332 100644 --- a/drivers/net/ngbe/base/ngbe_vf.h +++ b/drivers/net/ngbe/base/ngbe_vf.h @@ -17,6 +17,7 @@ s32 ngbe_start_hw_vf(struct ngbe_hw *hw); s32 ngbe_reset_hw_vf(struct ngbe_hw *hw); s32 ngbe_stop_hw_vf(struct ngbe_hw *hw); s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode); +s32 ngbevf_rlpml_set_vf(struct ngbe_hw *hw, u16 max_size); int ngbevf_negotiate_api_version(struct ngbe_hw *hw, int api); int ngbevf_get_queues(struct ngbe_hw *hw, unsigned int *num_tcs, unsigned int *default_tc); diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c b/drivers/net/ngbe/ngbe_ethdev_vf.c index d8ece38b00..5ce0c2df98 100644 --- a/drivers/net/ngbe/ngbe_ethdev_vf.c +++ b/drivers/net/ngbe/ngbe_ethdev_vf.c @@ -272,6 +272,41 @@ ngbevf_dev_close(struct rte_eth_dev *dev) return 0; } +static int +ngbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) +{ + struct ngbe_hw *hw; + uint32_t max_frame = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; + struct rte_eth_dev_data *dev_data = dev->data; + + hw = ngbe_dev_hw(dev); + + if (mtu < RTE_ETHER_MIN_MTU || + max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN) + return -EINVAL; + + /* If device is started, refuse mtu that requires the support of + * scattered packets when this feature has not been enabled before. + */ + if (dev_data->dev_started && !dev_data->scattered_rx && + (max_frame + 2 * RTE_VLAN_HLEN > + dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) { + PMD_INIT_LOG(ERR, "Stop port first."); + return -EINVAL; + } + + /* + * When supported by the underlying PF driver, use the NGBE_VF_SET_MTU + * request of the version 2.0 of the mailbox API. + * For now, use the NGBE_VF_SET_LPE request of the version 1.0 + * of the mailbox API. + */ + if (ngbevf_rlpml_set_vf(hw, max_frame)) + return -EINVAL; + + return 0; +} + static int ngbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) { @@ -369,6 +404,7 @@ static const struct eth_dev_ops ngbevf_eth_dev_ops = { .allmulticast_enable = ngbevf_dev_allmulticast_enable, .allmulticast_disable = ngbevf_dev_allmulticast_disable, .dev_infos_get = ngbevf_dev_info_get, + .mtu_set = ngbevf_dev_set_mtu, }; RTE_PMD_REGISTER_PCI(net_ngbe_vf, rte_ngbevf_pmd); -- 2.21.0.windows.1