DPDK patches and discussions
 help / color / mirror / Atom feed
From: Paul Szczepanek <paul.szczepanek@arm.com>
To: dev@dpdk.org
Cc: Paul Szczepanek <paul.szczepanek@arm.com>
Subject: [PATCH v4 1/2] dts: add stop ports decorator for VLAN functions
Date: Thu,  9 Jan 2025 18:01:23 +0000	[thread overview]
Message-ID: <20250109180124.1678253-1-paul.szczepanek@arm.com> (raw)
In-Reply-To: <20240724171345.341495-2-jspewock@iol.unh.edu>

Testpmd functions manipulating the VLAN options require
the ports to be stopped when applying changes.

Signed-off-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
 dts/framework/remote_session/testpmd_shell.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index c01ee74b21..aa55bd91d3 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -1909,6 +1909,7 @@ def extract_verbose_output(output: str) -> list[TestPmdVerbosePacket]:
             out.append(TestPmdVerbosePacket.parse(f"{prev_header}\n{match.group('PACKET')}"))
         return out
 
+    @requires_stopped_ports
     def set_vlan_filter(self, port: int, enable: bool, verify: bool = True) -> None:
         """Set vlan filter on.
 
@@ -1935,6 +1936,7 @@ def set_vlan_filter(self, port: int, enable: bool, verify: bool = True) -> None:
                     filter on port {port}"""
                 )
 
+    @requires_stopped_ports
     def rx_vlan(self, vlan: int, port: int, add: bool, verify: bool = True) -> None:
         """Add specified vlan tag to the filter list on a port. Requires vlan filter to be on.
 
@@ -1964,6 +1966,7 @@ def rx_vlan(self, vlan: int, port: int, add: bool, verify: bool = True) -> None:
                     f"Testpmd failed to {'add' if add else 'remove'} tag {vlan} on port {port}."
                 )
 
+    @requires_stopped_ports
     def set_vlan_strip(self, port: int, enable: bool, verify: bool = True) -> None:
         """Enable or disable vlan stripping on the specified port.
 
-- 
2.39.2


  parent reply	other threads:[~2025-01-09 18:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 19:58 [PATCH v1 0/3] dts: add test suite for dual VLANs jspewock
2024-07-15 19:58 ` [PATCH v1 1/3] dts: fix Testpmd function for resetting VLAN insertion jspewock
2024-07-15 19:58 ` [PATCH v1 2/3] dts: add dual_vlan testing suite jspewock
2024-07-22 17:38   ` Dean Marx
2024-07-25 13:56     ` Jeremy Spewock
2024-07-31 13:54       ` Jeremy Spewock
2024-07-15 19:58 ` [PATCH v1 3/3] dts: add dual_vlan test suite to the yaml schema jspewock
2024-07-16 21:24 ` [PATCH v2 0/2] dts: add test suite for dual VLANs jspewock
2024-07-16 21:24   ` [PATCH v2 1/2] dts: add dual_vlan testing suite jspewock
2024-08-07 19:07     ` Dean Marx
2024-07-16 21:24   ` [PATCH v2 2/2] dts: add dual_vlan test suite to the yaml schema jspewock
2024-07-24 17:13 ` [PATCH v3 0/2] dts: add test suite for dual VLANs jspewock
2024-07-24 17:13   ` [PATCH v3 1/2] dts: add dual_vlan testing suite jspewock
2024-08-13 19:47     ` Dean Marx
2024-09-12  3:46     ` Patrick Robb
2025-01-09 18:01     ` Paul Szczepanek [this message]
2025-01-09 18:01       ` [PATCH v4 2/2] dts: add dual VLAN test suite Paul Szczepanek
2024-07-24 17:13   ` [PATCH v3 2/2] dts: add dual_vlan test suite to the yaml schema jspewock
2024-08-13 19:48     ` Dean Marx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109180124.1678253-1-paul.szczepanek@arm.com \
    --to=paul.szczepanek@arm.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).