From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D35146029; Fri, 10 Jan 2025 05:18:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B27F440648; Fri, 10 Jan 2025 05:18:03 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 0F59740612 for ; Fri, 10 Jan 2025 05:18:01 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-218c8aca5f1so33753595ad.0 for ; Thu, 09 Jan 2025 20:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736482681; x=1737087481; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zzMsXnut3bdwBrrzoZ0aVxhR9tTVECRQyox8EPXhWgg=; b=R1Gs6jN2sqAgx0oP46y3WRgOZqEyC4fNUEFZNChoPESoapVyvFUNu3s7qV7LOog7Xs PcMubxusPNVrXn57f3FD82tKRpAzJf1FGZiFmQjrmNIKkBIyMwT/N2VT4h7fPX3IqKiq ks88KqaS7K8n0uapqaG6pjz5+kxx03EPrtx0wzX6V9QAaINDcW6tDnq/MqAWJD62/n88 bBMQIm+vzFfYlqrnTfVTpP79lrJBvcPZr9ONS2qfxV5C+Eb0NvwliFnmjiZ70X6qgudQ 6xsJh0cXQyNIutTv+wcpZ+dP88F8jPghOQAeSjgQpfac+Yc90Y7h7j6i5HljO2RfgPRv GpQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736482681; x=1737087481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zzMsXnut3bdwBrrzoZ0aVxhR9tTVECRQyox8EPXhWgg=; b=Fig2TAG88SyqkW+Jgdk8lu/4OkvWfzYH+AiSiStByBwTwVKLk34wCN5UeLG98KCtdj BrmQHgdZVi/UWP6jj1iRzZ/AWjfxXK0U+sNuHV1XE8OAYsvmwzSOZFeCdfrteheucyQA brm7J5yTGxKs7lw+oDuhZKLRDUXfX3aFECKTs6mP7SKNc67vqRVf0PKU0SoZ6umxJgmO fJdmjYX9H570UswMlnRpvcyRuBs6Mgg5yG68185+m3ADA3BSU3c67piEVsna0JD0efAF g+guQu5sa0p2a4xnXNf0aW3cAp5JyLu9iUShksMl8eg/bzLRx1f3pKOMYq7RYTtdM5eC J5DQ== X-Gm-Message-State: AOJu0YzaPHXQArIh8mdI2fGu1Tc2CGe/FHSULOi+koIBMg0xbyM66aeX J6YkCDACZQN9Pg+BQRac5WGD/xfUKRHAsg7PLFncdP9Bbz7veEtHQZwBh/XjykY+9TSwFHRNLRT g X-Gm-Gg: ASbGnct3podEfQ03aYsGj3EYoDaPgrti7xZMbLgzTJ4SlrKlyp1IhE0+VziRzcOsew2 uFYUWMq4cWaPhoRBfn2QXbNePun/U7WWPXC2FBBTffksEF7fapbMevON4PX44s/baHfarQ10AeF sHcBD/1euooxEyNw+K66GyzA0yCtXDFhx1GSLn4h1isb9Z00HLsIGeO1ryg/vVq/4hhqbb4d6b7 RfJ4E40+GFZqNy4UZjMJ6bVoeo1s1U3k5NXwrKIYPiQlnSqXIfU7IfrVBMZZ4zfGGEuyIA7sBn6 AQdesp7HWyXRsP4QT4DLoEcfaaLUklCAww== X-Google-Smtp-Source: AGHT+IGpNlBVwYVxYHT/nNkDB2C4lz8p3xgtZniOmolVBABjfmcbI2KIoK7BCrEbkE68wHlFk14x3Q== X-Received: by 2002:a05:6a20:9185:b0:1e1:becc:1c91 with SMTP id adf61e73a8af0-1e88d361a0bmr15576652637.28.1736482680888; Thu, 09 Jan 2025 20:18:00 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d406a5a27sm606786b3a.166.2025.01.09.20.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 20:18:00 -0800 (PST) Date: Thu, 9 Jan 2025 20:17:58 -0800 From: Stephen Hemminger To: Zaiyu Wang Cc: dev@dpdk.org Subject: Re: [PATCH 00/15] net/ngbe: add VF driver support Message-ID: <20250109201758.6def2d82@hermes.local> In-Reply-To: <20250109040227.1016-1-zaiyuwang@trustnetic.com> References: <20250109040227.1016-1-zaiyuwang@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 9 Jan 2025 12:02:10 +0800 Zaiyu Wang wrote: > This patch adds support to VF device for ngbe PMD >=20 > Zaiyu Wang (15): > net/ngbe: add ethdev probe and remove for VF device > net/ngbe: add support for PF-VF mailbox interface > net/ngbe: add hardware configuration code for VF device > net/ngbe: add promiscuous and allmulticast ops for VF device > net/ngbe: add set MTU ops for VF device > net/ngbe: add add/remove/set mac addr ops for VF device > net/ngbe: add datapath init code for VF device > net/ngbe: add vlan related ops for VF device > net/ngbe: add interrupt support for VF device > net/ngbe: add link update ops for VF device > net/ngbe: add stats and xstats ops for VF device > net/ngbe: add start/stop/reset/close ops for VF device > net/ngbe: add multicast MAC filter ops for VF device > net/ngbe: add dump registers ops for VF device > net/ngbe: add some ops which PF has implemented >=20 > doc/guides/nics/features/ngbe_vf.ini | 38 + > drivers/net/ngbe/base/meson.build | 1 + > drivers/net/ngbe/base/ngbe.h | 1 + > drivers/net/ngbe/base/ngbe_hw.c | 4 + > drivers/net/ngbe/base/ngbe_mbx.c | 338 +++++++ > drivers/net/ngbe/base/ngbe_mbx.h | 31 + > drivers/net/ngbe/base/ngbe_type.h | 15 + > drivers/net/ngbe/base/ngbe_vf.c | 669 +++++++++++++ > drivers/net/ngbe/base/ngbe_vf.h | 68 ++ > drivers/net/ngbe/meson.build | 1 + > drivers/net/ngbe/ngbe_ethdev.h | 6 + > drivers/net/ngbe/ngbe_ethdev_vf.c | 1351 ++++++++++++++++++++++++++ > drivers/net/ngbe/ngbe_rxtx.c | 210 ++++ > 13 files changed, 2733 insertions(+) > create mode 100644 doc/guides/nics/features/ngbe_vf.ini > create mode 100644 drivers/net/ngbe/base/ngbe_vf.c > create mode 100644 drivers/net/ngbe/base/ngbe_vf.h > create mode 100644 drivers/net/ngbe/ngbe_ethdev_vf.c The build fails, please fix and resubmit *Build Failed #1: OS: OpenAnolis8.9-64 Target: x86_64-native-linuxapp-gcc FAILED: drivers/libtmp_rte_net_ngbe.a.p/net_ngbe_ngbe_ethdev_vf.c.o=20 gcc -Idrivers/libtmp_rte_net_ngbe.a.p -Idrivers -I../drivers -Idrivers/net/= ngbe -I../drivers/net/ngbe -Idrivers/net/ngbe/base -I../drivers/net/ngbe/ba= se -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/inc= lude -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/includ= e -Ilib/eal/x86/include -I../lib/eal/x86/include -I../kernel/linux -Ilib/ea= l/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/k= vargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry= -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/m= empool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter= -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pc= i -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib= /hash -Ilib/rcu -I../lib/rcu -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BI= TS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11 -O3 -include rte_con= fig.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-securi= ty -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style= -definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwr= ite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_= SOURCE -fPIC -march=3Dnative -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNA= L_API -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.ngbe -MD -= MQ drivers/libtmp_rte_net_ngbe.a.p/net_ngbe_ngbe_ethdev_vf.c.o -MF drivers/= libtmp_rte_net_ngbe.a.p/net_ngbe_ngbe_ethdev_vf.c.o.d -o drivers/libtmp_rte= _net_ngbe.a.p/net_ngbe_ngbe_ethdev_vf.c.o -c ../drivers/net/ngbe/ngbe_ethde= v_vf.c ../drivers/net/ngbe/ngbe_ethdev_vf.c: In function =E2=80=98eth_ngbevf_dev_i= nit=E2=80=99: ../drivers/net/ngbe/ngbe_ethdev_vf.c:222:2: error: implicit declaration of = function =E2=80=98ngbevf_dev_stats_reset=E2=80=99; did you mean =E2=80=98ng= bevf_dev_info_get=E2=80=99? [-Werror=3Dimplicit-function-declaration] ngbevf_dev_stats_reset(eth_dev); ^~~~~~~~~~~~~~~~~~~~~~ ngbevf_dev_info_get ../drivers/net/ngbe/ngbe_ethdev_vf.c:222:2: error: nested extern declaratio= n of =E2=80=98ngbevf_dev_stats_reset=E2=80=99 [-Werror=3Dnested-externs] ../drivers/net/ngbe/ngbe_ethdev_vf.c: At top level: ../drivers/net/ngbe/ngbe_ethdev_vf.c:448:1: error: static declaration of = =E2=80=98ngbevf_dev_stats_reset=E2=80=99 follows non-static declaration ngbevf_dev_stats_reset(struct rte_eth_dev *dev) ^~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ngbe/ngbe_ethdev_vf.c:222:2: note: previous implicit declara= tion of =E2=80=98ngbevf_dev_stats_reset=E2=80=99 was here ngbevf_dev_stats_reset(eth_dev); ^~~~~~~~~~~~~~~~~~~~~~