DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ariel Otilibili <otilibil@eurecom.fr>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	Ariel Otilibili <otilibil@eurecom.fr>
Subject: [PATCH 5/6] net/hinic: remove check around pthread_mutex_init()
Date: Sun, 12 Jan 2025 19:58:41 +0100	[thread overview]
Message-ID: <20250112185842.9752-6-otilibil@eurecom.fr> (raw)
In-Reply-To: <20250112185842.9752-1-otilibil@eurecom.fr>

> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.

Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 drivers/net/hinic/base/hinic_compat.h | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/hinic/base/hinic_compat.h b/drivers/net/hinic/base/hinic_compat.h
index ab9d1b9a0214..8f5763fbfc9d 100644
--- a/drivers/net/hinic/base/hinic_compat.h
+++ b/drivers/net/hinic/base/hinic_compat.h
@@ -200,13 +200,9 @@ static inline u16 ilog2(u32 n)
 static inline int hinic_mutex_init(pthread_mutex_t *pthreadmutex,
 					const pthread_mutexattr_t *mattr)
 {
-	int err;
-
-	err = pthread_mutex_init(pthreadmutex, mattr);
-	if (unlikely(err))
-		PMD_DRV_LOG(ERR, "Fail to initialize mutex, error: %d", err);
+	pthread_mutex_init(pthreadmutex, mattr);
 
-	return err;
+	return 0;
 }
 
 static inline int hinic_mutex_destroy(pthread_mutex_t *pthreadmutex)
-- 
2.30.2


  parent reply	other threads:[~2025-01-12 18:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-12 18:58 [PATCH 0/6] " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 1/6] raw/ifpga: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 2/6] net/bnxt: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 3/6] common/cnxk: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 4/6] net/failsafe: " Ariel Otilibili
2025-01-12 18:58 ` Ariel Otilibili [this message]
2025-01-12 18:58 ` [PATCH 6/6] lib/vhost: " Ariel Otilibili
2025-01-12 19:30 ` [PATCH v2 0/6] " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 1/6] raw/ifpga: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 2/6] net/bnxt: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 3/6] common/cnxk: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 4/6] net/failsafe: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 5/6] net/hinic: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 6/6] lib/vhost: " Ariel Otilibili
2025-01-12 20:20 ` [PATCH v3 0/6] " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 1/6] raw/ifpga: " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 2/6] net/bnxt: " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 3/6] common/cnxk: " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 4/6] net/failsafe: " Ariel Otilibili
2025-01-13 19:10     ` Stephen Hemminger
2025-01-12 20:20   ` [PATCH v3 5/6] net/hinic: " Ariel Otilibili
2025-01-13 19:09     ` Stephen Hemminger
2025-01-12 20:20   ` [PATCH v3 6/6] lib/vhost: " Ariel Otilibili
2025-01-13 19:11   ` [PATCH v3 0/6] " Stephen Hemminger
2025-01-14  8:22     ` Ariel Otilibili-Anieli
2025-01-13 17:19 ` [PATCH 0/1] eal/linux: Remove unused values Ariel Otilibili
2025-01-13 17:19   ` [PATCH 1/1] " Ariel Otilibili
2025-01-14  7:50 ` [PATCH v4 0/6] remove check around pthread_mutex_init() Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 1/6] raw/ifpga: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 2/6] net/bnxt: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 3/6] common/cnxk: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 4/6] net/failsafe: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 5/6] net/hinic: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 6/6] lib/vhost: " Ariel Otilibili
2025-01-14  8:48     ` Maxime Coquelin
2025-01-14 11:03       ` Ariel Otilibili-Anieli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250112185842.9752-6-otilibil@eurecom.fr \
    --to=otilibil@eurecom.fr \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).