DPDK patches and discussions
 help / color / mirror / Atom feed
From: Huisong Li <lihuisong@huawei.com>
To: <dev@dpdk.org>, <stephen@networkplumber.org>,
	<thomas@monjalon.net>, <ferruh.yigit@amd.com>,
	Aman Singh <aman.deep.singh@intel.com>
Cc: <fengchengwen@huawei.com>, <liuyonglong@huawei.com>,
	<lihuisong@huawei.com>
Subject: [PATCH v1 1/2] app/testpmd: check the validity of the port
Date: Mon, 13 Jan 2025 10:55:20 +0800	[thread overview]
Message-ID: <20250113025521.32703-2-lihuisong@huawei.com> (raw)
In-Reply-To: <20250113025521.32703-1-lihuisong@huawei.com>

This patch checks the validity of port id for all events in
'eth_event_callback()'.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Aman Singh <aman.deep.singh@intel.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
 app/test-pmd/testpmd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index ac654048df..cc13b06ddb 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3746,14 +3746,15 @@ eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,
 		fflush(stdout);
 	}
 
+	if (port_id_is_invalid(port_id, DISABLED_WARN))
+		return 0;
+
 	switch (type) {
 	case RTE_ETH_EVENT_NEW:
 		ports[port_id].need_setup = 1;
 		ports[port_id].port_status = RTE_PORT_HANDLING;
 		break;
 	case RTE_ETH_EVENT_INTR_RMV:
-		if (port_id_is_invalid(port_id, DISABLED_WARN))
-			break;
 		if (rte_eal_alarm_set(100000,
 				rmv_port_callback, (void *)(intptr_t)port_id))
 			fprintf(stderr,
-- 
2.22.0


  reply	other threads:[~2025-01-13  3:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13  2:55 [PATCH v1 0/2] ethdev: fix skip valid port in probing callback Huisong Li
2025-01-13  2:55 ` Huisong Li [this message]
2025-01-13  2:55 ` [PATCH v1 2/2] " Huisong Li
2025-01-13  8:16   ` Thomas Monjalon
2025-01-13  9:35     ` lihuisong (C)
2025-01-13 10:57       ` Thomas Monjalon
2025-01-13 11:23         ` lihuisong (C)
2025-01-13 12:05           ` lihuisong (C)
2025-01-13 12:30             ` Thomas Monjalon
2025-01-13 12:47               ` lihuisong (C)
2025-01-13 13:14                 ` Thomas Monjalon
2025-01-14  1:50                   ` lihuisong (C)
2025-01-14 11:13                     ` Thomas Monjalon
2025-01-14 12:13                       ` lihuisong (C)
2025-01-14 12:39                         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113025521.32703-2-lihuisong@huawei.com \
    --to=lihuisong@huawei.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=ferruh.yigit@amd.com \
    --cc=liuyonglong@huawei.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).