From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75A7746073; Mon, 13 Jan 2025 17:30:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4B3640DDB; Mon, 13 Jan 2025 17:30:06 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id ED19B402A7 for ; Mon, 13 Jan 2025 17:30:04 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2166651f752so99888315ad.3 for ; Mon, 13 Jan 2025 08:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736785804; x=1737390604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ywqfrkY3s7D+ycoK2qhbJzJvmpbaZj2NO/IDR8KDhg0=; b=TsoVO8ocK7yGObOa/wkZKYSd0c7vL4zEztrzDAVBnlbE9ZvWVWZNGeSYOY88/7jX1R cD1Hve1QP6hs0MLkEGYnrgUoJ3hMgvgoCVvkXAgkwoYIgrnlSGfy8ERztxXrrwz3HOHt kJXO41TpwPyv/V3W0Kz4Ak/x1vzwyvrUBuz7e2IhGyV6x4fQHqvacu4g6It3L7zu2q1R ZZjYmRd+tEXbG4Ax3JamhryGS4tmH8KzLI8CxnbMorWLi93I6ZR3uz+KxPzoTlzVppPm xQuT++MMquNnvS35e0/m8SfRbhajqgu6IMfhyiWJWgFLskYwMRODXFRUAh+cTrRsKQ1Z AgKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736785804; x=1737390604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ywqfrkY3s7D+ycoK2qhbJzJvmpbaZj2NO/IDR8KDhg0=; b=KQe55N+ln6xde4pl74n0M1MtMP0y0SZIHJ63MsWYbdTxiqxJeA8476JUA7+BRB8eNL uVv40wnYSndCMQvbz73ltUWNGw5nJGTYxmUgqg+fKu0WApgfmH0pMRkJI8CLuhWrQLPJ jSS6xZof/VLPQiOuU2R72vvkA+Uk0haYBULfk+sPAgOv1aiqgaPbrZSlKetdkSfQ24Zp VZ1pRlMoff7m3TYR5DLtsT5iHlwrmFAPOQ2zo1YKW8c752n11GQW+L4A+5Wh1jFg+6Ma 2Yw70CjM/UtrgAQDAtko2SlHJdb3Ud+I2Ue37Tf5BscI1ZBSKB7Lhhq9uS8i9+UL02vY qi2g== X-Forwarded-Encrypted: i=1; AJvYcCUdwr1kym5xkNh3lfKa714AkNiUyhSsiZtwFkYFNE9vykO4uHQU+XpljxK1q1XRVaMBAPk=@dpdk.org X-Gm-Message-State: AOJu0YylOy85MrlqdfNvIE2KzNDSXloJZ+ejGsANsecwwGXiSh7+UOWo 6Mw4/wTeZpJ4UhAJZlV+SSSxQbYuAaQIQFmPst5LTK++Lj6/JV0Y+p0u7MFGVB0= X-Gm-Gg: ASbGncuYrTi7SeEKShr6FXrEbiGsHeqGuZXkuMK5DzTrbRP/W4GyFdA00aCA0r105H1 s3PrPjZSL4yC0778C9vPwWHEwmXLkLIn5im5ZU9vNtUX35Pwd/zcFS7mGY7vau4fqbXaaDF6URM lJGQf3LzckJZPIJMCQVbGlMKts8ZdlwEtJwn9qaMDYFcRnrHxYBin2NWRggiLfst3VyxTjO4PtS CIEZ51FrueLlmw/Kn05NxbEUCyIdmSuneqcZfrZT+UArhcC0Mp+YgLqr/mK0OY7MoYq66Z+gg3M QVlYYEgWVr07GNspJxNGvz/5IrdX/FJA2Q== X-Google-Smtp-Source: AGHT+IFAv7QmhTf3v55ijV8aLCLxfc/9PKaSrmv5VagMVKbF51DdKUFrcBO1Nkx9uIJUN52J3sO3xg== X-Received: by 2002:a05:6a00:4485:b0:728:ea15:6d68 with SMTP id d2e1a72fcca58-72d21fdfa27mr31989637b3a.18.1736785803712; Mon, 13 Jan 2025 08:30:03 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4054942dsm5959905b3a.21.2025.01.13.08.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 08:30:03 -0800 (PST) Date: Mon, 13 Jan 2025 08:30:01 -0800 From: Stephen Hemminger To: Praveen Shetty Cc: bruce.richardson@intel.com, dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v1] common/idpf: fix heap use after free error Message-ID: <20250113083001.611db94d@hermes.local> In-Reply-To: <20250113085404.1447006-1-praveen.shetty@intel.com> References: <20250113085404.1447006-1-praveen.shetty@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Jan 2025 08:54:04 +0000 Praveen Shetty wrote: > Heap use after free error is detected in AddressSanitizer while quitting > the testpmd application.Issue is due to accessing the empty control > queue in the idpf_ctlq_deinit function.idpf_ctlq_deinit function is called > during the rte_eal_cleanup routine. > This patch will fix this issue. > > Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") > Cc: stable@dpdk.org > > Signed-off-by: Praveen Shetty This should not be needed. LIST_FOR_EACH_ENTRY_SAFE part, don't understand.