DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ariel Otilibili <ariel.otilibili@6wind.com>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	Ariel Otilibili <ariel.otilibili@6wind.com>,
	Didier Pallard <didier.pallard@6wind.com>,
	Edwin Brossette <edwin.brossette@6wind.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	Thierry Herbelot <thierry.herbelot@6wind.com>,
	stable@dpdk.org
Subject: [PATCH 1/1] eal/linux: Remove unused values
Date: Mon, 13 Jan 2025 18:19:20 +0100	[thread overview]
Message-ID: <20250113171920.1185214-2-ariel.otilibili@6wind.com> (raw)
In-Reply-To: <20250113171920.1185214-1-ariel.otilibili@6wind.com>

Found by static analysis:

In dev_uev_socket_fd_create(), fd is assigned before a return,
and not used.

The same for the variables buf and i in dev_uev_parse().

Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle")
Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")

Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com>
---
 lib/eal/linux/eal_dev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index e63f24d108c7..be97f56424de 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -129,7 +129,6 @@ dev_uev_socket_fd_create(void)
 	return 0;
 err:
 	close(fd);
-	fd = -1;
 	return ret;
 }
 
@@ -165,8 +164,6 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length)
 		 * uevent from udev.
 		 */
 		if (!strncmp(buf, "libudev", 7)) {
-			buf += 7;
-			i += 7;
 			return -1;
 		}
 		if (!strncmp(buf, "ACTION=", 7)) {
-- 
2.30.2


  reply	other threads:[~2025-01-13 17:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-12 18:58 [PATCH 0/6] remove check around pthread_mutex_init() Ariel Otilibili
2025-01-12 18:58 ` [PATCH 1/6] raw/ifpga: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 2/6] net/bnxt: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 3/6] common/cnxk: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 4/6] net/failsafe: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 5/6] net/hinic: " Ariel Otilibili
2025-01-12 18:58 ` [PATCH 6/6] lib/vhost: " Ariel Otilibili
2025-01-12 19:30 ` [PATCH v2 0/6] " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 1/6] raw/ifpga: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 2/6] net/bnxt: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 3/6] common/cnxk: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 4/6] net/failsafe: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 5/6] net/hinic: " Ariel Otilibili
2025-01-12 19:30   ` [PATCH v2 6/6] lib/vhost: " Ariel Otilibili
2025-01-12 20:20 ` [PATCH v3 0/6] " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 1/6] raw/ifpga: " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 2/6] net/bnxt: " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 3/6] common/cnxk: " Ariel Otilibili
2025-01-12 20:20   ` [PATCH v3 4/6] net/failsafe: " Ariel Otilibili
2025-01-13 19:10     ` Stephen Hemminger
2025-01-12 20:20   ` [PATCH v3 5/6] net/hinic: " Ariel Otilibili
2025-01-13 19:09     ` Stephen Hemminger
2025-01-12 20:20   ` [PATCH v3 6/6] lib/vhost: " Ariel Otilibili
2025-01-13 19:11   ` [PATCH v3 0/6] " Stephen Hemminger
2025-01-14  8:22     ` Ariel Otilibili-Anieli
2025-01-13 17:19 ` [PATCH 0/1] eal/linux: Remove unused values Ariel Otilibili
2025-01-13 17:19   ` Ariel Otilibili [this message]
2025-01-14  7:50 ` [PATCH v4 0/6] remove check around pthread_mutex_init() Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 1/6] raw/ifpga: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 2/6] net/bnxt: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 3/6] common/cnxk: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 4/6] net/failsafe: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 5/6] net/hinic: " Ariel Otilibili
2025-01-14  7:50   ` [PATCH v4 6/6] lib/vhost: " Ariel Otilibili
2025-01-14  8:48     ` Maxime Coquelin
2025-01-14 11:03       ` Ariel Otilibili-Anieli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250113171920.1185214-2-ariel.otilibili@6wind.com \
    --to=ariel.otilibili@6wind.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=edwin.brossette@6wind.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thierry.herbelot@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).