From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF10746074; Mon, 13 Jan 2025 18:20:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E331740BA4; Mon, 13 Jan 2025 18:20:06 +0100 (CET) Received: from mail-ej1-f97.google.com (mail-ej1-f97.google.com [209.85.218.97]) by mails.dpdk.org (Postfix) with ESMTP id 0BEA540649 for ; Mon, 13 Jan 2025 18:20:05 +0100 (CET) Received: by mail-ej1-f97.google.com with SMTP id a640c23a62f3a-aaecf50578eso890697866b.2 for ; Mon, 13 Jan 2025 09:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1736788804; x=1737393604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OBNnxFg8f8ouFb4P2fLYbn/QOzPOFwJhbuxli6Kff/I=; b=M3AQYxe6ug82Iit6X4gdfCIOoKHt6NCtsuBw9UYdq51dMcUqnx+hNiD7EW0thq16NK hsMxInQISL01095PBpqfhlvvqyIJo4P+mTz6/vtnkyReAK9Azi3apkB9nTJwa4hTAXy0 kitJZl5DXGxKshNX6l1+aWVmsJ1oIpykXgpIvwclT2QMfv2j/WR2zmJUdeOvy6XXZXKO 2j4pEvXeqCTxscE2tlKXTSZ3jk2cSk4w7M8ymz6yJ5LnKkYu3MGIUqbfLECNU10Mw4JB MLtZ9qfrPxyf89e/QsbEIUBcmXz1qhEkqxQk/Uym590rJvR8IR9meu4o8DlOq3fhkUXs LojQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736788804; x=1737393604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OBNnxFg8f8ouFb4P2fLYbn/QOzPOFwJhbuxli6Kff/I=; b=w4PUV8TbFFOzhCj8iQmoncZNd+aXqnvVGCN+yobUUWi9ta3WBVwDXudgOD53D02ZYE Bfl19OgYM2Zf8bDAYCx7MpkHD/Rjf4nSPPAyj/Zson65UoarJyddBKEEcZijMzZi/wt/ nOoIx69v4Tz/aXF3/WffTX1x6iJKFMiZqhMjQ8b8zUkPHbccaWbjx+DlALll94S7DNfT T9WQRzmBI/cPNfM+u7rKTXQjFkUcgi0JZR3jgk/xpBivYFjZOqGso/VIWnxbAqHzVCct 5Q++I4CgUelVRviR9JwfY0g4krQZNtxpGTgSp1+I1gi5jSedtrlZspu/rfbedE1bShNZ 5wKg== X-Gm-Message-State: AOJu0YysOhJcZP+ul54r3be4FCjGY93M40l/q60IH194RYd/uGdN6mFD ABVk2yPEQUA6HF08hIoosG53Ci+wJKeLLURnERmEADbGmlXCh7y+bJoPPDfBHgbZPRHBRx9QWcC d46iS2n3eCAF4X/O+ZBSSA/FVvv54e0LUY/albAFO X-Gm-Gg: ASbGncuUZQhJx+sP8y1Hk43pOYi5aV7UlnW+NlwthX4HCo5LfDIP+HS+iETuyYkEGY2 cKiqlyUl7DGCrrMiCJKdDHJW2nECptFx/sfJ2298QI8/9QKdCbb8va966SwybhZ/AX0Q3i1KhGs Cy1xTqEWUgpNsDStZVUBX/jcff3jJvQfTLgVYKd/+5eaSYLQ1YkGobC1ygdE6J6ajxEIYOOTDkQ rAV+9x3V7FM57R5hRxELqvx4hRQnv3WjUrV6PL9u0bmANZqPMsdGo5siMKb5otii+Pz35ccpChf 7YymDcndYbu08eBQ2Ho57FA5WA== X-Google-Smtp-Source: AGHT+IE+Sb/72u6FS5uhCPjZlnj8mkoSJ8jRWFLCSwyhV7yTuyeCrFk8+nAKMA6Vcri2PMVbJSAavZk7Xr/d X-Received: by 2002:a17:907:97c6:b0:aaf:208:fd3f with SMTP id a640c23a62f3a-ab2ab558911mr1994035466b.13.1736788803490; Mon, 13 Jan 2025 09:20:03 -0800 (PST) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id a640c23a62f3a-ab2c9060bbbsm46021366b.17.2025.01.13.09.20.03; Mon, 13 Jan 2025 09:20:03 -0800 (PST) X-Relaying-Domain: 6wind.com Received: from localhost (rainbow.dev.6wind.com [10.17.1.165]) by smtpservice.6wind.com (Postfix) with ESMTP id 4DAB7147B7; Mon, 13 Jan 2025 18:20:03 +0100 (CET) From: Ariel Otilibili To: dev@dpdk.org Cc: Stephen Hemminger , Thomas Monjalon , David Marchand , Ariel Otilibili , Didier Pallard , Edwin Brossette , Olivier Matz , Thierry Herbelot , stable@dpdk.org Subject: [PATCH 1/1] eal/linux: Remove unused values Date: Mon, 13 Jan 2025 18:19:20 +0100 Message-Id: <20250113171920.1185214-2-ariel.otilibili@6wind.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250113171920.1185214-1-ariel.otilibili@6wind.com> References: <20250112185842.9752-1-otilibil@eurecom.fr> <20250113171920.1185214-1-ariel.otilibili@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Found by static analysis: In dev_uev_socket_fd_create(), fd is assigned before a return, and not used. The same for the variables buf and i in dev_uev_parse(). Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Signed-off-by: Ariel Otilibili --- lib/eal/linux/eal_dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index e63f24d108c7..be97f56424de 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -129,7 +129,6 @@ dev_uev_socket_fd_create(void) return 0; err: close(fd); - fd = -1; return ret; } @@ -165,8 +164,6 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) * uevent from udev. */ if (!strncmp(buf, "libudev", 7)) { - buf += 7; - i += 7; return -1; } if (!strncmp(buf, "ACTION=", 7)) { -- 2.30.2