From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBA8746038; Mon, 13 Jan 2025 21:07:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BD434025D; Mon, 13 Jan 2025 21:07:10 +0100 (CET) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by mails.dpdk.org (Postfix) with ESMTP id 4016D4025A for ; Mon, 13 Jan 2025 21:07:10 +0100 (CET) Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4679eacf25cso32368411cf.3 for ; Mon, 13 Jan 2025 12:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1736798829; x=1737403629; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oyoT7QC4ZnoV+vCM/aW3krcMh4VK43I75SHYlLYz0SA=; b=A+CDK2ggjcMNom/Lk6jxc0tGRIYe6vx8lY8J0MlHc3rIGpwIyi8zUSRmYwC7Oc/G8o gm356t9XgEEYw2UGICeBmtEAHTib3rkBDvcF1YlezwGgTWIFjzZR38Hb8KBz/r9JKIah QKStUh6qB/6+ef9YdJYPvHNdTehowzOifWlr4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736798829; x=1737403629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oyoT7QC4ZnoV+vCM/aW3krcMh4VK43I75SHYlLYz0SA=; b=casPkc4YTecZbPYcEN9KsgjJXWbBoBjqK6Mig8+C4ZqCMZKlAO//3aPxfkI+oJkHtA e1gcmwxTQE72B4tFNCMBHP9rl9niK/VFzuZLB3Otwg7XW0oKja6vzE7yFiD0wlkppjZh 4MXkooQRBOajKOK5ynKlDI8qKfeCdCfTnFKiFwuBTaZtIg/iBdlF1S15mVnQwhHCfeT4 Am3mxcm06K69nhvxvH12vNC9bG8emgw9IDBHv+E2Q9k91WPknX95ZZLW2ceSprQFbosJ Xehz7O+re6olfnTRi0sJ4lzEfxjnMmBDfwnfHthqolwB8od9v3PlUcEUvOHQjSFHVqhW GOPA== X-Gm-Message-State: AOJu0YzC3xu6L7TyQar69GhabGEl/rGi93PhnzPup1eJQWxIUK6MvLv/ xyn/zzDNvqs3eWZiex2XN6mjHCXGfghc9KbfxgaUSXvDUVvUABou7SY825qgouo= X-Gm-Gg: ASbGncsJAMdwUC7f5YQa+FCwql7LneBiBgtll44SbNnYQAt2m5d3zMr6xJqts0pWDsK zzh6g85GNQCUtIRsY+eNnncLo4WOpvUldftqJimyRzGtvT5QWSshT8nOVlejZHl23x62aSPGLkQ EFKUq0CvM5OUscSjg28Qj1GxEj8kxF8ii53xYj9wVM23OMFmfBfN3WNANZZTh7ke1Sb5kdGcimt fY1CzvFAauhDmUKInwHW/YN+0Go+NW0CCBv+nEF5ir7FyvxDkLi7Y2leOaLmMaT5yNZMHarTrSB X5H2YFO6rMsXCkWZqU+LrhmudsI= X-Google-Smtp-Source: AGHT+IFb8hyC69dVxAcNFQf8Mbsmu8vilQDodyzPh7l1ws0yMyYFXMZqCsUS4kui0NRf/7wjHSlFjg== X-Received: by 2002:a05:622a:10e:b0:467:8797:29f1 with SMTP id d75a77b69052e-46c710f8eb6mr329627421cf.45.1736798829525; Mon, 13 Jan 2025 12:07:09 -0800 (PST) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46c873cddfesm44531051cf.57.2025.01.13.12.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 12:07:09 -0800 (PST) From: Dean Marx To: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org, Dean Marx , Jeremy Spewock Subject: [PATCH v15] dts: port over queue start/stop suite Date: Mon, 13 Jan 2025 15:07:09 -0500 Message-ID: <20250113200709.4615-1-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250106203747.22489-1-dmarx@iol.unh.edu> References: <20250106203747.22489-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. The verify argument in the deferred start method has been excluded due to a bug in testpmd, which renders checking port queue info for deferred start status impossible within a single method. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/remote_session/testpmd_shell.py | 18 +++ dts/tests/TestSuite_queue_start_stop.py | 135 ++++++++++++++++++ 2 files changed, 153 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index aa55bd91d3..a90c5ff7a8 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -2248,6 +2248,24 @@ def set_queue_ring_size( f"Failed to update ring size of queue {queue_id} on port {port_id}" ) + @requires_stopped_ports + def set_queue_deferred_start( + self, port_id: int, queue_id: int, is_rx_queue: bool, on: bool + ) -> None: + """Set the deferred start attribute of the specified queue on/off. + + Args: + port_id: The port that the queue resides on. + queue_id: The ID of the queue on the port. + is_rx_queue: Whether to modify an RX or TX queue. If :data:`True` an RX queue will be + updated, otherwise a TX queue will be updated. + on: Whether to set deferred start mode on or off. If :data:`True` deferred start will + be turned on, otherwise it will be turned off. + """ + queue_type = "rxq" if is_rx_queue else "txq" + action = "on" if on else "off" + self.send_command(f"port {port_id} {queue_type} {queue_id} deferred_start {action}") + def _update_capabilities_from_flag( self, supported_capabilities: MutableSet["NicCapability"], diff --git a/dts/tests/TestSuite_queue_start_stop.py b/dts/tests/TestSuite_queue_start_stop.py new file mode 100644 index 0000000000..954e274c93 --- /dev/null +++ b/dts/tests/TestSuite_queue_start_stop.py @@ -0,0 +1,135 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2024 University of New Hampshire + +"""Rx/Tx queue start and stop functionality suite. + +This suite tests the ability of the poll mode driver to start and +stop either the Rx or Tx queue (depending on the port) during runtime, +and verify that packets are not received when one is disabled. + +Given a paired port topology, the Rx queue will be disabled on port 0, +and the Tx queue will be disabled on port 1. + +""" + +from scapy.layers.inet import IP +from scapy.layers.l2 import Ether +from scapy.packet import Raw + +from framework.remote_session.testpmd_shell import SimpleForwardingModes, TestPmdShell +from framework.test_suite import TestSuite, func_test +from framework.testbed_model.capability import NicCapability, TopologyType, requires + + +@requires(topology_type=TopologyType.two_links) +@requires(NicCapability.RUNTIME_RX_QUEUE_SETUP) +@requires(NicCapability.RUNTIME_TX_QUEUE_SETUP) +class TestQueueStartStop(TestSuite): + """DPDK Queue start/stop test suite. + + Ensures Rx/Tx queue on a port can be disabled and enabled. + Verifies packets are not received when either queue is disabled. + The suite contains four test cases, two Rx queue start/stop and + two Tx queue start/stop, which each disable the corresponding + queue and verify that packets are not received/forwarded. There + are two cases that verify deferred start mode produces the expected + behavior in both the Rx and Tx queue. + """ + + def send_packet_and_verify(self, should_receive: bool = True) -> None: + """Generate a packet, send to the DUT, and verify it is forwarded back. + + Args: + should_receive: Indicate whether the packet should be received. + """ + packet = Ether() / IP() / Raw(load="xxxxx") + received = self.send_packet_and_capture(packet) + contains_packet = any( + packet.haslayer(Raw) and b"xxxxx" in packet.load for packet in received + ) + self.verify( + should_receive == contains_packet, + f"Packet was {'dropped' if should_receive else 'received'}", + ) + + @func_test + def test_rx_queue_start_stop(self) -> None: + """Rx queue start stop test. + + Steps: + Launch testpmd, stop Rx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=True) + + @func_test + def test_tx_queue_start_stop(self) -> None: + """Tx queue start stop test. + + Steps: + Launch testpmd, stop Tx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not forwarded. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=True) + + @func_test + def test_rx_queue_deferred_start(self) -> None: + """Rx queue deferred start stop test. + + Steps: + Launch testpmd, enable deferred start on Rx queue 0 port 0. + Stop Rx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_all_ports() + testpmd.set_queue_deferred_start(0, 0, True, True) + testpmd.start_all_ports() + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=True) + + @func_test + def test_tx_queue_deferred_start(self) -> None: + """Tx queue start stop test. + + Steps: + Launch testpmd, enable deferred start on Tx queue 0 port 0. + Stop Tx queue 0 on port 0. + Verify: + Send a packet on port 0, ensure it is not forwarded. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_all_ports() + testpmd.set_queue_deferred_start(1, 0, False, True) + testpmd.start_all_ports() + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=True) -- 2.44.0