From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CD4A846075;
	Mon, 13 Jan 2025 22:30:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6DA464025D;
	Mon, 13 Jan 2025 22:30:15 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 7E8164025A
 for <dev@dpdk.org>; Mon, 13 Jan 2025 22:30:13 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 8A26320591A0; Mon, 13 Jan 2025 13:30:12 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8A26320591A0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1736803812;
 bh=w49Ha0h1/KdKQcxAs2VAWj08Yy87ztLQ9zo0DOpTdFw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=GBKUDtxz5Hzk1SUV6Ixn2fvaHj6tz90M0JnzsDXPtT1FgTPq8XNB1cBJwjl/44cyV
 sc594dbDGgYMgptxJ74/fA0mfHNZqtnAL0jjTAmkDLORSmS1VBlmhH+J7d1lptVRU6
 CePrlCPcQjJQrVlwCDx2FAOeLnKZueKq0OxcBgK4=
Date: Mon, 13 Jan 2025 13:30:12 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, konstantin.ananyev@huawei.com, homas@monjalon.net,
 david.marchand@redhat.com
Subject: Re: [PATCH v14 03/81] eal/common: remove use of VLAs
Message-ID: <20250113213012.GA24441@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
 <1736540620-21764-1-git-send-email-andremue@linux.microsoft.com>
 <1736540620-21764-4-git-send-email-andremue@linux.microsoft.com>
 <20250110171405.34337a79@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250110171405.34337a79@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Jan 10, 2025 at 05:14:05PM -0800, Stephen Hemminger wrote:
> On Fri, 10 Jan 2025 12:22:22 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > diff --git a/lib/eal/meson.build b/lib/eal/meson.build
> > index e1d6c4cf17..352db049e9 100644
> > --- a/lib/eal/meson.build
> > +++ b/lib/eal/meson.build
> > @@ -31,3 +31,11 @@ endif
> >  if is_freebsd
> >      annotate_locks = false
> >  endif
> > +
> > +warning_flags = ['-Wvla']
> > +
> > +foreach arg: warning_flags
> > +    if cc.has_argument(arg)
> > +        cflags += arg
> > +    endif
> > +endforeach
> > -- 
> 
> Could we enable it for all libs and only turn it off as required?

Yes. Although the data types in meson are additive only, we can
add -Wno-vla to cancel a -Wvla already present. Let me send out a
new series with this change.