From: Stephen Hemminger <stephen@networkplumber.org>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Alok Prasad <palok@marvell.com>,
dev@dpdk.org
Subject: Re: [PATCH 2/2] drivers/net: remove unused variables and add MSVC compiler flag
Date: Tue, 14 Jan 2025 09:46:35 -0800 [thread overview]
Message-ID: <20250114094635.17621005@hermes.local> (raw)
In-Reply-To: <1735238504-15597-3-git-send-email-andremue@linux.microsoft.com>
On Thu, 26 Dec 2024 10:41:44 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:
> Removed unused variables and added MSVC specific compiler flag to
> ignore warnings about unused variables, like is being done for
> other compilers.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> drivers/net/ice/base/ice_switch.c | 2 --
> drivers/net/ice/base/meson.build | 16 ++++++---
> drivers/net/qede/base/ecore_dcbx.c | 2 --
> drivers/net/qede/base/ecore_mcp.c | 2 --
> drivers/net/qede/base/meson.build | 57 +++++++++++++++++-------------
> 5 files changed, 43 insertions(+), 36 deletions(-)
Makes sense, but this base (ie shared across OS code).
Can't make changes there in general; and requires approval of that PMD maintainer.
next prev parent reply other threads:[~2025-01-14 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 18:41 [PATCH 0/2] " Andre Muezerie
2024-12-26 18:41 ` [PATCH 1/2] drivers/common: " Andre Muezerie
2025-01-06 10:50 ` Bruce Richardson
2024-12-26 18:41 ` [PATCH 2/2] drivers/net: " Andre Muezerie
2025-01-14 17:46 ` Stephen Hemminger [this message]
2025-01-14 20:46 ` [PATCH v2 0/2] " Andre Muezerie
2025-01-14 20:46 ` [PATCH v2 1/2] drivers/common: " Andre Muezerie
2025-01-14 20:46 ` [PATCH v2 2/2] drivers/net: add MSVC compiler flag for unused variables Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114094635.17621005@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=palok@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).