From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C01864606E; Tue, 14 Jan 2025 18:46:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92C8E40299; Tue, 14 Jan 2025 18:46:39 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 3254840298 for ; Tue, 14 Jan 2025 18:46:38 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2efd81c7ca4so7680890a91.2 for ; Tue, 14 Jan 2025 09:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736876797; x=1737481597; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zE63GztY3frdmjoEFc8U+SoBCI32/PhXaXFv5Xrng8o=; b=bvdSzvLNC6SJHjFMgMBbbIKEXd7NdWPSsMSHrmHKOTn9+b35+JOmYOowjZo9/AU7y/ FsdFYLVApwCbv+0++4S8WUQxmrhns1vbQs/8Ijjhkq3dzKwdbmD5AUoqKTWeQUWaBkg7 bb1l9EZ0SfhDD87/HdQZYaKGbyhCBLHFcSAHcHm2eYQRwIVAAowQ86dq1/qeYKa6eZZ1 bIEyxPZlia7cBgo7XWpARxj+mQjxUBXnyfxMWsDCr2B0hB2Y6q6mJOevrWTLrMdVpb4G 3/Dj4lG+0zQV8OzN9Hkirs8qauRiWKztsLzP8kf23pF3NbuNcWzRW27+kTgQjmhQOWgB MI/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736876797; x=1737481597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zE63GztY3frdmjoEFc8U+SoBCI32/PhXaXFv5Xrng8o=; b=CNg4LWAVKpff21LDZJzMN8xPG8jXy3lM6mx8fX1CF8DwMNxsNwckXkwcwRMcvUw759 vlGSToKtYWmF2Hz+oUeZvyAAB7m4RDl9FDH0uqhAf3VFkFI+/7NlLNpZ4cYajGq9HdMi gpuK6V+V3PF87t5rYM+zkvS/H3l4VY88cdFwnCJogD7ffWMV2dOgVg5+XEh6NYuRo/mn 8/vjXM3dn9hQjJ4wsVe+6EYXWdbrWuf8sjkto92TUwqOaGlf6IH2C/boDOyzLcD6YjWl 3xn/wZZSNe0buO39pS+IL/xWrYARNzhJ0yxYfcoMB48+IS+IsmKhQGSijEMVqwW0pg3i 9K6w== X-Forwarded-Encrypted: i=1; AJvYcCWKE1bLEIi+TLs/H6cLZ5dw7CWTVRBfPeCp6IV0ddvPCL4jFQYD67JvufdAJURCX5UN4S0=@dpdk.org X-Gm-Message-State: AOJu0Yyijjs1Nlmm9go42uIHRGscaahaEjhQHSE4bi03f8ZP1i6JwBTQ 5k0saTQK33OkQKIK2W5gFBwEhFQYXS3H2QVMXqOlXJaqzJUu0pcASJd0pWxfUJE= X-Gm-Gg: ASbGnct4tQDVrbK6tp2D0WYEuQpMbg0yTl0UEqu6SIcCC//p8VGmWX5X8Adjl6LGUUo fPB6YQDn+2CG2w3Hzzri1YXQSD+ItzwOi10vb7nJErPkospi3Y8OfT/M7eFpqPnRdp7pdaz+BA6 mQGOOt/G19/ttM7JGlFYaBebirFMOoD6RwIHB5jkGIiYuD8xr0hhzk6V42P0ZzLl/vtLBybnFKN IMe5w0huXGjgQY2SpNCfub5N3hZ8lSj7Pw/QYgiD14M6LychzzhpDsuaw5FnTZP3KgOrncwRs21 LTpxYhn7ElcL3OmWp6a1qF6yIRiULoZG/g== X-Google-Smtp-Source: AGHT+IHDgXDoLGVAI12sfR4UVYBl87/3FJUi7LBLGfkJutNDvhukxMxSpq8oA6/yT5EzWSqe6wItUA== X-Received: by 2002:a17:90a:c106:b0:2ee:e961:3052 with SMTP id 98e67ed59e1d1-2f548ebb2damr39648230a91.14.1736876797188; Tue, 14 Jan 2025 09:46:37 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f54a36a085sm12011110a91.47.2025.01.14.09.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 09:46:36 -0800 (PST) Date: Tue, 14 Jan 2025 09:46:35 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: Bruce Richardson , Anatoly Burakov , Devendra Singh Rawat , Alok Prasad , dev@dpdk.org Subject: Re: [PATCH 2/2] drivers/net: remove unused variables and add MSVC compiler flag Message-ID: <20250114094635.17621005@hermes.local> In-Reply-To: <1735238504-15597-3-git-send-email-andremue@linux.microsoft.com> References: <1735238504-15597-1-git-send-email-andremue@linux.microsoft.com> <1735238504-15597-3-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 26 Dec 2024 10:41:44 -0800 Andre Muezerie wrote: > Removed unused variables and added MSVC specific compiler flag to > ignore warnings about unused variables, like is being done for > other compilers. > > Signed-off-by: Andre Muezerie > --- > drivers/net/ice/base/ice_switch.c | 2 -- > drivers/net/ice/base/meson.build | 16 ++++++--- > drivers/net/qede/base/ecore_dcbx.c | 2 -- > drivers/net/qede/base/ecore_mcp.c | 2 -- > drivers/net/qede/base/meson.build | 57 +++++++++++++++++------------- > 5 files changed, 43 insertions(+), 36 deletions(-) Makes sense, but this base (ie shared across OS code). Can't make changes there in general; and requires approval of that PMD maintainer.