From: Stephen Hemminger <stephen@networkplumber.org>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pascal Mazon <pascal.mazon@6wind.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing
Date: Tue, 14 Jan 2025 09:49:21 -0800 [thread overview]
Message-ID: <20250114094921.56b39528@hermes.local> (raw)
In-Reply-To: <DM4PR18MB4368C2FD10B06B1DB627FCCBD2132@DM4PR18MB4368.namprd18.prod.outlook.com>
On Thu, 9 Jan 2025 07:31:32 +0000
Tomasz Duszynski <tduszynski@marvell.com> wrote:
> >> From: Tomasz Duszynski <tduszynski@marvell.com>
> >> To: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
> >"Pascal Mazon" <pascal.mazon@6wind.com>
> >> CC: <jerinj@marvell.com>, Tomasz Duszynski <tduszynski@marvell.com>
> >> Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is
> >> missing
> >> Date: Wed, 8 Jan 2025 13:10:11 +0100
> >> X-Mailer: git-send-email 2.34.1
> >>
> >> If HAVE_TCA_FLOWER is undefined compilation errors / warnings may
> >> appear. This addresses following spotted issues:
> >>
> >> ../drivers/net/tap/rte_eth_tap.c:2113:1: error: label ‘disable_rte_flow’
> >> defined but not used [-Werror=unused-label]
> >>
> >> ../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter
> >> ‘remote_iface’ [-Werror=unused-parameter]
> >>
> >> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
> >> Cc: pascal.mazon@6wind.com
> >>
> >> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> >
> >Looks good, but realize that flower was added in kernel 4.2 and the current
> >oldest supported upstream kernel is 4.4.
> >So if you are using a supported kernel, flower will be present.
>
> It only pops up on 32bit build. That build is maybe not too common so error might have
> gone unnoticed. Anyway, I thought I would add these fixes just in case.
>
TCA_FLOWER is still available in 32 bit kernel looks like your build envrionment
is not using a supported kernel.
My goal is to get rid of #ifdef's since it creates untested variants and
multiple ifdef's create combinational chaos.
prev parent reply other threads:[~2025-01-14 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 12:10 Tomasz Duszynski
2025-01-08 15:43 ` Stephen Hemminger
2025-01-09 7:31 ` [EXTERNAL] " Tomasz Duszynski
2025-01-14 17:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114094921.56b39528@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pascal.mazon@6wind.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).