From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B03A44606E; Tue, 14 Jan 2025 18:49:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8833040299; Tue, 14 Jan 2025 18:49:25 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 4B1F740298 for ; Tue, 14 Jan 2025 18:49:24 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2166651f752so130750085ad.3 for ; Tue, 14 Jan 2025 09:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736876963; x=1737481763; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BBtlCpYbFst/jznWVePJYm/19fpZp51tM00nCF2Vbvg=; b=lOS28FpoYG7eFKUBu/Y1xtukxxB2i3/I+nO0+MpP/n87H4O3MRxDyryRbTsleKJqcu pIawyb8p3v3XS0lYz3jPaSnkmuCfkWlbYh3vlqyBSX5R9qttxJiACdERfANHWZmK76JK C55yQKC8AseAHqyhA4q+Q0Isqs7isgdUztcofjTYKiH+ncSKBMJqogvHEWC+56PgxElu QWJMPfAioMkDhflIc0VI2UZ7yYxuFNMpQ5IEiev8SIOTolOY6ABHaDn8g6uUL1LR7f96 nmvuL4PwFEtyiSOjpoD87dpa5xzE+cz+GSJoUCrO88s/WbFK1kdlcxQ/p9GS6/zG1Q7P UOZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736876963; x=1737481763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BBtlCpYbFst/jznWVePJYm/19fpZp51tM00nCF2Vbvg=; b=cPWjGQIVX2RCHpteV0D2KTAwEQEx5BuaUJcTld5jsFglis9FcBtrg3sBOuBQVLoDSF GBt055OtbCxy/Fidoof2zHQLkblVlFiACKERtFHyLfYttCWjotJU6d7wAMwt3v/I0zOc 2OeDRmsxEneS+0RpJ2f0r4t/1h7Gx0QWWSy8RTgwcbQHa6rHgwIs7ljYmxLeDpPs+UAL 241EOgA++q0i/NT/tES6G5sgLXW5KIyEF5medEMro6Zpk7+ekxD9cZX298opZgMFhNHT 9mzPrHDkZ+8d+3CkyFUtujRKiGeLFBdlhIuzv5f9SCWtXRWOeG5ym1j+DPo4ZUc3lh9Q smrg== X-Gm-Message-State: AOJu0YzbtdZFeg8nuc+axKMn7d8YxkHepSQEWF3s+B7bPI/rKEpCNjDV /FEk7GqjyLzdQV18QkJLVLS89YA4uFVDO4fYEPROkF1JwNfOttSD9D+GONPY6xs= X-Gm-Gg: ASbGncushGoB6mDW3/c1J8pxneZ6V7ycW/2O2a8847YObG7NLzVIa44I97bOrcN4q9/ G2/VIK14DSn7lL9ProxzH78MPcFxRaSFCB+ecHvItoh/EIcPUHHBuuAETItgKN4C9cqPSaBfLJa OzqCdF6YDBAY1IC2mj0qQKyywmNmfeAzTWLH7lpnGxkgLIBZ7mR/3iiE1VmG5rmYUB0X1tJQZ9s 2xtdwhSE3AMYSM0YpxWKPEGkHHfEehMIkgoBJ5Yug7iXlRkxH4867RN3zE9XN7Xvb1e75fQxzKi 1CCXdGupxB9bcQCyTarUgMJC4JsCrySq4Q== X-Google-Smtp-Source: AGHT+IFa98Yl8teFbbj7jVXtxEo6n6UPZx4HsB2wn0AqqYuJERKNFQLUaUk18xm9dSERr4tjSMlGrQ== X-Received: by 2002:a17:903:185:b0:216:4676:dfaf with SMTP id d9443c01a7336-21a83f96abamr396573525ad.34.1736876963442; Tue, 14 Jan 2025 09:49:23 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f2524ddsm68897875ad.209.2025.01.14.09.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 09:49:23 -0800 (PST) Date: Tue, 14 Jan 2025 09:49:21 -0800 From: Stephen Hemminger To: Tomasz Duszynski Cc: "dev@dpdk.org" , Pascal Mazon , Jerin Jacob Subject: Re: [EXTERNAL] Re: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing Message-ID: <20250114094921.56b39528@hermes.local> In-Reply-To: References: <20250108121011.2949616-1-tduszynski@marvell.com> <20250108074326.193cbf2d@pi5> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 9 Jan 2025 07:31:32 +0000 Tomasz Duszynski wrote: > >> From: Tomasz Duszynski > >> To: , Stephen Hemminger , =20 > >"Pascal Mazon" =20 > >> CC: , Tomasz Duszynski > >> Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is > >> missing > >> Date: Wed, 8 Jan 2025 13:10:11 +0100 > >> X-Mailer: git-send-email 2.34.1 > >> > >> If HAVE_TCA_FLOWER is undefined compilation errors / warnings may > >> appear. This addresses following spotted issues: > >> > >> ../drivers/net/tap/rte_eth_tap.c:2113:1: error: label =E2=80=98disable= _rte_flow=E2=80=99 > >> defined but not used [-Werror=3Dunused-label] > >> > >> ../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter > >> =E2=80=98remote_iface=E2=80=99 [-Werror=3Dunused-parameter] > >> > >> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") > >> Cc: pascal.mazon@6wind.com > >> > >> Signed-off-by: Tomasz Duszynski =20 > > > >Looks good, but realize that flower was added in kernel 4.2 and the curr= ent > >oldest supported upstream kernel is 4.4. > >So if you are using a supported kernel, flower will be present. =20 >=20 > It only pops up on 32bit build. That build is maybe not too common so err= or might have > gone unnoticed. Anyway, I thought I would add these fixes just in case.=20 > =20 TCA_FLOWER is still available in 32 bit kernel looks like your build envrio= nment is not using a supported kernel. My goal is to get rid of #ifdef's since it creates untested variants and multiple ifdef's create combinational chaos.