From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1365046084; Tue, 14 Jan 2025 11:13:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 034EE402ED; Tue, 14 Jan 2025 11:13:16 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id E5FD5402ED; Tue, 14 Jan 2025 11:13:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736849595; x=1768385595; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7dAk0dmszNRPzwSx9+g4bZ1dTf1t1nI8rP/Zf7Md8qI=; b=lDXCHjA7P7b/FBHWA9byngwkUi7scnVsS7MIF3Yby4aClPLPs7irqA2z BnYGbOrw92UpiiuvMF1zoYk0KyOOaWs5X3QdHTqFo21C+VxSPHOZ3UhGp i1gNkm6uePH3EbLOA1h6io4Qu5eCVElsfC5e8GltCJYlOkzPuT36ODhlS ud6QcOIjNRRg7YxSjmYCu+Xkdegr9B/vJXXUSnnotBPkDUlE2GOeZB2tw ZUitbz0TxPVUDb33aLl90uRN+6kBfGS2V8yz45wuHidqq+LnF3gstgphT WjXTWOsaeIypJ8H99oVZGkv+G3jppOTDQ2hQ38IvFm9Efl2V76M9oF45J w==; X-CSE-ConnectionGUID: ULsj4M33SFWOAXLIStHbUg== X-CSE-MsgGUID: hZ2jv/+aQGqAhknVUKF+IQ== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="36426756" X-IronPort-AV: E=Sophos;i="6.12,314,1728975600"; d="scan'208";a="36426756" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2025 02:13:14 -0800 X-CSE-ConnectionGUID: KgsJQoy/RnaoA3smasHxIA== X-CSE-MsgGUID: hoa69XdSS/yLCp9WYHA9Cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="128007102" Received: from unknown (HELO localhost.localdomain) ([10.239.252.210]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2025 02:13:10 -0800 From: Yuan Wang To: dev@dpdk.org Cc: anatoly.burakov@intel.com, vladimir.medvedkin@intel.com, Lukasz Krakowiak , stable@dpdk.org, Yuan Wang Subject: [PATCH 01/10] net/ixgbe/base: fix TSAM checking return value Date: Tue, 14 Jan 2025 18:10:11 +0800 Message-ID: <20250114101024.159941-2-yuanx.wang@intel.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250114101024.159941-1-yuanx.wang@intel.com> References: <20250114101024.159941-1-yuanx.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Lukasz Krakowiak The return value of ixgbe_get_fw_tsam_mode function may be a large integer that does not match the desired bool type. Fixes: 316637762a5f (net/ixgbe/base: enable E610 device) Cc: stable@dpdk.org Signed-off-by: Lukasz Krakowiak Signed-off-by: Yuan Wang --- drivers/net/ixgbe/base/ixgbe_api.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c index b4920867bc..ffff670dd3 100644 --- a/drivers/net/ixgbe/base/ixgbe_api.c +++ b/drivers/net/ixgbe/base/ixgbe_api.c @@ -1168,8 +1168,9 @@ s32 ixgbe_set_fw_drv_ver(struct ixgbe_hw *hw, u8 maj, u8 min, u8 build, */ bool ixgbe_get_fw_tsam_mode(struct ixgbe_hw *hw) { - return ixgbe_call_func(hw, hw->mac.ops.get_fw_tsam_mode, (hw), - IXGBE_NOT_IMPLEMENTED); + if (hw->mac.ops.get_fw_tsam_mode) + return hw->mac.ops.get_fw_tsam_mode(hw); + return false; } /** -- 2.43.5