From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0202446087; Wed, 15 Jan 2025 00:30:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FCA840299; Wed, 15 Jan 2025 00:30:59 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 6DD5440298 for ; Wed, 15 Jan 2025 00:30:58 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-216728b1836so106698755ad.0 for ; Tue, 14 Jan 2025 15:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736897457; x=1737502257; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Oix93RGaXmC721LveHMYgJq/OdRr+0y8Udso1Pmv4+E=; b=jrQPjo/ODE5RG5fjqSsKL0+VyR2JWA9XDE+MmU8Olj5UeUg22ifbLYiH3lmpF+zNcE C+42i+lSYEPJZDd1lul1EszqYzBzj5mPw7mM7TO8XsF5Rn/lDPKldlzFZY8FDKYtQonM 8HAGX+tW/FQ2XxUZuUjaH9arbAeg3ze5AxyzmGT9UGnlRopyu7HwkHVa9ZkKPWlWwIkl pLfNvyi/ndQbDVxzFOO89VJ36M+Bu2PY8Ed5rD+Xn9gKkYM0KqSCw/PJTGs1q42I6p0K neDUgJJBU/SaecBm0s3NcI5YOVKAatdK59GEah67gEV0pfdZmc+obSgvF5gLqVeM5lxC KIog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736897457; x=1737502257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oix93RGaXmC721LveHMYgJq/OdRr+0y8Udso1Pmv4+E=; b=tkwlm3DDPSOvCvolilZMhcHifoEEzXwDf6LJxEDC1mvSCJYg552s/gMi8GHDclbafJ 5uWaY/bUQvHgLUS7IELvx3buRZgReu3ULQOABsZdZcllMcmNvoQ6acKzSobB7610DN/d ZBG2MY6h0+F74qRnf3GZoU+8HfiCV4xyrCV663TGQkq6B8RFHFRmKxA4AdIkd2A4s+0X EP0wtnTitU2er1AtvutAWs+HO8DaVhMdv+wIy8GMvdppfVSW8PqlJlLQUlF6kxVLJmBs MeCQBvdHvGLRkR1w9B65I9FIm7et+c167z/x5/vC8yEjOe8DdkFa4stqIZfsi4FqgleB 4dUg== X-Forwarded-Encrypted: i=1; AJvYcCU2yhTWRbRkN1Mz7FvHQRn3Vixx2fFpD3yTZV/fA8NrXy/fwVXPLbLpQLIGoeKOACI6kmQ=@dpdk.org X-Gm-Message-State: AOJu0YwPCqMXKsikHk21w3HsQlgDuEf5RHNnzF/1NaXmnNCFdwYfn22W YXPLfbMya0pjebyYTTRoyEQdxYNH3BR9+2ToYwVAPRs8RAD2dq4nA9LzZ1f9W4Y= X-Gm-Gg: ASbGncspEMWNtoR2gEUDH7KewOg/Z9XQJUDqeB9r0WSvr5Ug0JI2XMtsTChHegf2gff i4nVy9P2i4WDKyJE9qRKct+M+OAoyv+VFg1wkRTzn2BE6tqgKizbs3NVyNTd84lTL4+R10pVImL BJDt1Mtx0byJW+SeFriLLTa3hECWmtL0XtksHwpZ+PAwy/NKaVMsuZJ9aeH8MQ+dvrtIGzYrVjm QGc1PWpFv9Vw8gFWYlVIbffqJGqx+AeUjTXrV1/efbxcovhbPXM1SvptiP1LobHHKa6K+wq/3KW qZMSHcApy091r0pKyUnHLVszz9C/Hy3ckA== X-Google-Smtp-Source: AGHT+IHsY6/ZmlQmy7cg25pOn5k2sLX0LiHFIk+azKQtk7ZZPNm2R1lNlVJHEATSICieZ1oEMl0hww== X-Received: by 2002:a05:6a00:a8f:b0:725:df1a:281 with SMTP id d2e1a72fcca58-72d21f318b3mr35441928b3a.10.1736897457310; Tue, 14 Jan 2025 15:30:57 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4065a560sm7932866b3a.87.2025.01.14.15.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:30:57 -0800 (PST) Date: Tue, 14 Jan 2025 15:30:54 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com, dev@dpdk.org, ian.stokes@intel.com, jochen.behrens@broadcom.com, vladimir.medvedkin@intel.com Subject: Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch Message-ID: <20250114153054.01906f7e@hermes.local> In-Reply-To: <20250114210828.GA3357@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1735246770-731-1-git-send-email-andremue@linux.microsoft.com> <1736198215-12861-1-git-send-email-andremue@linux.microsoft.com> <20250114104153.654dec88@hermes.local> <20250114210828.GA3357@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Jan 2025 13:08:28 -0800 Andre Muezerie wrote: > > > > Patches to base driver need to be avoided if at all possible. > > Please resubmit without that part > > Thanks for the information. I sent out a v3 for this series. > It does contain _coding style issues_ for preexisting code. > Hopefuly that can be ignored. Yeah, that is common. I always look to see why checkpatch is whining before merging.