From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A46846087; Wed, 15 Jan 2025 00:34:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9720D402D6; Wed, 15 Jan 2025 00:34:23 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id BB2C540299 for ; Wed, 15 Jan 2025 00:34:22 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2eed82ca5b4so10072468a91.2 for ; Tue, 14 Jan 2025 15:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736897662; x=1737502462; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fk0egZQkIGMz5VBagvNuhVnPFK85r1xdgWN+cFC51oA=; b=aMLTB2fSD70kxsNWK6Zen80ch9KEucCLl0/YVd7nEOxYs9k6DmdBpyaqo6Mo5uHcMd RbIH5nxsaXwUX7lCSL5oMunJotpfPd7tNGiGIvH//W1wqeXNX582eyLKN4UJslqz7wMV uyvyGMdZSgjCMuYGygd7pbD2LdCLs1cHhc7yJCWUd8s/mbn1rG2P8uyT54zxzBWrPsI9 S57C8HZpZJNYr+LsRXi3CIdXwZ0sQ3uv2pQGxwqZBYIS0hW7lmUmDOorRl5snYuFoYHx AK+NGmPyFnac+S08OCsQIgDAZKrf666Uv/SMEFEVZzekNnxUGokJggHbC/dKk68NtzWC 238g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736897662; x=1737502462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fk0egZQkIGMz5VBagvNuhVnPFK85r1xdgWN+cFC51oA=; b=qbSQR4Zc+PO/fcjVEYrEA09igBnD11XBjFZcWgNPwRs4VCDv5723qXojoHgyXpR1F4 kCZPQZe3nKeGeyx/nU69SEgwi1fCHzZx4+sThQEURBV+XEAuw0XAxpU1gdS4AzcoKD2b WGLkAOIUfyivfYVEmjEUArQpkbmKnIDZ6RM5KkCwUYOM91eyyBECtA7+lqUm5tpZpmbm 7kFoWfgK5wklI3fU0MGO7fY5MkIMscB2ncRA9dnGipeumtwhx+se8P3IjFNuDTNKJJhU SGB6qgyd/vG1bZ8nHWY2TvOBNDOyCGvkNTJGG0Kebpe8S2HUK3FDHim5btAPeN6OoOZL 02FQ== X-Gm-Message-State: AOJu0Yw1fLB8cvwrzbWq7rMBriS91EgqgZYhflnw6oKdWmB2zVJFayqu 3SbnDopsMCQGIfgyQZbd0xWUM4nguYfMsbBWurZx9ByedExmjqAhFT6TlnQXYxU= X-Gm-Gg: ASbGnctDZzAwArk+TTHIq2BgX8Zl+YZ4wHT1RzuFr3mhtWeAXBAoeP8j/LB7+RdcBbv pGjE9kL/QLSfep3i0VFHM7U8+7X5uF0yhq+vCrjUx2TYPkQx8Pw8kWO1RX9DlCQswupBz278izE 2zL6tr023rFZuF5VImyu3ZtUxM+rNpvpJhGmEkGd9aeQXPEozLjs8ZeosJIoFJWSB7PZOcOOah8 cUw4cqoI5Nvv78VaeFVfuE43WHusMPqq8+jzV4+Wk/cQa5NTyPsB+k1lpRPZOcRR6L5hfDfa1U0 JTl7ovrm2mhkeQpgb9lI6jSDR2mFVwZnjQ== X-Google-Smtp-Source: AGHT+IE0HN5w1PpisN1gRLaq9ipw+7z3R0W4XYX2h7smiKdfHv90WukbilGjypgSK9pKoW7nZo6uGg== X-Received: by 2002:a17:90a:f94b:b0:2f6:d266:f45c with SMTP id 98e67ed59e1d1-2f6d266fa1dmr21209827a91.2.1736897661872; Tue, 14 Jan 2025 15:34:21 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f72c191e2fsm118156a91.19.2025.01.14.15.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:34:21 -0800 (PST) Date: Tue, 14 Jan 2025 15:34:19 -0800 From: Stephen Hemminger To: "Ariel Otilibili-Anieli" Cc: dev@dpdk.org, "Thomas Monjalon" , "David Marchand" , "Andrew Rybchenko" , "Ori Kam" , stable@dpdk.org Subject: Re: [PATCH 2/2] drivers/net/sfc: remove unused value Message-ID: <20250114153419.0a2753ab@hermes.local> In-Reply-To: <786c4-6786c100-169-3a9adec0@216129648> References: <20241213214951.61974-1-otilibil@eurecom.fr> <20241213214951.61974-3-otilibil@eurecom.fr> <20250114104717.096e996d@hermes.local> <786c4-6786c100-169-3a9adec0@216129648> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Jan 2025 20:54:51 +0100 "Ariel Otilibili-Anieli" wrote: > Hello Stephen, > > On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger wrote: > > > On Fri, 13 Dec 2024 22:41:55 +0100 > > Ariel Otilibili wrote: > > > > > Coverity issue: 384444 > > > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure") > > > Cc: Andrew Rybchenko > > > Cc: stable@dpdk.org > > > Signed-off-by: Ariel Otilibili > > > --- > > > > This gets checkpatch warning when I merged the SHA value is not correct. > > > > ### [PATCH] net/sfc: remove unused value > > > > WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")' > > > > Thanks for the heads up; I'll set the correct length in my .gitconfig > > Bad > > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure") > > Good > > Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure") > Have a good one, > Ariel > Also, please send a patch to add your address to the .mailmap file. Right now, check-git-log.sh script is complaining.