From: Nicholas Pratte <npratte@iol.unh.edu>
To: Honnappa.Nagarahalli@arm.com, luca.vizzarro@arm.com,
probb@iol.unh.edu, yoan.picchi@foss.arm.com,
thomas.wilks@arm.com, paul.szczepanek@arm.com, dmarx@iol.unh.edu
Cc: dev@dpdk.org, Nicholas Pratte <npratte@iol.unh.edu>
Subject: [PATCH] dts: fix hugepage configuration bug
Date: Tue, 14 Jan 2025 15:00:38 -0500 [thread overview]
Message-ID: <20250114200038.193700-1-npratte@iol.unh.edu> (raw)
The dts framework checks for total hugepages of a specific size on a
system without first checking if such hugepages are supported. This
results in unhelpful error messages, since attempting to grab
information from a file/directory that does not exist creates undefined
behavior. This quick reorientation of the code prevents this, and
allows for easier error assessment.
Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
---
dts/framework/testbed_model/linux_session.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py
index bda2d448f7..e3732f0827 100644
--- a/dts/framework/testbed_model/linux_session.py
+++ b/dts/framework/testbed_model/linux_session.py
@@ -90,12 +90,12 @@ def setup_hugepages(self, number_of: int, hugepage_size: int, force_first_numa:
ConfigurationError: If the given `hugepage_size` is not supported by the OS.
"""
self._logger.info("Getting Hugepage information.")
- hugepages_total = self._get_hugepages_total(hugepage_size)
if (
f"hugepages-{hugepage_size}kB"
not in self.send_command("ls /sys/kernel/mm/hugepages").stdout
):
raise ConfigurationError("hugepage size not supported by operating system")
+ hugepages_total = self._get_hugepages_total(hugepage_size)
self._numa_nodes = self._get_numa_nodes()
if force_first_numa or hugepages_total < number_of:
--
2.47.1
next reply other threads:[~2025-01-14 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 20:00 Nicholas Pratte [this message]
2025-01-15 10:10 ` Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114200038.193700-1-npratte@iol.unh.edu \
--to=npratte@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas.wilks@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).