From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C34E946074;
	Tue, 14 Jan 2025 22:08:31 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 63FB340299;
	Tue, 14 Jan 2025 22:08:31 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 9DFB940298
 for <dev@dpdk.org>; Tue, 14 Jan 2025 22:08:29 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id DED1D20BEBE1; Tue, 14 Jan 2025 13:08:28 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DED1D20BEBE1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1736888908;
 bh=5++96HjDbagWS+QUmvmLk5AxHSo1BgtUmkovFZ50qVw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=L8386pEbrMWX5IsApQDkpgzXHj8wdc6ACz6cw6aJzgr6awpNPuKaGoeBC8zpJi3p/
 adL1Iy0DGWyeWPZY2On57uhydcps5s/Q6W4xr+uDD2klEtQjupMG0s8KdQh4UP7af4
 UMkxOpaUxiz8eow4gPdctaLA6K25uxJuJWAo+hmE=
Date: Tue, 14 Jan 2025 13:08:28 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com, dev@dpdk.org,
 ian.stokes@intel.com, jochen.behrens@broadcom.com,
 vladimir.medvedkin@intel.com
Subject: Re: [PATCH v2] drivers/net: use 64-bit shift and avoid
 signed/unsigned mismatch
Message-ID: <20250114210828.GA3357@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1735246770-731-1-git-send-email-andremue@linux.microsoft.com>
 <1736198215-12861-1-git-send-email-andremue@linux.microsoft.com>
 <20250114104153.654dec88@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250114104153.654dec88@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Jan 14, 2025 at 10:41:53AM -0800, Stephen Hemminger wrote:
> On Mon,  6 Jan 2025 13:16:55 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > This patch avoids warnings like the ones below emitted by MSVC:
> > 
> > 1)
> > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> >     result of 32-bit shift implicitly converted to 64 bits
> >     (was 64-bit shift intended?)
> > 
> > 2)
> > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> >     signed/unsigned mismatch
> > 
> > The fix for (1) is to use 64-bit shifting when appropriate
> > (according to what the result is used for).
> > 
> > The fix for (2) is to explicitly cast the variables used in the
> > comparison.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c       | 22 +++++++++++-----------
> >  drivers/net/iavf/iavf_ethdev.c       |  2 +-
> >  drivers/net/iavf/iavf_rxtx.c         |  2 +-
> >  drivers/net/iavf/iavf_vchnl.c        |  2 +-
> >  drivers/net/ice/base/ice_flg_rd.c    |  4 ++--
> >  drivers/net/ice/base/ice_parser_rt.c | 16 ++++++++--------
> >  drivers/net/ice/base/ice_xlt_kb.c    |  2 +-
> >  drivers/net/ice/base/meson.build     | 19 +++++++++++++------
> 
> Patches to base driver need to be avoided if at all possible.
> Please resubmit without that part

Thanks for the information. I sent out a v3 for this series.
It does contain _coding style issues_ for preexisting code.
Hopefuly that can be ignored.