From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62B434608D; Wed, 15 Jan 2025 17:09:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0786D402B5; Wed, 15 Jan 2025 17:09:50 +0100 (CET) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by mails.dpdk.org (Postfix) with ESMTP id 2AB9140298 for ; Wed, 15 Jan 2025 17:09:48 +0100 (CET) Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-467a63f5d1cso53409741cf.0 for ; Wed, 15 Jan 2025 08:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1736957387; x=1737562187; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fi6tyvOZ4l2nuw/E5tKMA+iiM7MA8azxtkRwc7CQ8nE=; b=ZSxydqnO4SXFLST2RV1eBJZJOlEkjZ1XEblSCh48lxRDiWnrfi39p18JqgMTMbTSjf RI1xrHoEwG1NRMTef+AXKXEukcuXa86y80wfh1EIgGsZc6wcl0jEqh1PrmrIxyftoOIn A/ZF0aASXJCwIOy7oBktP1ZqqqKZwTVL5yhd4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736957387; x=1737562187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fi6tyvOZ4l2nuw/E5tKMA+iiM7MA8azxtkRwc7CQ8nE=; b=MgYEnAvGryxwtuU/7j7vOXMooy4c39coVJYsoQhxkqChnSSS5aHTzxl0sOMZ0rNqJ6 FpbKPapPBTzvMN9sOqduoRg3BA8NOh3rDg14ODiYWWRR4diWmPsVtsGQi6q9gvKac0E5 tzKU3CQeZOxIB43DNMKO6v/drhteeKBUs9Pp5KqnixvmlORdq8Xt1yeLNorSPOTP6jv8 a1EXmpjXtv2hfBeHC3buXyl03zJG9By2BwbL6ndLLfrDHwKm5MSGC8+G5KGGCWMLAfYS Z8hcerQs85xe3yo5l3OCbN3spu8dOvRYmx5m2u8j0xKpbTD2AaVR9OyvhdTZSqMJzy/q m5iQ== X-Gm-Message-State: AOJu0YwxQJ2TFaoy1o/ZMmg2/IKT8+dySsjRqcXoTXsGRYI6Tlh4HoiL 2QbDlvn5gYVgs5bB4OODL5lValrjtvEGq5AWJzigpMToV1Y4ky7bvSRa/juyPVE= X-Gm-Gg: ASbGncvAQn7qnsIP2zn0IsyUcvmQ9NQM6l4a0+6s7KJbUooigDP5xHEHgyA8TZwxSHj iecpLPEuMwvGHpNTND4EaRNR4IkFFjaCxqJ0isJa5FUV1YQ4WYau54a1sDL6yhMv4C7nzLG0kRx ThGtKMSoT0iLVj9iRJ20v7fNTZ1X9emUseOZpgXSnMcXzKf4lUaR3xYmD4qSRKSK+Avry1dENNN s7xRgkO9w2thwbLCJmccx9zdNswKscopeKFHSOO8Y65hgu/kvihtDJQuPch6hu2eAPb640bUXzF J6Yku9t14+d06qKd8GavlfQMKF8= X-Google-Smtp-Source: AGHT+IEey1umdqGQ39LHC9p+XZf4QeIi4aJ0x9obuqlFqsP98L4u+3WhFzTyL1d1sz85pNbi//z4nA== X-Received: by 2002:a05:622a:1a9a:b0:466:a9e6:6d6b with SMTP id d75a77b69052e-46c70ffcc01mr380701361cf.15.1736957387287; Wed, 15 Jan 2025 08:09:47 -0800 (PST) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46c873ce201sm65852211cf.55.2025.01.15.08.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 08:09:46 -0800 (PST) From: Dean Marx To: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org, Dean Marx , Jeremy Spewock Subject: [PATCH v16] dts: port over queue start/stop suite Date: Wed, 15 Jan 2025 11:09:47 -0500 Message-ID: <20250115160947.3062-1-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250113200709.4615-1-dmarx@iol.unh.edu> References: <20250113200709.4615-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. The verify argument in the deferred start method has been excluded due to a bug in testpmd, which renders checking port queue info for deferred start status impossible within a single method. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/remote_session/testpmd_shell.py | 18 +++ dts/tests/TestSuite_queue_start_stop.py | 145 ++++++++++++++++++ 2 files changed, 163 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index aa55bd91d3..a90c5ff7a8 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -2248,6 +2248,24 @@ def set_queue_ring_size( f"Failed to update ring size of queue {queue_id} on port {port_id}" ) + @requires_stopped_ports + def set_queue_deferred_start( + self, port_id: int, queue_id: int, is_rx_queue: bool, on: bool + ) -> None: + """Set the deferred start attribute of the specified queue on/off. + + Args: + port_id: The port that the queue resides on. + queue_id: The ID of the queue on the port. + is_rx_queue: Whether to modify an RX or TX queue. If :data:`True` an RX queue will be + updated, otherwise a TX queue will be updated. + on: Whether to set deferred start mode on or off. If :data:`True` deferred start will + be turned on, otherwise it will be turned off. + """ + queue_type = "rxq" if is_rx_queue else "txq" + action = "on" if on else "off" + self.send_command(f"port {port_id} {queue_type} {queue_id} deferred_start {action}") + def _update_capabilities_from_flag( self, supported_capabilities: MutableSet["NicCapability"], diff --git a/dts/tests/TestSuite_queue_start_stop.py b/dts/tests/TestSuite_queue_start_stop.py new file mode 100644 index 0000000000..489f9d7a83 --- /dev/null +++ b/dts/tests/TestSuite_queue_start_stop.py @@ -0,0 +1,145 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2024 University of New Hampshire + +"""Rx/Tx queue start and stop functionality suite. + +This suite tests the ability of the poll mode driver to start and +stop either the Rx or Tx queue (depending on the port) during runtime, +and verify that packets are not received when one is disabled. + +Given a paired port topology, the Rx queue will be disabled on port 0, +and the Tx queue will be disabled on port 1. + +""" + +from scapy.layers.inet import IP +from scapy.layers.l2 import Ether +from scapy.packet import Raw + +from framework.remote_session.testpmd_shell import SimpleForwardingModes, TestPmdShell +from framework.test_suite import TestSuite, func_test +from framework.testbed_model.capability import NicCapability, TopologyType, requires + + +@requires(topology_type=TopologyType.two_links) +@requires(NicCapability.RUNTIME_RX_QUEUE_SETUP) +@requires(NicCapability.RUNTIME_TX_QUEUE_SETUP) +class TestQueueStartStop(TestSuite): + """DPDK Queue start/stop test suite. + + Ensures Rx/Tx queue on a port can be disabled and enabled. + Verifies packets are not received when either queue is disabled. + The suite contains four test cases, two Rx queue start/stop and + two Tx queue start/stop, which each disable the corresponding + queue and verify that packets are not received/forwarded. There + are two cases that verify deferred start mode produces the expected + behavior in both the Rx and Tx queue. + """ + + def send_packet_and_verify(self, should_receive: bool = True) -> None: + """Generate a packet, send to the DUT, and verify it is forwarded back. + + Args: + should_receive: Indicate whether the packet should be received. + """ + packet = Ether() / IP() / Raw(load="xxxxx") + received = self.send_packet_and_capture(packet) + contains_packet = any( + packet.haslayer(Raw) and b"xxxxx" in packet.load for packet in received + ) + self.verify( + should_receive == contains_packet, + f"Packet was {'dropped' if should_receive else 'received'}", + ) + + @func_test + def test_rx_queue_start_stop(self) -> None: + """Rx queue start stop test. + + Steps: + Launch testpmd, stop Rx queue 0 on port 0. + Stop testpmd, start Rx queue 0 on port 0, start testpmd. + Verify: + Send a packet on port 0 after Rx queue is stopped, ensure it is not received. + Send a packet on port 0 after Rx queue is started, ensure it is received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=True) + + @func_test + def test_tx_queue_start_stop(self) -> None: + """Tx queue start stop test. + + Steps: + Launch testpmd, stop Tx queue 0 on port 0. + Stop testpmd, start Tx queue 0 on port 0, start testpmd. + Verify: + Send a packet on port 0 after Tx queue is stopped, ensure it is not received. + Send a packet on port 0 after Tx queue is started, ensure it is received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=True) + + @func_test + def test_rx_queue_deferred_start(self) -> None: + """Rx queue deferred start stop test. + + Steps: + Stop all ports, enable deferred start mode on port 0 Rx queue 0, start all ports. + Launch testpmd, send a packet. + Stop testpmd, start port 0 Rx queue 0. + Start testpmd, send a packet. + Verify: + Send a packet on port 0 after deferred start is set, ensure it is not received. + Send a packet on port 0 after Rx queue 0 is started, ensure it is received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_all_ports() + testpmd.set_queue_deferred_start(0, 0, True, True) + testpmd.start_all_ports() + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(0, 0, True) + testpmd.start() + self.send_packet_and_verify(should_receive=True) + + @func_test + def test_tx_queue_deferred_start(self) -> None: + """Tx queue start stop test. + + Steps: + Stop all ports, enable deferred start mode on port 1 Tx queue 0, start all ports. + Launch testpmd, send a packet. + Stop testpmd, start port 1 Tx queue 0. + Start testpmd, send a packet. + Verify: + Send a packet on port 1 after deferred start is set, ensure it is not received. + Send a packet on port 1 after Tx queue 0 is started, ensure it is received. + """ + with TestPmdShell(node=self.sut_node) as testpmd: + testpmd.set_forward_mode(SimpleForwardingModes.mac) + testpmd.stop_all_ports() + testpmd.set_queue_deferred_start(1, 0, False, True) + testpmd.start_all_ports() + testpmd.start() + self.send_packet_and_verify(should_receive=False) + testpmd.stop() + testpmd.start_port_queue(1, 0, False) + testpmd.start() + self.send_packet_and_verify(should_receive=True) -- 2.44.0