From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 483E8460A4; Thu, 16 Jan 2025 19:19:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31E9F40E0F; Thu, 16 Jan 2025 19:19:12 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 5F918402D6 for ; Thu, 16 Jan 2025 19:19:11 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21c2f1b610dso5451125ad.0 for ; Thu, 16 Jan 2025 10:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737051550; x=1737656350; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HzrZ9tzPRW8u0FG2YDfVs5qM34BgZPeQDtNu1KA6r5M=; b=A6qI07AteeVnEBcbsnXqLKW2yIjlQweNbyMZKrq0CWEzfS1cptva3FLpZtwbPGmn8x XxC2BdbLWUssueLU70HuDSK3s3AiHukO7QT5fMTXBWLAcpYA8/d+onO4fcBs0LLt1qFP YDOXi0bR8UhkfAL/m9jLl/Z7Uodrdw8F/XB3yjYxuXyGFWIJLFvro1zS/ZNP6T5EioZv nRIWqdOMUWu5z/hRDOE3Q6K495xdEl1N+xPcHfrcgEdKiQjCj04PyxADgLI5nLcpW7pm qWQZAEbe7IzFluZa5potLj8HD2sPUsMGwldVqn5HUZchi8Sq9OLXQ4/27bgkFmKOamJp XHKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737051550; x=1737656350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HzrZ9tzPRW8u0FG2YDfVs5qM34BgZPeQDtNu1KA6r5M=; b=OxbqsA10Lih9ZTuFmA9bq8zoG6Lk9aGDfnSZrwK07n0n7lAgmhkwO0aUHDUbsGd3yk D65xKj28HUmtoRV1S0ceUsrwq1RujThQVgd9EHPsxHt65PbPXAu0X9aYFgUKiUIEh16P NmlckMTj6eHUARN27OM19FVI/tuIq6T4zQh/7YlKzngcXSzN7J4rEaoJJSSUkNZOIUNW HX5c05B031jd0VcE0wTLucjs1urSMZoeou6liVQVCY2x6IwK+RZloYmpu1HeA0ZP8KFQ ng08s2leTklqppdfA5b4ZMMFqglir9GY4reGBS860GJAb/9sIO/jj1k3E8O/xmaLNJZv t/dg== X-Gm-Message-State: AOJu0YxQrVvUFs7I7j7xLGQo+OIO0RIADFquzJrgndjbODckKqG4LCNN H1UBjEbb2nnCGH04+GFf941b2qOZJrUnyJbstuAZ6qNp6nMl5zjsmImB5FhNVWo= X-Gm-Gg: ASbGnctvitJ+gAe9sbMdLuz29ksNIw5/Wt6kAe0JteT+vmJ0j0tPrJvQiENi8QFpgrB aU36939Nr4bI8UbPO5nbGCsbBRKcnAAwI0JK3DPxN30AMoHQU7701LxNdXpwl/lIRfyYW26HokV 4Fl2qNfRkzlGhXEgw5CrBb8PWIIG+oVSfFyODGIpwpRU4q0IwiJKTTPwWj+ht5C2aIIUz8UQDvN 0J5BwBt1tKdVx6dwxEkkgsDVcnIC+IAh/ICgmRc2c/B+HQ2dHiXobiGB9qHQA0FRXuC6PySRniH X70eezGA7cWs8iUz29wRf4fd4nJ80KzlOQ== X-Google-Smtp-Source: AGHT+IGZJUHC2jWN2AIHxaRzL2oy5k908L2nndClSEtgG0VZRxPBC4chRoEGkVnbWqykayKtG/yhXw== X-Received: by 2002:a05:6a20:734b:b0:1db:eb82:b22f with SMTP id adf61e73a8af0-1e88cf63d74mr48264828637.5.1737051550476; Thu, 16 Jan 2025 10:19:10 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab9b9945sm297032b3a.85.2025.01.16.10.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 10:19:10 -0800 (PST) Date: Thu, 16 Jan 2025 10:19:07 -0800 From: Stephen Hemminger To: "WanRenyong" Cc: , , , , , , , , Subject: Re: [PATCH v5 07/15] net/xsc: add ethdev configure and RSS ops Message-ID: <20250116101907.2588e707@hermes.local> In-Reply-To: <20250107024953.1962467-8-wanry@yunsilicon.com> References: <20250107024939.1962467-1-wanry@yunsilicon.com> <20250107024953.1962467-8-wanry@yunsilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 07 Jan 2025 10:49:55 +0800 "WanRenyong" wrote: > +static int > +xsc_ethdev_rss_hash_conf_get(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf) > +{ > + struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev); > + > + if (rss_conf->rss_key != NULL && rss_conf->rss_key_len >= priv->rss_conf.rss_key_len) > + memcpy(rss_conf->rss_key, priv->rss_conf.rss_key, priv->rss_conf.rss_key_len); > + > + rss_conf->rss_key_len = priv->rss_conf.rss_key_len; > + rss_conf->rss_hf = priv->rss_conf.rss_hf; > + return 0; > +} > + > +static int > +xsc_ethdev_rss_hash_update(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf) > +{ > + struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev); > + int ret = 0; > + > + ret = xsc_dev_rss_key_modify(priv->xdev, rss_conf->rss_key, rss_conf->rss_key_len); > + if (ret == 0) { > + rte_memcpy(priv->rss_conf.rss_key, rss_conf->rss_key, > + priv->rss_conf.rss_key_len); This should probably be memcpy (not rte_memcpy) since not critical path.