From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3883E460AB; Fri, 17 Jan 2025 11:46:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B806E42DCA; Fri, 17 Jan 2025 11:43:45 +0100 (CET) Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34]) by mails.dpdk.org (Postfix) with ESMTP id 08CC242D8C for ; Fri, 17 Jan 2025 11:43:41 +0100 (CET) X-QQ-mid: bizesmtpsz8t1737110617tpxbbp9 X-QQ-Originating-IP: zhwUEVkWI/PGSY4HGob/rjT1iyVHDUl515NGQrqIt7M= Received: from DSK-zaiyuwang.trustnetic.com ( [36.24.187.167]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 17 Jan 2025 18:43:36 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 13527167347193237516 From: Zaiyu Wang To: dev@dpdk.org Cc: Zaiyu Wang , Jiawen Wu Subject: [PATCH v2 10/15] net/ngbe: add link update ops for VF device Date: Fri, 17 Jan 2025 18:41:09 +0800 Message-Id: <20250117104115.16528-11-zaiyuwang@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20250117104115.16528-1-zaiyuwang@trustnetic.com> References: <20250109040227.1016-1-zaiyuwang@trustnetic.com> <20250117104115.16528-1-zaiyuwang@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-QQ-XMAILINFO: NP3iUBCWMtGbMUAVQ4rJ0eqRcHchH6l4ClWbXXvJ1/s4H0OgXsyd4I3e ArLk7tu8WcS+LwxUxSLpjV/rbAu/slD+dyWavadBfe5Cj1yEHeLVb8r/EKkm4taa1i9RWKy rOEh19j3IDplL9LkYuYED5yLTG2YVViQWrWNePC6L/CjK+vwaFGsDLHBhYjAyHI/l6/zrXa 2quh1UFjqp10cRbfDlkNhMvs9ivPBepWe5Km7aabzuKaAv5K3C3MpabPMm4xRg7/EHfPY3C +AJBdI9P2h7Gupv8uvqu32JxKE7J1/Q/FQj2c1jncXjVtafyVZQtR9bqD0v6vvPFlYGDyuZ e+V3hKYy7iPqlY10tSaD4hgcQiMPT6OZSlKPhcIWDzDLoopbQQ07xpDuhW2dHNkLE3xDl0V WmdjMXbP/dTizy4HblvLkiaC3cW35ayM1RJszX5z68umsPIH8ki49Uf3OAAxB2Ta1QUFIGv jRcQfH6RQnjQcXFTJzEk1SQEf06qysWCZZqkCRVGohRwxu6tuC8KSAa3+21MYyRB0lg1PL7 hHoFMnJqN9XEZTs27oAi+4mHmpTHDU8D7N0eCRv4ZZ+v5F6jmKPBSDa6hehQbtpIKZYAVBf uz/txsBNdLr3YSvCVBso7YPXGN24o2yeWE4zo/Egnn7Vcm5IOk7hTeA4kWjsAZygwKdfXOc pOt17/O281uJjLzE66kWOOYZjjrqtH1F6Ub3382GH0tssgFV1neD2Vr1eREQjM3pgaJUhW8 lFk6ZtfPA+nUuFHsIdPFvMHQxzO0qUZnMGwkls/uPL3ntCpRe/nmu70B0p4SMHIt5lUwAxJ ohg1OI2gRZdrl8xnbJr6yDl17fwZbixrbp1YKiScTWUo52aBFwDb3TVrNdGeY5DrIb2XrGd DtFCHOBLqXp1GHrVsHokXNpqDvDKEXnjh91hA0JtFgjjipZTHZHPoHRY3rPhyJ9meqmDHnF T6ukJt4ekId4p7YaAP/gn+zM30b2Ue376aWVC0XhiAcmSR/w7j9nifdmiWDGgtV/LsSMhBJ QXaXlkDIStBq/vKdeBnFWMHA89d6ALIZ26cp/rWghIxkgRa6Dy X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= X-QQ-RECHKSPAM: 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support to check link feature for VF device, including link speed, duplex mode and link state. Signed-off-by: Zaiyu Wang --- doc/guides/nics/features/ngbe_vf.ini | 1 + drivers/net/ngbe/base/ngbe_vf.c | 96 ++++++++++++++++++++++++++++ drivers/net/ngbe/base/ngbe_vf.h | 2 + drivers/net/ngbe/ngbe_ethdev_vf.c | 9 +++ 4 files changed, 108 insertions(+) diff --git a/doc/guides/nics/features/ngbe_vf.ini b/doc/guides/nics/features/ngbe_vf.ini index 0fde7f9563..fd9c30f559 100644 --- a/doc/guides/nics/features/ngbe_vf.ini +++ b/doc/guides/nics/features/ngbe_vf.ini @@ -4,6 +4,7 @@ ; Refer to default.ini for the full list of available PMD features. ; [Features] +Link status = Y Unicast MAC filter = Y Rx interrupt = Y MTU update = Y diff --git a/drivers/net/ngbe/base/ngbe_vf.c b/drivers/net/ngbe/base/ngbe_vf.c index 039f87423d..52b86afc56 100644 --- a/drivers/net/ngbe/base/ngbe_vf.c +++ b/drivers/net/ngbe/base/ngbe_vf.c @@ -337,6 +337,99 @@ s32 ngbevf_set_uc_addr_vf(struct ngbe_hw *hw, u32 index, u8 *addr) return ret_val; } +/** + * ngbe_check_mac_link_vf - Get link/speed status + * @hw: pointer to hardware structure + * @speed: pointer to link speed + * @link_up: true is link is up, false otherwise + * @autoneg_wait_to_complete: true when waiting for completion is needed + * + * Reads the links register to determine if link is up and the current speed + **/ +s32 ngbe_check_mac_link_vf(struct ngbe_hw *hw, u32 *speed, + bool *link_up, bool wait_to_complete) +{ + /** + * for a quick link status checking, wait_to_compelet == 0, + * skip PF link status checking + */ + bool no_pflink_check = 0; + struct ngbe_mbx_info *mbx = &hw->mbx; + struct ngbe_mac_info *mac = &hw->mac; + s32 ret_val = 0; + u32 links_reg; + u32 in_msg = 0; + + UNREFERENCED_PARAMETER(wait_to_complete); + + /* If we were hit with a reset drop the link */ + if (!mbx->check_for_rst(hw, 0) || !mbx->timeout) + mac->get_link_status = true; + + if (!mac->get_link_status) + goto out; + + /* if link status is down no point in checking to see if pf is up */ + links_reg = rd32(hw, NGBE_VFSTATUS); + if (!(links_reg & NGBE_VFSTATUS_BW_MASK)) + goto out; + + /* for SFP+ modules and DA cables it can take up to 500usecs + * before the link status is correct + */ + if (mac->type == ngbe_mac_em_vf) { + if (po32m(hw, NGBE_VFSTATUS, NGBE_VFSTATUS_BW_MASK, + 0, NULL, 5, 100)) + goto out; + } + + if (links_reg & NGBE_VFSTATUS_BW_1G) + *speed = NGBE_LINK_SPEED_1GB_FULL; + else if (links_reg & NGBE_VFSTATUS_BW_100M) + *speed = NGBE_LINK_SPEED_100M_FULL; + else if (links_reg & NGBE_VFSTATUS_BW_10M) + *speed = NGBE_LINK_SPEED_10M_FULL; + else + *speed = NGBE_LINK_SPEED_UNKNOWN; + + if (no_pflink_check) { + if (*speed == NGBE_LINK_SPEED_UNKNOWN) + mac->get_link_status = true; + else + mac->get_link_status = false; + + goto out; + } + + /* if the read failed it could just be a mailbox collision, best wait + * until we are called again and don't report an error + */ + if (mbx->read(hw, &in_msg, 1, 0)) + goto out; + + if (!(in_msg & NGBE_VT_MSGTYPE_CTS)) { + /* msg is not CTS and is NACK we must have lost CTS status */ + if (in_msg & NGBE_VT_MSGTYPE_NACK) + ret_val = -1; + goto out; + } + + /* the pf is talking, if we timed out in the past we reinit */ + if (!mbx->timeout) { + ret_val = -1; + goto out; + } + + /* if we passed all the tests above then the link is up and we no + * longer need to check for link + */ + mac->get_link_status = false; + +out: + *link_up = !mac->get_link_status; + return ret_val; +} + /** * ngbevf_rlpml_set_vf - Set the maximum receive packet length * @hw: pointer to the HW structure @@ -471,6 +564,9 @@ s32 ngbe_init_ops_vf(struct ngbe_hw *hw) mac->get_mac_addr = ngbe_get_mac_addr_vf; mac->negotiate_api_version = ngbevf_negotiate_api_version; + /* Link */ + mac->check_link = ngbe_check_mac_link_vf; + /* RAR, Multicast, VLAN */ mac->set_rar = ngbe_set_rar_vf; mac->set_uc_addr = ngbevf_set_uc_addr_vf; diff --git a/drivers/net/ngbe/base/ngbe_vf.h b/drivers/net/ngbe/base/ngbe_vf.h index 596f41dcb0..5cf225dd35 100644 --- a/drivers/net/ngbe/base/ngbe_vf.h +++ b/drivers/net/ngbe/base/ngbe_vf.h @@ -17,6 +17,8 @@ s32 ngbe_start_hw_vf(struct ngbe_hw *hw); s32 ngbe_reset_hw_vf(struct ngbe_hw *hw); s32 ngbe_stop_hw_vf(struct ngbe_hw *hw); s32 ngbe_get_mac_addr_vf(struct ngbe_hw *hw, u8 *mac_addr); +s32 ngbe_check_mac_link_vf(struct ngbe_hw *hw, u32 *speed, + bool *link_up, bool autoneg_wait_to_complete); s32 ngbe_set_rar_vf(struct ngbe_hw *hw, u32 index, u8 *addr, u32 vmdq, u32 enable_addr); s32 ngbevf_set_uc_addr_vf(struct ngbe_hw *hw, u32 index, u8 *addr); diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c b/drivers/net/ngbe/ngbe_ethdev_vf.c index 69e0e82652..7669eec2db 100644 --- a/drivers/net/ngbe/ngbe_ethdev_vf.c +++ b/drivers/net/ngbe/ngbe_ethdev_vf.c @@ -18,6 +18,8 @@ #define NGBEVF_PMD_NAME "rte_ngbevf_pmd" /* PMD name */ static int ngbevf_dev_close(struct rte_eth_dev *dev); +static int ngbevf_dev_link_update(struct rte_eth_dev *dev, + int wait_to_complete); static void ngbevf_intr_disable(struct rte_eth_dev *dev); static void ngbevf_intr_enable(struct rte_eth_dev *dev); static int ngbevf_vlan_offload_config(struct rte_eth_dev *dev, int mask); @@ -345,6 +347,12 @@ ngbevf_dev_info_get(struct rte_eth_dev *dev, return 0; } +static int +ngbevf_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) +{ + return ngbe_dev_link_update_share(dev, wait_to_complete); +} + static void ngbevf_intr_disable(struct rte_eth_dev *dev) { @@ -936,6 +944,7 @@ ngbevf_dev_interrupt_handler(void *param) */ static const struct eth_dev_ops ngbevf_eth_dev_ops = { .dev_configure = ngbevf_dev_configure, + .link_update = ngbevf_dev_link_update, .promiscuous_enable = ngbevf_dev_promiscuous_enable, .promiscuous_disable = ngbevf_dev_promiscuous_disable, .allmulticast_enable = ngbevf_dev_allmulticast_enable, -- 2.21.0.windows.1