From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (unknown [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 948B1460A7;
Fri, 17 Jan 2025 11:44:48 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C7DB742D3F;
Fri, 17 Jan 2025 11:43:32 +0100 (CET)
Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])
by mails.dpdk.org (Postfix) with ESMTP id 0235F42D2B
for <dev@dpdk.org>; Fri, 17 Jan 2025 11:43:28 +0100 (CET)
X-QQ-mid: bizesmtpsz8t1737110602t3v3lac
X-QQ-Originating-IP: CcBnx6ruPMrgvwWSROG4N/7NBdnISy2iLWPPVjAkUng=
Received: from DSK-zaiyuwang.trustnetic.com ( [36.24.187.167])
by bizesmtp.qq.com (ESMTP) with
id ; Fri, 17 Jan 2025 18:43:20 +0800 (CST)
X-QQ-SSF: 0000000000000000000000000000000
X-QQ-GoodBg: 0
X-BIZMAIL-ID: 14619302300883158491
From: Zaiyu Wang <zaiyuwang@trustnetic.com>
To: dev@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>, Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [PATCH v2 04/15] net/ngbe: add promiscuous and allmulticast ops for
VF device
Date: Fri, 17 Jan 2025 18:41:03 +0800
Message-Id: <20250117104115.16528-5-zaiyuwang@trustnetic.com>
X-Mailer: git-send-email 2.21.0.windows.1
In-Reply-To: <20250117104115.16528-1-zaiyuwang@trustnetic.com>
References: <20250109040227.1016-1-zaiyuwang@trustnetic.com>
<20250117104115.16528-1-zaiyuwang@trustnetic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1
X-QQ-XMAILINFO: NV0B1Pb4f21/8KK7vb39JiRJJv+BsPCopigEkR1UnmFZX7Sy25Srdhiq
iSMBIizGEx8t8Q5bo3TPgBGN8iHWUaCkf/bABDl/eZYYcnZjRnyZznqtwyq3MJt+jYfdQd9
bWHEpgIUN/lFUJ9Mw/kIf+eIAOKk14L22EYvz3u1K8xUb4i0ALd1PR8QTIRW+qvqwplkMxB
hKEBnCNoDu7FL6dBFiDCe33Hyi4w41TrQRclAI5Wrts8Rzx+s/fapaxiZk9UtT/+YAGoY6D
jN0EWILMnSsJryjvgLt2PSxLDDky/fGlxYOtR2uFfdToecAhyiesIDM0yhc1vvkjYrCxeKx
FV59lrDZHvfOir2hgSDfUwIojdL9xZn+/ke62f2RFTCcXgNnt2Ko5h3iiyH/+nN9wxd8yV9
0U+zNXqm82t2eDzXzNJJsBv8T+bZsFXigtjCiuZ4j2LBLpMRjIGPDE9Wku5y9Oc7cGZvtu6
jtnYCj+m3f5EIotIdNIa50JtoCaog4MzjmijPfHCPEesU3ZZ0vmMW0V3Vb9Ur7GbgyxgdVE
MYZ/LmKuHBtAHRSigo1ZmqTf/PwsgBhmAEsVmDU6NYOuNSmj/yZlTB0GcAE4iZQO6wbun8Y
M+MdKnfr1R7qh/XVcY5R3yNNzIAmCldyiP1pMrSiz8X1n4sd4XBBy+sRuvsEUMm985jaftY
j2dWn464OjHS2276gLB7k6TYpBgEPfBANXWiT/w8MKGT0gHfnYwDzFtOCs8f5uvcrsoZvP/
XMhHB6cO71x5p9AnYauEnUgIhZ+lOUf++sBgJEnwtaOVdCeoBGLez2dd3vJ4jlCYu/PwYUo
zvsm8c35s7T0H0BwXuMSoaetEPzMpmXOCkywjOKDmeauELd6dCFYwXd1o3oquZA4tK4IbcP
Ju0BRZrzwvEdDX2eRu9NV8/U3wfqEcwbW7lkqMo9Qw/ne1DogK05xtpRIXYmWGUTSSkzCAg
hTPeBP+Xae2t20tqRhm+bJw0vIxR3p8sWmiPxszA5WpyBme7Cs9W2baep5xfq6kgunAEMJJ
lLh5RDadTNw/Rj+yBI
X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Support to enable and disable promiscuous and allmulticast mode on VF
device.
Signed-off-by: Zaiyu Wang <zaiyuwang@trustnetic.com>
---
doc/guides/nics/features/ngbe_vf.ini | 2 +
drivers/net/ngbe/base/ngbe_type.h | 1 +
drivers/net/ngbe/base/ngbe_vf.c | 39 +++++++++++
drivers/net/ngbe/base/ngbe_vf.h | 1 +
drivers/net/ngbe/ngbe_ethdev_vf.c | 96 ++++++++++++++++++++++++++++
5 files changed, 139 insertions(+)
diff --git a/doc/guides/nics/features/ngbe_vf.ini b/doc/guides/nics/features/ngbe_vf.ini
index 4335efb812..f8928c5a6c 100644
--- a/doc/guides/nics/features/ngbe_vf.ini
+++ b/doc/guides/nics/features/ngbe_vf.ini
@@ -4,6 +4,8 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Promiscuous mode = Y
+Allmulticast mode = Y
CRC offload = P
VLAN offload = P
QinQ offload = P
diff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h
index 4fd7080847..29dcd5f912 100644
--- a/drivers/net/ngbe/base/ngbe_type.h
+++ b/drivers/net/ngbe/base/ngbe_type.h
@@ -351,6 +351,7 @@ struct ngbe_mac_info {
void (*set_mac_anti_spoofing)(struct ngbe_hw *hw, bool enable, int vf);
void (*set_vlan_anti_spoofing)(struct ngbe_hw *hw,
bool enable, int vf);
+ s32 (*update_xcast_mode)(struct ngbe_hw *hw, int xcast_mode);
/* Flow Control */
s32 (*fc_enable)(struct ngbe_hw *hw);
diff --git a/drivers/net/ngbe/base/ngbe_vf.c b/drivers/net/ngbe/base/ngbe_vf.c
index 7c8b082f97..ccf7148b9c 100644
--- a/drivers/net/ngbe/base/ngbe_vf.c
+++ b/drivers/net/ngbe/base/ngbe_vf.c
@@ -191,6 +191,43 @@ STATIC s32 ngbevf_write_msg_read_ack(struct ngbe_hw *hw, u32 *msg,
return mbx->read_posted(hw, retmsg, size, 0);
}
+/**
+ * ngbevf_update_xcast_mode - Update Multicast mode
+ * @hw: pointer to the HW structure
+ * @xcast_mode: new multicast mode
+ *
+ * Updates the Multicast Mode of VF.
+ **/
+s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode)
+{
+ u32 msgbuf[2];
+ s32 err;
+
+ switch (hw->api_version) {
+ case ngbe_mbox_api_12:
+ /* New modes were introduced in 1.3 version */
+ if (xcast_mode > NGBEVF_XCAST_MODE_ALLMULTI)
+ return NGBE_ERR_FEATURE_NOT_SUPPORTED;
+ /* Fall through */
+ case ngbe_mbox_api_13:
+ break;
+ default:
+ return NGBE_ERR_FEATURE_NOT_SUPPORTED;
+ }
+
+ msgbuf[0] = NGBE_VF_UPDATE_XCAST_MODE;
+ msgbuf[1] = xcast_mode;
+
+ err = ngbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);
+ if (err)
+ return err;
+
+ msgbuf[0] &= ~NGBE_VT_MSGTYPE_CTS;
+ if (msgbuf[0] == (NGBE_VF_UPDATE_XCAST_MODE | NGBE_VT_MSGTYPE_NACK))
+ return NGBE_ERR_FEATURE_NOT_SUPPORTED;
+ return 0;
+}
+
/**
* ngbevf_negotiate_api_version - Negotiate supported API version
* @hw: pointer to the HW structure
@@ -301,6 +338,8 @@ s32 ngbe_init_ops_vf(struct ngbe_hw *hw)
mac->stop_hw = ngbe_stop_hw_vf;
mac->negotiate_api_version = ngbevf_negotiate_api_version;
+ mac->update_xcast_mode = ngbevf_update_xcast_mode;
+
mac->max_tx_queues = 1;
mac->max_rx_queues = 1;
diff --git a/drivers/net/ngbe/base/ngbe_vf.h b/drivers/net/ngbe/base/ngbe_vf.h
index da846dda45..79891e8389 100644
--- a/drivers/net/ngbe/base/ngbe_vf.h
+++ b/drivers/net/ngbe/base/ngbe_vf.h
@@ -16,6 +16,7 @@ s32 ngbe_init_hw_vf(struct ngbe_hw *hw);
s32 ngbe_start_hw_vf(struct ngbe_hw *hw);
s32 ngbe_reset_hw_vf(struct ngbe_hw *hw);
s32 ngbe_stop_hw_vf(struct ngbe_hw *hw);
+s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode);
int ngbevf_negotiate_api_version(struct ngbe_hw *hw, int api);
int ngbevf_get_queues(struct ngbe_hw *hw, unsigned int *num_tcs,
unsigned int *default_tc);
diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c b/drivers/net/ngbe/ngbe_ethdev_vf.c
index ed8400f6ed..28000471b5 100644
--- a/drivers/net/ngbe/ngbe_ethdev_vf.c
+++ b/drivers/net/ngbe/ngbe_ethdev_vf.c
@@ -18,6 +18,8 @@
#define NGBEVF_PMD_NAME "rte_ngbevf_pmd" /* PMD name */
static int ngbevf_dev_close(struct rte_eth_dev *dev);
+static int ngbevf_dev_promiscuous_enable(struct rte_eth_dev *dev);
+static int ngbevf_dev_promiscuous_disable(struct rte_eth_dev *dev);
/*
* The set of PCI devices this driver supports (for VF)
@@ -155,6 +157,9 @@ eth_ngbevf_dev_init(struct rte_eth_dev *eth_dev)
return -EIO;
}
+ /* enter promiscuous mode */
+ ngbevf_dev_promiscuous_enable(eth_dev);
+
PMD_INIT_LOG(DEBUG, "port %d vendorID=0x%x deviceID=0x%x mac.type=%s",
eth_dev->data->port_id, pci_dev->id.vendor_id,
pci_dev->id.device_id, "ngbe_mac_sp_vf");
@@ -264,11 +269,102 @@ ngbevf_dev_close(struct rte_eth_dev *dev)
return 0;
}
+static int
+ngbevf_dev_promiscuous_enable(struct rte_eth_dev *dev)
+{
+ struct ngbe_hw *hw = ngbe_dev_hw(dev);
+ int ret;
+
+ switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_PROMISC)) {
+ case 0:
+ ret = 0;
+ break;
+ case NGBE_ERR_FEATURE_NOT_SUPPORTED:
+ ret = -ENOTSUP;
+ break;
+ default:
+ ret = -EAGAIN;
+ break;
+ }
+
+ return ret;
+}
+
+static int
+ngbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)
+{
+ struct ngbe_hw *hw = ngbe_dev_hw(dev);
+ int ret;
+
+ switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_NONE)) {
+ case 0:
+ ret = 0;
+ break;
+ case NGBE_ERR_FEATURE_NOT_SUPPORTED:
+ ret = -ENOTSUP;
+ break;
+ default:
+ ret = -EAGAIN;
+ break;
+ }
+
+ return ret;
+}
+
+static int
+ngbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)
+{
+ struct ngbe_hw *hw = ngbe_dev_hw(dev);
+ int ret;
+
+ if (dev->data->promiscuous == 1)
+ return 0;
+
+ switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_ALLMULTI)) {
+ case 0:
+ ret = 0;
+ break;
+ case NGBE_ERR_FEATURE_NOT_SUPPORTED:
+ ret = -ENOTSUP;
+ break;
+ default:
+ ret = -EAGAIN;
+ break;
+ }
+
+ return ret;
+}
+
+static int
+ngbevf_dev_allmulticast_disable(struct rte_eth_dev *dev)
+{
+ struct ngbe_hw *hw = ngbe_dev_hw(dev);
+ int ret;
+
+ switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_MULTI)) {
+ case 0:
+ ret = 0;
+ break;
+ case NGBE_ERR_FEATURE_NOT_SUPPORTED:
+ ret = -ENOTSUP;
+ break;
+ default:
+ ret = -EAGAIN;
+ break;
+ }
+
+ return ret;
+}
+
/*
* dev_ops for virtual function, bare necessities for basic vf
* operation have been implemented
*/
static const struct eth_dev_ops ngbevf_eth_dev_ops = {
+ .promiscuous_enable = ngbevf_dev_promiscuous_enable,
+ .promiscuous_disable = ngbevf_dev_promiscuous_disable,
+ .allmulticast_enable = ngbevf_dev_allmulticast_enable,
+ .allmulticast_disable = ngbevf_dev_allmulticast_disable,
.dev_infos_get = ngbevf_dev_info_get,
};
--
2.21.0.windows.1