Re: [PATCH v13 3/3] drivers/net: add diagnostics macros to make code portable

[Andre Muezerie <andremue@linux.microsoft.com>]

On Thu, Jan 16, 2025 at 08:57:27AM +0000, Bruce Richardson wrote:
> On Wed, Jan 15, 2025 at 05:55:11PM -0800, Andre Muezerie wrote:
> > It was a common pattern to have "GCC diagnostic ignored" pragmas
> > sprinkled over the code and only activate these pragmas for certain
> > compilers (gcc and clang). Clang supports GCC's pragma for
> > compatibility with existing source code, so #pragma GCC diagnostic
> > and #pragma clang diagnostic are synonyms for Clang
> > (https://clang.llvm.org/docs/UsersManual.html).
> > 
> > Now that effort is being made to make the code compatible with MSVC
> > these expressions would become more complex. It makes sense to hide
> > this complexity behind macros. This makes maintenance easier as these
> > macros are defined in a single place. As a plus the code becomes
> > more readable as well.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> On a stylistic note, I think you can be slightly less aggressive in
> wrapping the new code in the patch. DPDK allows lines up to 100 long
> without wrapping, so please don't wrap at 80.
> 
> Thanks,
> /Bruce

Thanks for calling this out. I followed you suggestion in the v14 series of this patchset.