From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 06CE6460B1;
	Sat, 18 Jan 2025 04:07:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9260D4028A;
	Sat, 18 Jan 2025 04:07:09 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id D5CED4003C
 for <dev@dpdk.org>; Sat, 18 Jan 2025 04:07:06 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 2F2D320BEBFC; Fri, 17 Jan 2025 19:07:06 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2F2D320BEBFC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1737169626;
 bh=vQ9Y60H62NtOMiPcwkZB9SBB2ipxoDXlK6mbPhsWbJ0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=FMEwb9TbKY75KsxQ2N5V2ryPWqmDuwiXKy81DQ8Mkz0BSg6Jt0R2RvhObYnK1JIYD
 JM6k81WoE59wvL8k81Dmj+bUYjKNPcf/IQAu5fW9W4lJpZg5JC/pFawYoIH3xzzUnZ
 pHoLCn5JAAOUgKn4NY6Sf/R0PJXwlnVENnC3AU8k=
Date: Fri, 17 Jan 2025 19:07:06 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [PATCH v13 3/3] drivers/net: add diagnostics macros to make code
 portable
Message-ID: <20250118030706.GB25492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com>
 <1736992511-20462-1-git-send-email-andremue@linux.microsoft.com>
 <1736992511-20462-4-git-send-email-andremue@linux.microsoft.com>
 <Z4jJ97hZ8LdHdcZI@bricha3-mobl1.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z4jJ97hZ8LdHdcZI@bricha3-mobl1.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Jan 16, 2025 at 08:57:27AM +0000, Bruce Richardson wrote:
> On Wed, Jan 15, 2025 at 05:55:11PM -0800, Andre Muezerie wrote:
> > It was a common pattern to have "GCC diagnostic ignored" pragmas
> > sprinkled over the code and only activate these pragmas for certain
> > compilers (gcc and clang). Clang supports GCC's pragma for
> > compatibility with existing source code, so #pragma GCC diagnostic
> > and #pragma clang diagnostic are synonyms for Clang
> > (https://clang.llvm.org/docs/UsersManual.html).
> > 
> > Now that effort is being made to make the code compatible with MSVC
> > these expressions would become more complex. It makes sense to hide
> > this complexity behind macros. This makes maintenance easier as these
> > macros are defined in a single place. As a plus the code becomes
> > more readable as well.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> On a stylistic note, I think you can be slightly less aggressive in
> wrapping the new code in the patch. DPDK allows lines up to 100 long
> without wrapping, so please don't wrap at 80.
> 
> Thanks,
> /Bruce

Thanks for calling this out. I followed you suggestion in the v14 series of this patchset.