From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 674EC4601A; Mon, 20 Jan 2025 19:30:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DF3942791; Mon, 20 Jan 2025 19:30:40 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 49CD342707 for ; Mon, 20 Jan 2025 19:30:39 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2ee74291415so6321928a91.3 for ; Mon, 20 Jan 2025 10:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737397838; x=1738002638; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=D6QPdmW705Ut1FeI5zepbtTLjOqKkbaKuoil/ivtlVg=; b=KAsh7fwxI/YD1oKK+wpkPjmj2csDIl9c8kvtOs2INCCFU0CTqBUogJ+D1f5K+Ncw+h NMgDvSdYwfiiuDdq9+iIfaGaeS289rGqxCFdKNdlWMKY2xjGWSallBHUFi+65xK6g1Og FXWOMLHQ/LKNSTRfuSIpPrOyTiUT4xq2cfUXc72XDjbac99g+KIvewcUNFLwmKj6/gVp L++pgWEXLwyVfXZprX8EEzLanQphvLEr/lbm1dkghcCg0E55OSE5l/szXQoWSDSz2rhN JxRslBkHOsom/GEV57h6Ox+3uxAAh66uyUjUMGCIF/8+pfSgvaVgWfVjIaZRpIAMdn3s OATg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737397838; x=1738002638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D6QPdmW705Ut1FeI5zepbtTLjOqKkbaKuoil/ivtlVg=; b=Jjeax5924OsFkHbccRAbiLF0iwodCGNRwFf4uJKB7Rp/06HFscGKjTJJ0Q/DLixT9H F5BbliHuGaL3d1mikagBzILJGT7vEGPqmPHOQzX3ZKH9mguHoieGuZrP3YGAibzL9VFQ +NuHiIuzA7w4Y8pfGk+TbJhgtZq6tvubwCzH8+3Thuq7evWsyJlIHSConLrPT1U7wmiJ 6Cd5NVJH3Mictj2uZ5p/Priuigc7lI4uchrwFT9z2lc7r8NOUY0MOltzc9ao7hLWMpX5 Ll/QZX0+8rzwEQdkja1laC8eRHwhupqtwx/RzfKu3pC2z0nikHGqv5zg//Y6rQelW6CB 93kg== X-Gm-Message-State: AOJu0YxGz8xzyy6tKpP8EaMQ/B7GFWIH0SvkD+WJr3x5Twc9d1SubNJW 9qy7Oy6j2y0qwQFckWpScXRFOYDBkX+SiY2bMfMk9k+Jrs4PDVnD8FohHe07LKA= X-Gm-Gg: ASbGncv04EZBo5Dj9Z5XOE3QFvrs4DtrlpyJp+buQ8RBxmEQSBtNjlvQp0SsRqnNBiE y2iO6AvxEKCwPuiPKk0VZ6XYjQ60DRx7HN3cLOSk1lC8ayw4ZvfQnF9ko2DMO11LGvsPi9B7Za7 SvcmDPdshBzxZ2zKtJGlTQ6MxGPVGpAoBA5R4pJcoqIxPbboQkCrTibSwJ8tpbGuczma+8Tigbv Yb89ImT6kACiV7I3trL4RQk19SD8GeQFrFDthML19g66aY1imisBRS+duz/y7m31q9JXHKXo6mN y7rz4BxSb4+EhJokb20jIBaQ7ugCAkVzS/nNvpGG9evmwVE= X-Google-Smtp-Source: AGHT+IH/D0Tw6jlfEstW505BQ8qDOo89+I8k5x14EMbdytP6CQMVxUQCUajtxVarwjmrUF81X2P03A== X-Received: by 2002:a17:90b:2748:b0:2ee:dd79:e046 with SMTP id 98e67ed59e1d1-2f782c79fe8mr20284551a91.13.1737397838513; Mon, 20 Jan 2025 10:30:38 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7c6c079fasm2361777a91.5.2025.01.20.10.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 10:30:38 -0800 (PST) Date: Mon, 20 Jan 2025 10:16:37 -0800 From: Stephen Hemminger To: "WanRenyong" Cc: , , , , , , , , Subject: Re: [PATCH v6 08/15] net/xsc: add Rx and Tx queue setup Message-ID: <20250120101637.442a7002@hermes.local> In-Reply-To: <20250120111447.1048479-9-wanry@yunsilicon.com> References: <20250120111431.1048479-1-wanry@yunsilicon.com> <20250120111447.1048479-9-wanry@yunsilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 Jan 2025 19:14:48 +0800 "WanRenyong" wrote: > +struct __rte_packed_begin xsc_send_wqe_ctrl_seg { > + rte_le32_t msg_opcode:8; > + rte_le32_t with_immdt:1; > + rte_le32_t csum_en:2; > + rte_le32_t ds_data_num:5; > + rte_le32_t wqe_id:16; > + rte_le32_t msg_len; > + union __rte_packed_begin { > + rte_le32_t opcode_data; > + struct __rte_packed_begin { > + rte_le16_t has_pph:1; > + rte_le16_t so_type:1; > + rte_le16_t so_data_size:14; > + rte_le16_t rsv1:8; > + rte_le16_t so_hdr_len:8; > + } __rte_packed_end; > + struct __rte_packed_begin { > + rte_le16_t desc_id; > + rte_le16_t is_last_wqe:1; > + rte_le16_t dst_qp_id:15; > + } __rte_packed_end; > + } __rte_packed_end; > + rte_le32_t se:1; If the whole structure is marked with packed attribute, don't think you also need to mark the sub structures and unions as packed. This is what is confusing the checkpatch check for __rte_packed_begin / __rte_packed_end