From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0D4B34601A;
	Mon, 20 Jan 2025 19:30:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D3420410F6;
	Mon, 20 Jan 2025 19:30:33 +0100 (CET)
Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com
 [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id E05E6410E7
 for <dev@dpdk.org>; Mon, 20 Jan 2025 19:30:32 +0100 (CET)
Received: by mail-pj1-f54.google.com with SMTP id
 98e67ed59e1d1-2efe25558ddso6069939a91.2
 for <dev@dpdk.org>; Mon, 20 Jan 2025 10:30:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737397832;
 x=1738002632; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=YLWjTojkEoQ6G7YXf3xC0TUzmBQDBQl7s2i/SPgaUzU=;
 b=jABTcK99qevxin1zlkHd66labf1lmhxHP12MjIsjp6top7ztnX3k6r8vsPIOopxfMq
 Wm66SVmdoXvdHXSQyjay1sAdCi2Db7XQVqZOmQ1ac1XNs41VyeS08NvFrb4bGfeZ9FZv
 wmAePls9DrYO8hD9NtWpUxXxgpkF7kHegFwQ/Gfvq9WXDb2lOLV9pwaoJLuIRte1Rx5n
 2cKVUPvB425p1IY8iDpxzWtkL1H2JwjQbQXOj7HiBR9gPVFGvGswriDyM3dqcLiAAAvd
 iZ6fS1h3qSZxSLDtvrTMtgyhg9WzET6ku38SbE0vNoeczMIxHC1JAHnxR+TJou5RCT6+
 R4IQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737397832; x=1738002632;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=YLWjTojkEoQ6G7YXf3xC0TUzmBQDBQl7s2i/SPgaUzU=;
 b=jG2rOFzex2vdBYV6KKCbAoAN6iWebjgNA6NG1WTeMD8q2KPLpD4oomjq7QEyYMqKx/
 3FkphCPyIVrc1xTHzDyUAyvxOo8zCDyA2QU/J4Mp0myQ1L4MqIWbsCjK9TilyWCGHr/d
 mGeKdogw3NE3kji3V38A+ph1NmGn7lRN4HpwdVkcM1XNr+lFiLaUMHUIbaIwMFpmq7Ex
 jno/BLdUXq62aJOdDfk5LX1nwtFTPj+EEasWGz2UDuU7ekv/f3GzttExA9MneKOC+nPv
 J8f7XFIAG35oKsFKYBopfd16xeJ5QGfKCvjI164yph8tdPqQbfjw9X9+m9siPjOolnYb
 rXig==
X-Gm-Message-State: AOJu0YxEcnpDRhFF8LESguSLoSx90NfedavNlBKHWyw9IJyZ+H+SFujq
 YwJ8Lclh8kVKvjYvpl2Dgbi4JXKUAHJHU33mFWYtQbAzFIEVZogpgBIqnu2gydw=
X-Gm-Gg: ASbGncueivd/Yl0xHiLqAgN3JJe9jnD7xPstzAOp6tpaBTExOXpzbgoT6L627pcCrae
 QTiyn36DsZrCJJuVbgsgB0A3XGS4BKaGdYtrMaGSZIvvwW/yOSD+pntbpA4v/V8+a7fBDwo62a8
 aaFkCWQjeC/p0GdsP+2X/urNFFbqWk2LOpEpj+ds9VMm8PNFXcGiwKgEeLn3kJv1VYtKCW7IdOu
 mJZwYoinJg1GHQSwzJFLrvutXyHmZrmY1ov2D97mdm9bswbeSINN1sJeuATRA5jd637aXX2187N
 s0J5vEKJCOnxBGlJ14px0uCktzGtVH5m+7V1YW4Y9g+lHAM=
X-Google-Smtp-Source: AGHT+IFtVlz4H6+1/aNCfZ1C4QM8QSTyELFjBnijznEU4WZ+0nzJnUxBQpf5QSXGoSmknobdaKC1aQ==
X-Received: by 2002:a17:90b:4c45:b0:2ee:bc1d:f98b with SMTP id
 98e67ed59e1d1-2f782d5d822mr19253099a91.31.1737397832048; 
 Mon, 20 Jan 2025 10:30:32 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-2f7c6c079fasm2361777a91.5.2025.01.20.10.30.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 20 Jan 2025 10:30:31 -0800 (PST)
Date: Mon, 20 Jan 2025 10:18:38 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: "WanRenyong" <wanry@yunsilicon.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,
 <qianr@yunsilicon.com>, <nana@yunsilicon.com>, <zhangxx@yunsilicon.com>,
 <xudw@yunsilicon.com>, <jacky@yunsilicon.com>, <weihg@yunsilicon.com>
Subject: Re: [PATCH v6 03/15] net/xsc: add xsc mailbox
Message-ID: <20250120101838.04d8c100@hermes.local>
In-Reply-To: <20250120111436.1048479-4-wanry@yunsilicon.com>
References: <20250120111431.1048479-1-wanry@yunsilicon.com>
 <20250120111436.1048479-4-wanry@yunsilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, 20 Jan 2025 19:14:37 +0800
"WanRenyong" <wanry@yunsilicon.com> wrote:

> +static void
> +xsc_cmdq_mbox_free(struct xsc_dev *xdev, struct xsc_cmdq_mbox *mbox)
> +{
> +	struct xsc_cmdq_mbox *next, *head;
> +	struct xsc_vfio_priv *priv = (struct xsc_vfio_priv *)xdev->dev_priv;

Since dev_priv is void *, the cast here is unnecessary in C