From: Stephen Hemminger <stephen@networkplumber.org>
To: "WanRenyong" <wanry@yunsilicon.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,
<qianr@yunsilicon.com>, <nana@yunsilicon.com>,
<zhangxx@yunsilicon.com>, <xudw@yunsilicon.com>,
<jacky@yunsilicon.com>, <weihg@yunsilicon.com>
Subject: Re: [PATCH v6 05/15] net/xsc: add PCT interfaces
Date: Mon, 20 Jan 2025 10:24:33 -0800 [thread overview]
Message-ID: <20250120102433.6f6b342e@hermes.local> (raw)
In-Reply-To: <20250120111440.1048479-6-wanry@yunsilicon.com>
On Mon, 20 Jan 2025 19:14:42 +0800
"WanRenyong" <wanry@yunsilicon.com> wrote:
> +int
> +xsc_dev_create_ipat(struct xsc_dev *xdev, uint16_t logic_in_port, uint16_t dst_info)
> +{
> + struct xsc_np_ipat add;
> +
> + memset(&add, 0, sizeof(add));
> + add.key.logical_in_port = logic_in_port;
> + add.action.dst_info = dst_info;
> + add.action.vld = 1;
You could use initializer here, and avoid a few steps:
struct xsd_np_ipat add = {
.key.logical_in_port = logic_in_port,
.action = {
.dst_info = dst_info,
.vlid = 1,
},
};
And several other places.
This is purely a suggestion, either way is fine will accept it either way.
next prev parent reply other threads:[~2025-01-20 18:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 11:15 [PATCH v6 00/15] XSC PMD for Yunsilicon NICs WanRenyong
2025-01-20 11:14 ` [PATCH v6 01/15] net/xsc: add xsc PMD framework WanRenyong
2025-01-20 11:14 ` [PATCH v6 02/15] net/xsc: add xsc device initialization WanRenyong
2025-01-20 11:14 ` [PATCH v6 03/15] net/xsc: add xsc mailbox WanRenyong
2025-01-20 18:18 ` Stephen Hemminger
2025-01-20 18:19 ` Stephen Hemminger
2025-01-20 11:14 ` [PATCH v6 04/15] net/xsc: add xsc dev ops to support VFIO driver WanRenyong
2025-01-20 11:14 ` [PATCH v6 05/15] net/xsc: add PCT interfaces WanRenyong
2025-01-20 18:24 ` Stephen Hemminger [this message]
2025-01-20 11:14 ` [PATCH v6 06/15] net/xsc: initialize xsc representors WanRenyong
2025-01-20 19:06 ` Stephen Hemminger
2025-01-20 11:14 ` [PATCH v6 07/15] net/xsc: add ethdev configure and RSS ops WanRenyong
2025-01-20 11:14 ` [PATCH v6 08/15] net/xsc: add Rx and Tx queue setup WanRenyong
2025-01-20 18:16 ` Stephen Hemminger
2025-01-20 11:14 ` [PATCH v6 09/15] net/xsc: add ethdev start WanRenyong
2025-01-20 11:14 ` [PATCH v6 10/15] net/xsc: add ethdev stop and close WanRenyong
2025-01-20 11:14 ` [PATCH v6 11/15] net/xsc: add ethdev Rx burst WanRenyong
2025-01-20 11:14 ` [PATCH v6 12/15] net/xsc: add ethdev Tx burst WanRenyong
2025-01-20 11:15 ` [PATCH v6 13/15] net/xsc: add basic stats ops WanRenyong
2025-01-20 11:15 ` [PATCH v6 14/15] net/xsc: add ethdev infos get WanRenyong
2025-01-20 11:15 ` [PATCH v6 15/15] net/xsc: add ethdev link and MTU ops WanRenyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120102433.6f6b342e@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jacky@yunsilicon.com \
--cc=nana@yunsilicon.com \
--cc=qianr@yunsilicon.com \
--cc=thomas@monjalon.net \
--cc=wanry@yunsilicon.com \
--cc=weihg@yunsilicon.com \
--cc=xudw@yunsilicon.com \
--cc=zhangxx@yunsilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).