From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3791460D6; Tue, 21 Jan 2025 18:09:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0310040651; Tue, 21 Jan 2025 18:08:38 +0100 (CET) Received: from egress-ip42b.ess.de.barracuda.com (egress-ip42b.ess.de.barracuda.com [18.185.115.246]) by mails.dpdk.org (Postfix) with ESMTP id 10A52402E9 for ; Tue, 21 Jan 2025 18:08:31 +0100 (CET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02lp2235.outbound.protection.outlook.com [104.47.11.235]) by mx-outbound40-251.eu-central-1c.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Jan 2025 17:08:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vwGF18zWuNdexy1JiIsoagtDFxJexKCxf4I6ZN2kIRMA30f4+07pIo9fp3fbQIdK622ynZSrd7VBknj1g0/AuczODSLSLg5lwZNzlpmGBC91+xu7QzxWBY0QijPedYA/czij7InzooNuDB8YT9PZQx/PYTThiF9KgXteFcDvdWo/K5tA4CJmg1L3338P9sy04S9yivFBCs7S45fpTtLHKfFwB7sZa3/zRVZG/llUM2VPriouyriKLX19BjgPZgHv4sL+WCLUkZbV6YSRHIOxYd1itZVyiiC9JQSyS1YFmt/83nmq+DHs+cKUwUUnib1woFIfDlWrcD2Z0TRTrhh2cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4mV7gvJ/sNJHdRC0VRVjLY48ZADK2G9clbI5e6YpMY=; b=fYp2KuUHV6EwHSZK03oz8QaR7iT01v0snGX+BOKxvZcuuiT4LOn8EcJguNbnFh4YIo7IhL4tAwddFuJz/u0hhlgOTk95jkq4oQYnIgAiYDDu/UHgUDcE0FzO428n9sPRlCAU+Yqx9Imvxf+6NBPRnnEISAkc2GTF2l1/RLmjJYOeTLtlyCZ/IIiNGPH2zPAc5TzohDijAbIs1UQ+j+7T9+lTySqf5VysCKjpa034/z4jMmGWfpYXD/xzr/T9MfbuxZ14qWR4PsYc77ze59mYnx/zyra0EmUmRjHfoQPXCwKB4DrzNQUUCr0ZvNTPkHP3MYANiVpi6io/WqvPjofZwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4mV7gvJ/sNJHdRC0VRVjLY48ZADK2G9clbI5e6YpMY=; b=UTOLXj355N5OjzH+D4ZjciTBIYU3MDtZVascgIvGPjvg7e1IV1A/m40bS2apSit7CFdVao2gEcBVaV19orVbwNd7VaOn0pHNbH88astviDCui/IOQuq/bXrjIkZG1xcY7XPJ4ZMLk1p/FxFJYrxIXRcXNDaEUkOwvfEvuyGtvfo= Received: from AS4P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::16) by DU0P190MB2001.EURP190.PROD.OUTLOOK.COM (2603:10a6:10:3b7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.20; Tue, 21 Jan 2025 17:08:28 +0000 Received: from AM2PEPF0001C70A.eurprd05.prod.outlook.com (2603:10a6:20b:5d3:cafe::e1) by AS4P251CA0024.outlook.office365.com (2603:10a6:20b:5d3::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8377.14 via Frontend Transport; Tue, 21 Jan 2025 17:08:28 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by AM2PEPF0001C70A.mail.protection.outlook.com (10.167.16.198) with Microsoft SMTP Server id 15.20.8377.8 via Frontend Transport; Tue, 21 Jan 2025 17:08:28 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, stephen@networkplumber.org, Danylo Vodopianov Subject: [PATCH v1 09/31] net/ntnic: remove deadcode Date: Tue, 21 Jan 2025 18:07:47 +0100 Message-ID: <20250121170814.3252171-10-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250121170814.3252171-1-sil-plv@napatech.com> References: <20250121170814.3252171-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF0001C70A:EE_|DU0P190MB2001:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: b354cb91-a4bf-4b8f-3775-08dd3a3e39cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AXbD7UwC/EbiJr0kL09H554RZWPKEXodn4JDEMX9JGJs10Unf3zm5hsMntMm?= =?us-ascii?Q?2kLI5pid9QCoj65kWRjvuvRc/HEdKguaYDrL4TpBNORPiD1kbceQ3A9D4cy2?= =?us-ascii?Q?arWi6eFLyR8bBWJtCBY5KumzaJw5QWKxAXKAS7bOGFQwH8VXbssxXn71T3lm?= =?us-ascii?Q?szXu7DETMamGBdRtBYlWJOVPkmyRCJESmUJ9EJ6F/P6cbQspgTPPZy9Gs+Qn?= =?us-ascii?Q?J//ok2YAJeEpmEb/1fDDnlDmwtVGdbRwlYkUKigj8DRsQOXeBvbIwyoOLBpm?= =?us-ascii?Q?77b4CPJKPBDjSQ/jtKBN9C7qySKHspVq2ALsw8BQpWP54rivqlsyF5pucZPy?= =?us-ascii?Q?eh5rq3En6k87B+2kZSfYEj09jQVuBzEhiuUj7G9qcHU5kzboB0kBX2VAKjsz?= =?us-ascii?Q?gwakmQhTgNJaoAH08P80J1qJpbZmQUmhb3fgRkykM9+WY4v+gRCL6AQ6tJ2l?= =?us-ascii?Q?DhcsafG1o/8dRh/H16qwh80e6pal3xccNcXwGnaz8jD3wgL30S+QJHxkTx3+?= =?us-ascii?Q?SS8H1o4sR9LuoJKK0ZAB3h/5X+cNLMnxv4EtFQrYyTcj9kf+FAzR1PAjWq7g?= =?us-ascii?Q?35Cgmq+lnwb9em0+E2eZC0ZVwhiifTBDCer9502zrMoW2/8mnYn9ej8WTUy2?= =?us-ascii?Q?gN8aW1cWSdKNLjg9RWZrAQT3mhvSCyhK+5zexvStQLTWJjpG6+JeQMhNJ6C7?= =?us-ascii?Q?NKs/I8UBWiBD1464ciU8ACeFM3azWvCED5WX0gdP9IQIPan5EOgeLG0fmUVN?= =?us-ascii?Q?2kDZc/onasGw549CE3dG+P7OgQpMQoaTEGT0widdiXBT+uYXOuGGJh2+V7cm?= =?us-ascii?Q?C5+8Oxps5untA5JcqhO83IL7kG3YgoEHxveYiwnLkbawsc2pbnMzuMpwv0TJ?= =?us-ascii?Q?SMPy+hjkiJbZ/0nR39tchRwv0nsNBHYzWlGLXUKs/hL9oVd5lM76qAJjD5Oj?= =?us-ascii?Q?GMcTuj3HgTNW2lHasfplvZ5STLQk1CFsquDjQEZYCSOmApW4UeeFVl7IlEns?= =?us-ascii?Q?XmjFBmA378K9MeQT+19yym+Lo75mVeoR4bgVnVOwdUUruPh6GMeyLzigGf3Y?= =?us-ascii?Q?UslhG7vSZOC5BHM5iUvBgDaw28DlFirQyG1b7N64vA/sSQZmRjXweGsTV/0O?= =?us-ascii?Q?BDaLyuPinkRRECaxQceO76zGSM4tdVVbTeY+xXSKRqMfUVKLX5xyrtI0lYaK?= =?us-ascii?Q?I0lHIDRX7VqBXzWFsXvJp0kkGzoKoij1kGNq3sE6QpFtBY+c9UurMI5TboXP?= =?us-ascii?Q?RrFseXprZ9e4av8sAE4dpnhMrnfDqaRdBtEoxVPshAHI6raJLEbzlhDBka02?= =?us-ascii?Q?sc2tBJo6bnnpl5HJzSOSgt41gET61awVZY9g4LVMy0XrIJbaxaxE044wZu3Q?= =?us-ascii?Q?TjnlUeRAFNMOkeir2BTOUjSrVoBtDNlIvxId66+wGoVvy5ZNvpSBtVfzT/kP?= =?us-ascii?Q?rkaDnYxrKX/fxAf2odvLiK6d75Hg1U/FksMp1K9hZwJT/oopQYc9X4cZW7V0?= =?us-ascii?Q?OQxowVcJ7Fe9g8s=3D?= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CdydnvxX3F0Ns7OdkJF499yPGDqxzEVymPNeLpWEG9IVnEMNffmwN/7tknF4M7bAXXtULyNJ89ThxEGYgPiVgcT+jOfETnlEoZ1NaZUGtApPlaBFmzy2URUN52HX8bJ5PsmzPKfwneLoO2Sra0RpWjDS7CkP6UxekycQjGL8OnSHR5690J8PMdkCDwnHfBE1U1+3BOSmZvCzBUMdQ5LV3snRRSn8tpnm9fqRds9N+5GjrL1wlVeq+6oTtDNUNd0ZTjrthPKHuHRS2TAfQkiFy/UabmX4ik9cSAOq/7uIlhrfjV74eLInKqCXy1vlN3AVOUdlAMKYOQ/99AsdqjIdXtP/D5VsVj6ayFtgV+/oo7tUlHmspQfVgA5dMkqBelLVY/twrmbzdcjb1EFkZQmfirQDo14XAWL/aeDeTqBCxdMn8PwCINnJpIIgKKugOPIu1fUkoDufdAP5YIFVJo4SA4t5UKq6R7iZg2+akR+sbFhC/D2vOjcDADdk6XMeFa1Timn01jBUB5beVRIYX6VeAyrN1V6GGaMYxsjXDc0LYxt8rI3pNmEqogc/YVESqvyNmb68aR+9p7S46yTMmNxWXOxBb2213rEoSp5AaML62flm+9YHOfp5ijuduugHBFOXHPT0Qoh5cBGNtbLhlrBqWg== X-OriginatorOrg: napatech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2025 17:08:28.7493 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b354cb91-a4bf-4b8f-3775-08dd3a3e39cf X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C70A.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P190MB2001 X-BESS-ID: 1737479310-310491-13356-7745-1 X-BESS-VER: 2019.1_20250117.1903 X-BESS-Apparent-Source-IP: 104.47.11.235 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVoYGpuZAVgZQ0MLSKNUo0TQlJT kl2dLcxNwwxTzJ0NLcIi3JMNHQIs1QqTYWAHzQVrJBAAAA X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.261957 [from cloudscan11-226.eu-central-1a.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Danylo Vodopianov Deadcode was removed. CID: 448981 Logically dead code (DEADCODE) Coverity issue: 448981 Fixes: e02fdb65c2a8 ("net/ntnic: add flow create/destroy") Signed-off-by: Danylo Vodopianov --- .../flow_api/profile_inline/flow_api_profile_inline.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c index 1c7d5cac3e..535047d246 100644 --- a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c +++ b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c @@ -4268,13 +4268,8 @@ struct flow_handle *flow_create_profile_inline(struct flow_eth_dev *dev __rte_un err_exit: - if (fh) { - flow_destroy_locked_profile_inline(dev, fh, NULL); - fh = NULL; - } else { - free(fd); - fd = NULL; - } + free(fd); + fd = NULL; rte_spinlock_unlock(&dev->ndev->mtx); -- 2.45.0