From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AEA8460D6; Tue, 21 Jan 2025 18:08:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 227394042F; Tue, 21 Jan 2025 18:08:31 +0100 (CET) Received: from egress-ip42a.ess.de.barracuda.com (egress-ip42a.ess.de.barracuda.com [18.185.115.201]) by mails.dpdk.org (Postfix) with ESMTP id 574D0402E9 for ; Tue, 21 Jan 2025 18:08:27 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by mx-outbound11-0.eu-central-1a.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Jan 2025 17:08:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iLVdwl3WPv+cEgRUL8A+YnSIMGttkbL1llJTqNtUdLYyYpCn//pJOqZ2sBhgkkQMbruuziA5yH+fLizZiPBsFy7M0PadhapujHdBzaltmRgySZJf6sYvtUmCi4lqSib7WFqmLQpr4bD5Yc2D/U+EjwlD/lAUn93NEhfPrI4Ruma/rqlKUs9r9B7EocG92F5y2SPofgt4VQFzH+kkwgq3TNGBt0XeK8jzNR9HQXq+YtOisVI/+I7nthzz2n2icze7iQW7Ln0t7/EWoaIEHEeTntIKYowEMXvX63yZ/cPpcD8iercYiJUvxyFnpYsG2aReCR9rAWep0VN8xsrs9U30RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C6pqbPqev+nEobRP2hbDefDxOlHnesnAcEPwSULv6kw=; b=iZUa4W9PBQefQzfoITDz8u8dsRJxqTg1NfjrMs9calpI1l1ELPQUc0pW8/3ij+ZMiPNuqIWYlQak68Gd/Wit6i5qOqp7IDS9KcmBa4xOEQSjinxdtnWsla9uA08OuZeDv4eHX/T6rONc4rDh91kLizFT1AkkIy2qrdHe94M+JVHGmdGVaGbmgTPSaYPa5iszCt7JmiHnXlQL88SpTjXJA2jK64PpQ98Um2hpDejt3lXz4GUP2XgxZzGnBzqsuFNATiIEkAiQ9rZYNGpgFSmKI0NMufCIjGcl89Ml66UzMx74z1eS6E0t4strLOOB7Z7t7/84mB7DUroncwGAl30bSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C6pqbPqev+nEobRP2hbDefDxOlHnesnAcEPwSULv6kw=; b=RkML8K4gswGgyT6j1coOzvu1DLYVu76m0DcK0RHy2MuXBV0OLANZTN3pu8Vu89UHErsN7gOImME6slQXn9zB/p8J0Nj5yziAIfjftvBwJUfsbVuAlGDAwHSpGeiTkaDgRsyXB+sNrRH4sTAWbPX+PrDoc6mX5IU5hvAP6ejpxtg= Received: from AS4P251CA0021.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::11) by FRZP190MB2214.EURP190.PROD.OUTLOOK.COM (2603:10a6:d10:136::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Tue, 21 Jan 2025 17:08:24 +0000 Received: from AM2PEPF0001C70A.eurprd05.prod.outlook.com (2603:10a6:20b:5d3:cafe::a5) by AS4P251CA0021.outlook.office365.com (2603:10a6:20b:5d3::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8356.20 via Frontend Transport; Tue, 21 Jan 2025 17:08:23 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by AM2PEPF0001C70A.mail.protection.outlook.com (10.167.16.198) with Microsoft SMTP Server id 15.20.8377.8 via Frontend Transport; Tue, 21 Jan 2025 17:08:23 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, stephen@networkplumber.org, Danylo Vodopianov Subject: [PATCH v1 02/31] net/ntnic: add thread check return code Date: Tue, 21 Jan 2025 18:07:40 +0100 Message-ID: <20250121170814.3252171-3-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250121170814.3252171-1-sil-plv@napatech.com> References: <20250121170814.3252171-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF0001C70A:EE_|FRZP190MB2214:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 50f2b188-65d7-4a4a-c1d8-08dd3a3e366d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+M/tmy0KkzbFbEiz5IEN9PFlwnSaoJvJZRlU6D6r4WJgnbYjwZhlt8ZpD9fO?= =?us-ascii?Q?QumZN8XF5+XjSMR9jxmZMs2/2b9Xr6jiP6gWxDG6QEYW6d/ylY0WQ/aAwIqX?= =?us-ascii?Q?/t+QWXByKdwbPI/5LJfh+FssYYu9Md38RFoMBeDs/bKjQ7X4NIlpIGbJv/a7?= =?us-ascii?Q?me+S883nOZWxJD00tovz0gfdRR892KumWWAqWMVJPepE9mJUznlL/HD8V3q5?= =?us-ascii?Q?G+8ihJcXnL1qVtLmGtpmXuknQhHE4gpS81tPtUsgVKXAgWgILliwALdPwNyt?= =?us-ascii?Q?1EoW07CpP73gUYrwMFTW/Ih+CCnO9G3ru5GWqgfxgxPx9+EVTJR9OjarHiuf?= =?us-ascii?Q?iTiroKThITX+8lau4Tj8bZ5r1OMUTg6XRcdOv9utSM574jfLP4TnxWW5IRp5?= =?us-ascii?Q?iLIC8404xDOD62BEdfzdzYzi0baT1Zz0eWRa2HBghvW6Uj9/1lyRuP8uxGQM?= =?us-ascii?Q?b+G1p98uHP8Sn5dpBQQE4Jptwf1fHebISU+l7sLJxW/3UvMm+kX4VcIcY+Ww?= =?us-ascii?Q?v2jibGfHd2axg2fh4gVauuVFEjn/YNeY5VNnq57JDpAJRza0axeq+i4MYXXx?= =?us-ascii?Q?qZn+6StMbMIdGp2NeuIYOiz6TYuBPN/vHouYF9F3O0XcvfPBjE69CY/w9snn?= =?us-ascii?Q?cQJYBvQ1bePXzW/dw2SWLEviQ1pTsJHEfxFwI96qYhFXPCOvVCMdNFCQ9JXr?= =?us-ascii?Q?ple2ovU6njQZx2M0YuX9os7W7ydLPHe2DCG6QQ/dFsXoarlIqFYXhwIpZwqK?= =?us-ascii?Q?WdS7Ln4Cwhi4abEPgVwjWxgkgnr5opcjteE14pPo1jnBZoe+paQBbNoRNps0?= =?us-ascii?Q?YUzf6MKACNGtkbiOHl7aMNoxOwZLvAISBGIa0V/TV3j7SdvSfsIz5sg+2Y3G?= =?us-ascii?Q?ykOv5WezirkxpEM+d2nxl26r82GtUQX/Un5dUgO9jvvTMRAzvxs2FdeB7Ns2?= =?us-ascii?Q?jj3mc3mjUMuTf8TBXugZJS2mmRgqXEcaQ3U/uvyTAbu9vrGkpipDJp225cA8?= =?us-ascii?Q?qinmnb1fjybvPWgidzoiSc37toLaVEmol7jlR4fR7LkbioLj0U0+X87qEvyb?= =?us-ascii?Q?8J87rzRvTkoiiC1J3qsriKytq3QaDSLMf62BCFHOFtfUTE35EPBD9zONTT9a?= =?us-ascii?Q?ySfuOHmvjuKalQ56D5fIVA+Vx+DjigZ7Run9mo3nWXSBJHdqGVLFccvzGFI9?= =?us-ascii?Q?jhOoFkYx92/zyADUc9GPHxzdO61I5QOmcmlAEr6+srAm3Ku95mTeaWO5G7B9?= =?us-ascii?Q?XMSqY472Ak8fsTc7Dv2fnW+4AUX5jhGwvXvb6B6OBlUS5i7rgRVfxizkf2WD?= =?us-ascii?Q?VHsvQyqYpvRFRo1CBB1J4Ff+0vKNiqnVLIWtrzcacoFAxttimsyGIrZA8y8f?= =?us-ascii?Q?M+KdOUhftya/8fpty98McyMKhmJFpQz4WDYYTX6P4yr6OUlgzIGLpE+ZB9Y7?= =?us-ascii?Q?vdggNBmp8/uKnpf/TypK7UuNFhrRCxZpvhUbpQuliBtjT87xprwYCGf6J5yo?= =?us-ascii?Q?9C2Eseak23HzCfE=3D?= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yeotPrPRyKqJu9oxztXB5x7pj1WO4Q63C3YKWxq+cl/cAioQ2pigV0kHc2xdpc/IjACKInWApHQV1147qddiIK8HVIEOGapAFw7K7XOrZKsV0J7mziM5uEguaeihNZwxDiOgG0U8rrGe5gzHUSJ4muBxy6OoEJ7V/Xclr1YvPCdiklvnD40VkbAZR3boI2TnvsZLkukYu7/ahDnAq9IgKL22uhH6760ff66iVBcXTIPOg6bSvkDoznJXMRJThbwl34MNGbIMGGhOAg497F3xqkexF03bPMD54wJ/ou1sQRg1Str4ivTXZ/gO1p872KUi8r4exmcIgU7nkRisSLBxnQdidboLHLCO0EyzXhyD7ygfvQ4DucOtsrdc2SidoNa/WJzV6zC9BXyK0NmVsZ0YUTIw+sdm461GGLCkhUtKoIWjYtLPxOjBaSCMkGSwhRqcmeWvjo+MmS2nbbmfbf4WDlwKOwo6JNE45ptoIYPivMYXHnr/1YDpVM8jk7jftUIEgwijscLeLtRLcyp1+KmnfZhlg4FEnGnw0JmniPEQVjJg7szfIXuiLhf2JxZdPv9uTTPFlCgsLWgIpdZq+i0ubZZkLTRYB4/EuRL3I8MSvE8dkGfFMS1oiZkU35dgW+jGlwRktN0atl+Ei0Nu0zts8g== X-OriginatorOrg: napatech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2025 17:08:23.0774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50f2b188-65d7-4a4a-c1d8-08dd3a3e366d X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C70A.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZP190MB2214 X-BESS-ID: 1737479306-302816-13350-7962-1 X-BESS-VER: 2019.1_20250117.1903 X-BESS-Apparent-Source-IP: 104.47.17.168 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVoZGxoZAVgZQMNHUwswgNTnJ0i gtzTLF2DjZJM3AJDklyTjJzCLNPClRqTYWAC9VHltBAAAA X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.261957 [from cloudscan23-161.eu-central-1b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Danylo Vodopianov CI found couple coverity problems which were fixed in this commit. CID: 448965 Error handling issues (CHECKED_RETURN). Thread return code check was added. Coverity issue: 448965 Fixes: a1ba8c473f5c ("net/ntnic: add statistics poll") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/ntnic_ethdev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c index 2a2643a106..620d023a71 100644 --- a/drivers/net/ntnic/ntnic_ethdev.c +++ b/drivers/net/ntnic/ntnic_ethdev.c @@ -2516,8 +2516,11 @@ static int init_shutdown(void) NT_LOG(DBG, NTNIC, "Starting shutdown handler"); kill_pmd = 0; previous_handler = signal(SIGINT, signal_handler_func_int); - THREAD_CREATE(&shutdown_tid, shutdown_thread, NULL); - + int ret = THREAD_CREATE(&shutdown_tid, shutdown_thread, NULL); + if (ret != 0) { + NT_LOG(ERR, NTNIC, "Failed to create shutdown thread, error code: %d", ret); + return -1; + } /* * 1 time calculation of 1 sec stat update rtc cycles to prevent stat poll * flooding by OVS from multiple virtual port threads - no need to be precise -- 2.45.0