From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2BE0460E8; Wed, 22 Jan 2025 18:46:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96FF340657; Wed, 22 Jan 2025 18:46:06 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 4219240652 for ; Wed, 22 Jan 2025 18:46:05 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ef6c56032eso95235a91.2 for ; Wed, 22 Jan 2025 09:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737567964; x=1738172764; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hBVmEF8DA78inUMktJuHkEhn6/syqnTjmdTt/Ux7sqs=; b=1fvim6iCxZHcFEiXRY1Eup0kIn4cXvxcVowUbay/5SIMa7LrA6wKS70zBkF4gWnir5 d11x+kBfhBuWo4wqNeAdCrYzte1a2ZdNnTGMvkcBXcR/izujrhbCvOJS/61gBepXihwO XmnO6BQG6Ta3Jidnz60ZOgT5xypsP8PtqWWSk5dC6pP5/LakE2uXac1JutkVaFb6sbCu VzucqaHiwvdj7ENaD1oYhlSR3NkODPRB2poHfCMEU2mC7Jaj046Gas9lfAHEIIXJsaAr uWqMYBPw6NgQoSlFPPlDEPJGNnK25iNgGtiFT4LscXbvvmc0D72wejTygbrgkMlz390Z toVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737567964; x=1738172764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hBVmEF8DA78inUMktJuHkEhn6/syqnTjmdTt/Ux7sqs=; b=jeZpzYhxNgyKpUMsfUXpY33Eijy0DpH/jYcrVSSKi1famljDWx2dQVwgtA9dnckGQj zZJIGqGARPMxGSjnmlCA6cMpAvVF7V0k5eRUlnbMMmsMXncm1Fxf9pozCPiLVJLImlMc kmIU3rQsBmqF1iPoSznOMItsp0++KvVfgrvHoVmGYMaC6N6xXCpp2BiYCIWmwkzLzscQ uu9OR0TwdDpMiG3VRLrtkg4jtGnqahaWkdqdQA479UGDU5RNHAWoHNYUWVEYeH4r23Yg FNEwI12nmve6rlSYOdsb861+e3UVCfRec0gZBEkN32xapkothvXi7JqYEtf65+pEsjvb MboQ== X-Gm-Message-State: AOJu0YwhN32VntuqxuW8EdwlDWYpbMANEUJAknPG0z0k4rOIdk0zuVyd 5AiguT3ZwP8B8OUm5MKpVgm83+BsTOCTWww4WZxeYn470v6iokbE/g+8+ZIu3Og= X-Gm-Gg: ASbGncs+038eoIjabknGzsJZyH5aq+Z2J7yZlNZZp+94mBvNuwH0v8UzWzrXayi61oW u4/uBKg0ZRk1NxAvwqZN0djthVp7MYo0PlFnSrflooxes1YgSixTpp+exV3cwnQI7v7nQMmR8MA hgpi+x1bakZtonYdqPz8FHUp4L39K4mGvcIxQilqhXGcOeo4ROUVmPFe+ZgrRJASkD75ZOSgzpu PqOc4OlLMTfg6MlKdwPRjaSEwjaGHpuFyKsbJp8OYyYbGH8IBz89OEKv6Lh0A7NFRlprSr4LlVr W1CirS3prqQzvXWb4IM9+MU/WCa4fMhywrDrvkWVFKmGaUQ= X-Google-Smtp-Source: AGHT+IF3hYjRL5W2/y5xM5xHTsXIGN7O3kqHRs+3HDTTNmzVP/2y4yzIq/c18Bxl91+aS+xglK9+9Q== X-Received: by 2002:a05:6a00:10d1:b0:72d:a208:d366 with SMTP id d2e1a72fcca58-72dafaa5962mr36168853b3a.20.1737567964351; Wed, 22 Jan 2025 09:46:04 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab81737asm11717313b3a.57.2025.01.22.09.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2025 09:46:04 -0800 (PST) Date: Wed, 22 Jan 2025 09:46:01 -0800 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org Subject: Re: [PATCH v8 00/15] net/zxdh: updated net zxdh driver Message-ID: <20250122094601.6c503c71@hermes.local> In-Reply-To: <20250120034723.2980928-1-wang.junlong1@zte.com.cn> References: <20241210055333.782901-2-wang.junlong1@zte.com.cn> <20250120034723.2980928-1-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 Jan 2025 11:47:08 +0800 Junlong Wang wrote: > V8: > - using __rte_packed_begin/__rte_packed_end replace __rte_packed. > > V7: > - resolved warning '-Waddress-of-packed-member' > in function 'zxdh_dev_rss_reta_update'. > > V6: > - Remove unnecessary __rte_packed in the virtqueue structure and others. > - Remove Some blank before or after log message, > and remove some end with period in log message. > > V5: > - Simplify the notify_data part in the zxdh_notify_queue function. > - Replace rte_zmalloc with rte_calloc in the rss_reta_update function. > - Remove unnecessary check in mtu_set function. > > V4: > - resolved ci compile issues. > > V3: > - use rte_zmalloc and rte_calloc to avoid memset. > - remove unnecessary initialization, which first usage will set. > - adjust some function which is always return 0, changed to void > and skip the ASSERTION later. > - resolved some WARNING:MACRO_ARG_UNUSED issues. > - resolved some other issues. > > V2: > - resolve code style and github-robot build issue. > > V1: > - updated net zxdh driver > provided insert/delete/get table code funcs. > provided link/mac/vlan/promiscuous/rss/mtu ops. Do you want to write a release note entry for this? Or shall I write it for you?