From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4930346130; Fri, 24 Jan 2025 18:34:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2210941101; Fri, 24 Jan 2025 18:34:41 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 0C746410FA for ; Fri, 24 Jan 2025 18:34:40 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2162c0f6a39so66095005ad.0 for ; Fri, 24 Jan 2025 09:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737740079; x=1738344879; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ud07og7zBTovwYLLF2fM3Z2me6Vlk2xLFqtvH3zz93k=; b=aSHtNdG/sZuHZOm79nMpAqIRDGPj4Z1pXZPP0bIVIdF1BuiuAQQdIqDUK7QDgXHTrE 6WrsaCQWiRExtZ73V7nwNZ/qABw2dlsUksWpzVGBHx6ElFvmPw5cdqjsT80cBPtRuf1d XPwtDfDGRAVNoIyv9OliD0oR03QhlAx6jksR1gIQAllPABPVkuxGbi+EBrL8OMPRXsJi K1tHAmw5oYXqEqRctwDuUbE2KpoJh2I9KYPtbDFuHW3iT66Eul8PnA6DT2tTpsrT5cC5 6FrVrKmDZ9hIfaCPFpe+Jt1UtAAIYLGjYXqbJoMC9KJTd+b5dj74RYd6kHc8MiSiv9S7 06zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737740079; x=1738344879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ud07og7zBTovwYLLF2fM3Z2me6Vlk2xLFqtvH3zz93k=; b=iltgjNZ2G4EBp/KIRIPKDyFmEB/pJuqTf42Rxo7HX0rVz5PKQeFniZ5Kf95tMJJzTd KYDfq+m2ejCDKpQxeueZX0xUQJQka5KqajxvhErIhAJgIb60OdUxrGa3cC+MSnwrCdMq 71mGliCRs/M7JtVg7ze+uuQv+steU1NbnvsmOLWkqyQlQHOMyHU5FNZNuOkcqxVQkFAQ pLezh+kA2E6ZOeodZY9dSAMwbMS9w7oSBeFeg5bluTYdEdmMqrtO0thAhsrwpnVbgyCs o+DOkKzPfClNojOgNhhgYJB1WC6G3W7m5HskxF9XAtoGkiYabyNxVqUaKGj2+xpuqTtk ILkQ== X-Gm-Message-State: AOJu0Yy3WDftYYrhy7QjRcyrEkXSXghVShvLl3C6YMgOJ+OTiTTJzoyn 9BnEz6hEEKSRET+uz4DUQBpkab0r8MHLdI7VEUnQMkjn3KUdh4ISDaDSg2tl9WQ= X-Gm-Gg: ASbGncsyWNwfNa49+MGFM6zgGioRn+MNJFU442UEwH7AbArjXS1RPQpD9FTrl9yVdnu 5Bgx/jGcyh7A+Vp9KQxQHP/HxmjW86UjWk6FKfoIwvb9ImDnYUQEAkgHoZz2aeDRqBvaSvUHVmL vv/YIOimjVDzNmwoZArvpAsZs3atLHZisTF3cJGDJNHsv7VpXAwdYgSuS2JTrgVrXI1OhfiawS5 R/MsCaUurTIs4AW87JkT9fukekDww+FaEr/DzrYfYdQKW2LnBHtavrzqJS2B3TQVcxp7LdReAyk JT3OzT/SPWgaEmrLJ0jz7dCl5BZN03Ey5loicNWgD1jeZhFk3t1L0ZY9uQ== X-Google-Smtp-Source: AGHT+IHSmR97ouOElYidm2BsNmOGVAXYOKSD+1G7y+olggDJmOOAGSMEQ4CtliQPI1pV/pTmXVuUrA== X-Received: by 2002:a05:6a20:d48c:b0:1d9:a94:feec with SMTP id adf61e73a8af0-1eb6968a470mr12685321637.2.1737740079169; Fri, 24 Jan 2025 09:34:39 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a6b2ed8sm2137970b3a.41.2025.01.24.09.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 09:34:38 -0800 (PST) Date: Fri, 24 Jan 2025 09:34:36 -0800 From: Stephen Hemminger To: Dengdui Huang Cc: , , , , Subject: Re: [PATCH] mbuf: add packet offload Rx flag for keep CRC Message-ID: <20250124093436.78d9c232@hermes.local> In-Reply-To: <20250124095957.3496874-1-huangdengdui@huawei.com> References: <20250124095957.3496874-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 24 Jan 2025 17:59:57 +0800 Dengdui Huang wrote: > diff --git a/lib/mbuf/rte_mbuf.c b/lib/mbuf/rte_mbuf.c > index 559d5ad8a7..c828200ea1 100644 > --- a/lib/mbuf/rte_mbuf.c > +++ b/lib/mbuf/rte_mbuf.c > @@ -771,7 +771,7 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) > case RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD: return "RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD"; > case RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID: > return "RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID"; > - > + case RTE_MBUF_F_RX_KEEP_CRC: return "RTE_MBUF_F_RX_KEEP_CRC"; > default: return NULL; > } DPDK style is to add break line after the case statement. Please do it for both cases.