From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A73FB46130; Fri, 24 Jan 2025 19:01:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 649F9410FA; Fri, 24 Jan 2025 19:01:02 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id B28FA402CE for <dev@dpdk.org>; Fri, 24 Jan 2025 19:01:01 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2f4448bf96fso3444991a91.0 for <dev@dpdk.org>; Fri, 24 Jan 2025 10:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737741661; x=1738346461; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jvxByefEy7eJLhRot1BuxGcHg+/yMZZr+T2SjCWjt5A=; b=LrcD/XpwO/j5TTRMng+BiOhmXfyDqD/8jKsB+7MWlLvhuea42s+124WgbvdeB9cRR/ rhW+GMlqIW7ZD/tJjStTSTRjzyv/nmZtZCkVnR7GExPtvHBUskcBFBTcivjyK4rCs/WM hj5A2jVnmoU/fLpzRrpo/ZaQfqzh1pMOCNJrYrp+vCFI2+BbpTmnbEqfkjmt6O8R1QiA OA+Rq/BwxaK1dm9ejDndZr63jRUgas+lbsy7Mw1JLSVlWsAQOQL7QHMBV7vdx4nVOdX4 hUIIr7ffrh/s7O2TeKvbybcC0DZ+mhmtL90m5GGmUMxLA0qTDsoZPIo46OrgjeghT+3q usXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737741661; x=1738346461; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvxByefEy7eJLhRot1BuxGcHg+/yMZZr+T2SjCWjt5A=; b=bbjcEHLZGCOUp6FbpK0fWOpe+0UjAKof470nwe5RlXJITG3QFqKDwWYHjsAyvnJB4Q ZDdjdT4/WdMhkSsBkqDnRySBodfnoNns6twOf1V6kHLpP/rIt9nf6kRv/cBh3fP47lXW 57mpF5GNgyWjVNy0KaDA2RIcPv5oF+OpCbEP7q8mh9WNgIGVKab6DNHzTJPSVMP8iQvk 2JrPQXTF+kKYWhplYyLWsIvnj+4VOthMiwclJwYQRh9fLgqF/xgTrLLEMJqNkk/9oqNv sISDjd15+CwMUq2TeZaYTeqy9r6Uh/0dJyPXHeFdk4+uhn0fYo7Z8iYhnkekQLEXpd+p OjEw== X-Gm-Message-State: AOJu0Yxzz/fY+X9VdfrEPuvqpR6FL0ag64127vYWYCdJ7G3Vregzsc/L KHDvheW1EE9w+PZ/1vu5Zh02BVAOvMlOG2Xkk+uaE8PRL3OtvhlyAu7MjAJl780= X-Gm-Gg: ASbGncvEuq9+R+GW8jZRQYH9PIBbL2nis6jNHi2oLblhWyj+J2Z16ZE2IRCIM34wKbk TD35/Sva6m6ig72uQOiEaR0VCUeBmi4OHRSXn0rldVLGEAtyumnQD47SxyHyQ3pt1XhDd6YZ7OS GVSPawWHVlvrCshVlvamSE3gXpMqQihgNc+YRjbrPsCO9RDWOesQeO3SdFvovMw5C63GMk01ehZ hZYbScG7g0QUncNRbwyKQKuYQ8gCUsdWrCu7ADHCy0yU3SXFp2j9oiBEkApBJdS5QPe6L95zzpr qrYfp5yKLlCYGO9Ill9BKEAvrlT7rI4N9YBpS5eLrrdR8TU9VuP865v5VQ== X-Google-Smtp-Source: AGHT+IEWfgXq5ZhJykvi9V8GhsMYDchDJv9wly1Vh1MkJNRumxd4tgBP/n/V8MHDxE0OehUjL80Rjg== X-Received: by 2002:a17:90b:4d0b:b0:2ee:f550:3848 with SMTP id 98e67ed59e1d1-2f782c4b250mr38590344a91.5.1737741660774; Fri, 24 Jan 2025 10:01:00 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7ffa491d7sm2044297a91.8.2025.01.24.10.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 10:01:00 -0800 (PST) Date: Fri, 24 Jan 2025 10:00:58 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: "Chautru, Nicolas" <nicolas.chautru@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Vargas, Hernan" <hernan.vargas@intel.com> Subject: Re: [PATCH v2 3/3] baseband/acc: add internal logging Message-ID: <20250124100058.5b4de64f@hermes.local> In-Reply-To: <SJ0PR11MB6694A42B032D97C9D9CF0D77F8E32@SJ0PR11MB6694.namprd11.prod.outlook.com> References: <20250123225519.2469167-1-nicolas.chautru@intel.com> <20250123225519.2469167-4-nicolas.chautru@intel.com> <20250123152425.0663a626@hermes.local> <SJ0PR11MB6694A42B032D97C9D9CF0D77F8E32@SJ0PR11MB6694.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 24 Jan 2025 17:52:43 +0000 "Chautru, Nicolas" <nicolas.chautru@intel.com> wrote: > Hi Stephen, > > The commit message may be misleading, the logging interface doesn't change here. Note also that I reuse existing trace point framework for some of the error logging when relevant (see previous commit). > Here the scope for that buffer is more limited, not a new logging method really (the commit message is misleading). > The queue_ops_dump() already provides api to dump device specific information related to queue into file (logging in real time is not an option) based on information already in PMD memory. > This new buffer is purely there to add storage for the string out of rte_bbdev_ops_param_string() for failed operation on that queue, so that extend that capture as this info is not stored by PMD. > The name of the buffer could be renamed probably, or I could store copy of the actual operation instead of the string in case that makes a difference for you. > > I guess it would possible to move this to trace point but I thought it would be quite convoluted. That information would fits nicely in the queue dump capture, and this would require adding trace point for each operation type (I don't believe it can manage arbitrary string) and would be a bit of an unconventional use of trace point. > > Any thought? > > Thanks > Nic > > > > -----Original Message----- > > From: Stephen Hemminger <stephen@networkplumber.org> > > Sent: Thursday, January 23, 2025 3:24 PM > > To: Chautru, Nicolas <nicolas.chautru@intel.com> > > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; > > hemant.agrawal@nxp.com; Vargas, Hernan <hernan.vargas@intel.com> > > Subject: Re: [PATCH v2 3/3] baseband/acc: add internal logging > > > > On Thu, 23 Jan 2025 14:55:19 -0800 > > Nicolas Chautru <nicolas.chautru@intel.com> wrote: > > > > > Adds internal buffer for more flexible logging. > > > > > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > > > > Inventing another device specific error log seems like a short sighted > > concept. > > Why doesn't existing DPDK logging work well enough? > My feedback is that why can't you just use DEBUG logging for this.