DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, Kevin Traynor <ktraynor@redhat.com>
Subject: [PATCH 0/1] vhost: NULL callback checks
Date: Fri, 24 Jan 2025 14:14:06 +0000	[thread overview]
Message-ID: <20250124141408.419674-1-ktraynor@redhat.com> (raw)

Not a normal case, but noticed that setting some callbacks to
NULL in rte_vhost_driver_callback_register() causes a seg fault e.g. [0].

Added missing checks before calling. Alternative fix is to make some
callbacks mandatory and check during register - is that an API change? maybe,
so took simpler approach.

A bit hard to find fixed commit due to the time and amount of
development in vhost code.

[0]

3302│         if (!(dev->flags & VIRTIO_DEV_RUNNING)) {
3303├>                if (dev->notify_ops->new_device(dev->vid) == 0)
3304│                         dev->flags |= VIRTIO_DEV_RUNNING;
3305│         }

(gdb) frame 1
at ../lib/vhost/vhost_user.c:3303
(gdb) p dev->notify_ops->new_device
$3 = (int (*)(int)) 0x0

Kevin Traynor (1):
  vhost: add NULL callback checks

 lib/vhost/vduse.c      | 3 ++-
 lib/vhost/vhost.c      | 5 +++--
 lib/vhost/vhost_user.c | 3 ++-
 3 files changed, 7 insertions(+), 4 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-01-24 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-24 14:14 Kevin Traynor [this message]
2025-01-24 14:14 ` [PATCH 1/1] vhost: add " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250124141408.419674-1-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).