From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6AA964612D;
	Fri, 24 Jan 2025 17:16:51 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 478D8427A9;
	Fri, 24 Jan 2025 17:16:51 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A564F402CC
 for <dev@dpdk.org>; Fri, 24 Jan 2025 17:16:49 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id BC9E2210D0C3; Fri, 24 Jan 2025 08:16:48 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BC9E2210D0C3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1737735408;
 bh=8xqo5peht1ofZxEWf5DNnFqjZzoaooa/2WM1goZcP2k=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=olpHN6xE8nKJjqxV57wdqT92jbqbRqCKj6YcF9MqFUKqo5+xZhRgIZZqGn+pkpAd5
 O78NAN4AjQXpM98Ss1nDNbVCyPhC6RWftOZaPUi3K6Ir7dtl2KEmlAtTpwxEPLg9Tf
 RlyGzLzwUHJv9k3QvZ+N7EjqoO3Qt+PFM9U2JFZg=
Date: Fri, 24 Jan 2025 08:16:48 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Jack Bond-Preston <jack.bond-preston@foss.arm.com>
Subject: Re: [PATCH v2 0/3] provide rte_ffs32, rte_ffs64 and __rte_x86_movdiri
Message-ID: <20250124161648.GA23580@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1710969879-23701-1-git-send-email-roretzla@linux.microsoft.com>
 <1733430950-10412-1-git-send-email-andremue@linux.microsoft.com>
 <CAJFAV8yL8NkKymVuOyr8u=aHa2B8Kfq1F4rE8LstRJbpJo1P-Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8yL8NkKymVuOyr8u=aHa2B8Kfq1F4rE8LstRJbpJo1P-Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Jan 24, 2025 at 03:53:58PM +0100, David Marchand wrote:
> On Thu, Dec 5, 2024 at 9:36 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > MSVC does not support inline assembly so use movdiri intrinsic and
> > provide abstracted rte_ffs{32,64} inline functions instead of directly
> > using GCC built-ins.
> >
> > v2:
> >  * Moved constants to the right side of the comparison
> >  * Added tests for rte_ffs32 and rte_ffs64 functions
> >
> > Andre Muezerie (1):
> >   app/test: add test for rte_ffs32 and rte_ffs64 functions.
> >
> > Tyler Retzlaff (2):
> >   eal: provide movdiri for MSVC
> >   eal: add rte ffs32 and rte ffs64 inline functions
> >
> >  app/test/test_bitops.c       | 38 ++++++++++++++++++++++++++++++++++++
> >  lib/eal/include/rte_bitops.h | 34 ++++++++++++++++++++++++++++++++
> >  lib/eal/x86/include/rte_io.h |  4 ++++
> >  3 files changed, 76 insertions(+)
> >
> 
> I see nothing wrong with adding those wrappers to ease MSVC support.
> Just, those two ffs helpers should be marked experimental.
> 
> And the unit tests for counting/searching bits had been separated in a
> dedicated app/test/test_bitcount.c.
> 
> 
> -- 
> David Marchand

Thanks for the review David. I sent a v3 series addressing these issues.