From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A913C46130; Fri, 24 Jan 2025 18:24:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8117A41101; Fri, 24 Jan 2025 18:24:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 6A3B1410FA for ; Fri, 24 Jan 2025 18:24:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737739483; x=1769275483; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Q0ZOqBBzdZ9+EBohgn4h0M4WthJbgmkyPOfIUfYBdhk=; b=hl+4Ift73BhlZotlaGzr+5rxzWIjpYFVglQcSc25O4PaEe4X4gRqNLXz a8tOgBgD9LNZ4xymkD/7ziLyFgeRbVYAy67IL+POMa2Z/dYXK3JzFw8il TehC33VNu99Elby4iA6wJ6TY8TpFqbhoRRmwFDP/iJ8hlmlal1MJZi3/i muK/jXFZdrjd3zYwITP6Cdn/WUqgFlOfdh5+pSshAalEKB7ibVCHogpww 87RcUHdLWHlmR5qg4/47Wsui19FhVKNmYIU+NJEFYItLlFLegzHF5xce8 XRB9Cr5F92lwOCQjItCBLKRL/evQuNPlwgmE3f6VIQw6wvVFRonUGDSLe g==; X-CSE-ConnectionGUID: icStLmMHRL+KviJQQnIaMQ== X-CSE-MsgGUID: OMKHBMxlRF6p++AdM6bTuQ== X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="37531359" X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="37531359" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 09:24:41 -0800 X-CSE-ConnectionGUID: pqLo0+lKRSmtLuNfXSpDbg== X-CSE-MsgGUID: GMc+h709SUqGpQXwwaJPbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="145062431" Received: from silpixa00401197coob.ir.intel.com (HELO silpixa00401385.ir.intel.com) ([10.237.214.45]) by orviesa001.jf.intel.com with ESMTP; 24 Jan 2025 09:24:40 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson , Thomas Monjalon Subject: [PATCH] buildtools/check-git-log: print expected driver prefix Date: Fri, 24 Jan 2025 17:24:34 +0000 Message-ID: <20250124172434.1422621-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When outputting an error for an invalid log prefix, don't just tell the user that the prefix is wrong - also tell them what the expected prefix should be. Signed-off-by: Bruce Richardson --- devtools/check-git-log.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 2ee7f2db64..9582f03dea 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -81,12 +81,13 @@ bad=$(for commit in $commits ; do drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 | sort -u) drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then - echo "$headline" | grep -v '^drivers:' + prefix='drivers:' elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then - echo "$headline" | grep -v "^drivers/$drvgrp" + prefix="drivers/$drvgrp:" else - echo "$headline" | grep -v "^$drv" + prefix="$drv" fi + echo "$headline (expected prefix \"$prefix\")" | grep -v "^$prefix" done | sed 's,^,\t,') [ -z "$bad" ] || { printf "Wrong headline prefix:\n$bad\n" && failure=true;} -- 2.43.0