From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH v5 09/16] mempool: add allocation function attributes
Date: Fri, 24 Jan 2025 18:11:22 -0800 [thread overview]
Message-ID: <20250125021305.76485-10-stephen@networkplumber.org> (raw)
In-Reply-To: <20250125021305.76485-1-stephen@networkplumber.org>
Use function attributes to catch cases where mempool is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
---
lib/mempool/rte_mempool.h | 37 ++++++++++++++++++++-----------------
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index 7bdc92b812..c495cc012f 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -1012,6 +1012,20 @@ typedef void (rte_mempool_mem_cb_t)(struct rte_mempool *mp,
*/
typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *);
+/**
+ * Free a mempool
+ *
+ * Unlink the mempool from global list, free the memory chunks, and all
+ * memory referenced by the mempool. The objects must not be used by
+ * other cores as they will be freed.
+ *
+ * @param mp
+ * A pointer to the mempool structure.
+ * If NULL then, the function does nothing.
+ */
+void
+rte_mempool_free(struct rte_mempool *mp);
+
/**
* Create a new mempool named *name* in memory.
*
@@ -1095,7 +1109,8 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
unsigned cache_size, unsigned private_data_size,
rte_mempool_ctor_t *mp_init, void *mp_init_arg,
rte_mempool_obj_cb_t *obj_init, void *obj_init_arg,
- int socket_id, unsigned flags);
+ int socket_id, unsigned int flags)
+ __rte_malloc __rte_dealloc(rte_mempool_free, 1);
/**
* Create an empty mempool
@@ -1132,22 +1147,10 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
* with rte_errno set appropriately. See rte_mempool_create() for details.
*/
struct rte_mempool *
-rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
- unsigned cache_size, unsigned private_data_size,
- int socket_id, unsigned flags);
-/**
- * Free a mempool
- *
- * Unlink the mempool from global list, free the memory chunks, and all
- * memory referenced by the mempool. The objects must not be used by
- * other cores as they will be freed.
- *
- * @param mp
- * A pointer to the mempool structure.
- * If NULL then, the function does nothing.
- */
-void
-rte_mempool_free(struct rte_mempool *mp);
+rte_mempool_create_empty(const char *name, unsigned int n, unsigned int elt_size,
+ unsigned int cache_size, unsigned int private_data_size,
+ int socket_id, unsigned int flags)
+ __rte_malloc __rte_dealloc(rte_mempool_free, 1);
/**
* Add physically contiguous memory for objects in the pool at init
--
2.45.2
next prev parent reply other threads:[~2025-01-25 2:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 17:06 [PATCH] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 00/16] Annotate allocation functions Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 01/16] fib: add allocation function attributes Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 04/16] lpm: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 05/16] pipeline: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 06/16] acl: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 07/16] bitratestats: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 08/16] member: " Stephen Hemminger
2025-01-25 2:11 ` Stephen Hemminger [this message]
2025-01-25 2:11 ` [PATCH v5 10/16] eventdev: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 11/16] ring: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 12/16] reorder: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 13/16] compressdev: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 14/16] telemetry: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 15/16] sched: " Stephen Hemminger
2025-01-25 2:11 ` [PATCH v5 16/16] doc: add release note about allocation attributes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250125021305.76485-10-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).