DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: [PATCH v5 11/16] ring: add allocation function attributes
Date: Fri, 24 Jan 2025 18:11:24 -0800	[thread overview]
Message-ID: <20250125021305.76485-12-stephen@networkplumber.org> (raw)
In-Reply-To: <20250125021305.76485-1-stephen@networkplumber.org>

Use function attributes to catch cases where ring is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
---
 lib/ring/rte_ring.h | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h
index 63a71d5871..28bfbde1f1 100644
--- a/lib/ring/rte_ring.h
+++ b/lib/ring/rte_ring.h
@@ -34,6 +34,7 @@
  * for more information.
  */
 
+#include <rte_common.h>
 #include <rte_ring_core.h>
 #include <rte_ring_elem.h>
 
@@ -119,6 +120,16 @@ ssize_t rte_ring_get_memsize(unsigned int count);
 int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,
 	unsigned int flags);
 
+
+/**
+ * De-allocate all memory used by the ring.
+ *
+ * @param r
+ *   Ring to free.
+ *   If NULL then, the function does nothing.
+ */
+void rte_ring_free(struct rte_ring *r);
+
 /**
  * Create a new ring named *name* in memory.
  *
@@ -183,16 +194,8 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,
  *    - ENOMEM - no appropriate memory area found in which to create memzone
  */
 struct rte_ring *rte_ring_create(const char *name, unsigned int count,
-				 int socket_id, unsigned int flags);
-
-/**
- * De-allocate all memory used by the ring.
- *
- * @param r
- *   Ring to free.
- *   If NULL then, the function does nothing.
- */
-void rte_ring_free(struct rte_ring *r);
+				 int socket_id, unsigned int flags)
+	__rte_malloc __rte_dealloc(rte_ring_free, 1);
 
 /**
  * Dump the status of the ring to a file.
-- 
2.45.2


  parent reply	other threads:[~2025-01-25  2:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 17:06 [PATCH] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-25  2:11 ` [PATCH v5 00/16] Annotate allocation functions Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 01/16] fib: add allocation function attributes Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 04/16] lpm: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 05/16] pipeline: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 06/16] acl: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 07/16] bitratestats: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 08/16] member: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 09/16] mempool: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 10/16] eventdev: " Stephen Hemminger
2025-01-25  2:11   ` Stephen Hemminger [this message]
2025-01-25  2:11   ` [PATCH v5 12/16] reorder: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 13/16] compressdev: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 14/16] telemetry: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 15/16] sched: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 16/16] doc: add release note about allocation attributes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250125021305.76485-12-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=konstantin.ananyev@huawei.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).