DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Volodymyr Fialko <vfialko@marvell.com>
Subject: [PATCH v5 12/16] reorder: add allocation function attributes
Date: Fri, 24 Jan 2025 18:11:25 -0800	[thread overview]
Message-ID: <20250125021305.76485-13-stephen@networkplumber.org> (raw)
In-Reply-To: <20250125021305.76485-1-stephen@networkplumber.org>

Use function attributes to catch cases where reorder table is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Volodymyr Fialko <vfialko@marvell.com>
---
 lib/reorder/rte_reorder.h | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/lib/reorder/rte_reorder.h b/lib/reorder/rte_reorder.h
index 56a6507f9f..1c8c1d5079 100644
--- a/lib/reorder/rte_reorder.h
+++ b/lib/reorder/rte_reorder.h
@@ -14,6 +14,7 @@
  * sequence number present in mbuf.
  */
 
+#include <rte_common.h>
 #include <rte_compat.h>
 #include <rte_mbuf.h>
 #include <rte_mbuf_dyn.h>
@@ -44,6 +45,16 @@ rte_reorder_seqn(struct rte_mbuf *mbuf)
 		rte_reorder_seqn_t *);
 }
 
+/**
+ * Free reorder buffer instance.
+ *
+ * @param b
+ *   Pointer to reorder buffer instance.
+ *   If b is NULL, no operation is performed.
+ */
+void
+rte_reorder_free(struct rte_reorder_buffer *b);
+
 /**
  * Create a new reorder buffer instance
  *
@@ -64,7 +75,8 @@ rte_reorder_seqn(struct rte_mbuf *mbuf)
  *    - EINVAL - invalid parameters
  */
 struct rte_reorder_buffer *
-rte_reorder_create(const char *name, unsigned socket_id, unsigned int size);
+rte_reorder_create(const char *name, unsigned int socket_id, unsigned int size)
+	__rte_malloc __rte_dealloc(rte_reorder_free, 1);
 
 /**
  * Initializes given reorder buffer instance
@@ -111,16 +123,6 @@ rte_reorder_find_existing(const char *name);
 void
 rte_reorder_reset(struct rte_reorder_buffer *b);
 
-/**
- * Free reorder buffer instance.
- *
- * @param b
- *   Pointer to reorder buffer instance.
- *   If b is NULL, no operation is performed.
- */
-void
-rte_reorder_free(struct rte_reorder_buffer *b);
-
 /**
  * Insert given mbuf in reorder buffer in its correct position
  *
-- 
2.45.2


  parent reply	other threads:[~2025-01-25  2:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 17:06 [PATCH] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-25  2:11 ` [PATCH v5 00/16] Annotate allocation functions Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 01/16] fib: add allocation function attributes Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 04/16] lpm: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 05/16] pipeline: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 06/16] acl: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 07/16] bitratestats: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 08/16] member: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 09/16] mempool: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 10/16] eventdev: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 11/16] ring: " Stephen Hemminger
2025-01-25  2:11   ` Stephen Hemminger [this message]
2025-01-25  2:11   ` [PATCH v5 13/16] compressdev: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 14/16] telemetry: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 15/16] sched: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 16/16] doc: add release note about allocation attributes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250125021305.76485-13-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=vfialko@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).