From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39B7246104; Sat, 25 Jan 2025 03:14:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97E6940430; Sat, 25 Jan 2025 03:14:03 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id AA6E54064A for ; Sat, 25 Jan 2025 03:13:29 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2163dc5155fso49589065ad.0 for ; Fri, 24 Jan 2025 18:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1737771209; x=1738376009; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QoQ35Pt71TAeBj+VxStwGVTdvQ0staJ7MW+L5A9cg1I=; b=Gc2oiUZ7hUJmNbEPQ8tPYuo+RJQMLYWBr/rtJRKNEc3Z7WRFwrZ8Hr+AQ4U34RsJ6Z voigPpFHd6m0Mjw+dQOaqWN9xUJFzxGVWqz/FkyNpTk6XpIXMbwvGxVLzVmUGO6Um9f2 6LH5/sncO0/myt1PafeKgxtzVu6AoQhvIZO+izjMfcbIJ5bz8QTTWXzVjyPI5pXV4Hfn oVdUlfGWgEkPd/YUTC50f2/2UsTUAD0p5MfBhjn7A40jRNbEPKayZ9/+heLhJckCVf2o HKn6k9vSqdxise3AfRcP8eNLtMUCggWkghXh1G7NFsfSsR235FWGkIEXrI8S7Kb4vGbN zSVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737771209; x=1738376009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QoQ35Pt71TAeBj+VxStwGVTdvQ0staJ7MW+L5A9cg1I=; b=taF0GlhInn8n0NjivP3N2yQfOMhs8Re1gglLtEAESJaLQFL3L5MgPAf2byE/FsDWw1 sGUOQph67v44MAGS+8/sAtHtpqnb2xVp84ptTIoyuIVp+R5k+dRiaT6o6keJ/v84pads ut8TzfiWIfkIQQBA4eIrnVPc037GHf+PBBKoljsbptzzinzjJYIqmP165UjiJJLHQ7CF yMTm7webFrCY4TI0naoc4+fzODdCPV+9yvLKZtfoGTBesYegtdTLsXuHYlVzviYf/lyl ZwBRLBeZd0w5QZbzqzITTDVd6n1gkX6bXrFPukgu43efQ/+DoFtV0KV3GE7GIDOdInDf n98Q== X-Gm-Message-State: AOJu0YwFxC7kjCCHZLHNlkX8KnLfDvn9pzfJcsPGjKW+ppZwM2Zyb4dF Mtj0O66QllFzBeHAVhVII9Wo0Xmq84ONo88m1sYrUpCfDlvE1q88Ck8+AReXSUjFe2OqrFz6KED p X-Gm-Gg: ASbGncuK+RcLTXLVxeamf+1I2pHZk3ZfeWcZmLJ7WT/k0UEsLkvJzTk2FKx8r11pjri erAQV+IUj1LTO0JlmeEj3WZVVIaNL9UKyRIIWUf+zSWmffJsdpiR8P+BCwve58BExfb9YGvpQ2c h+6vk+sb8UCpkKEl2jI+/IrK646B/5gXvobjgbw4fcPxtCIdjKp34YpW2b+pPdYdhHVXQcFL/iu IULmnMAU1i+FMR39/WtNFcHnvKrMkeKHilSQkbX5CuVTZTvFeD7EA0Y+lb99VUI+FiLMV900IpN nLK9Qux8YEdfO/Y/QPhlHfdYbx/ddMF3GEqL9MDQ+5m+oo61Nuvg6MjT2A== X-Google-Smtp-Source: AGHT+IFd/npBkWtOX0sHF/Ny8Z6nZm1W60AFis9/3zGGAA7MJ0yroJ01bMq/0nTCBg7/6TFRAaa+ig== X-Received: by 2002:a05:6a20:728d:b0:1db:daab:2ae7 with SMTP id adf61e73a8af0-1eb214abdc3mr48663804637.19.1737771209024; Fri, 24 Jan 2025 18:13:29 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ac48e84e199sm2345256a12.11.2025.01.24.18.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 18:13:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v5 14/16] telemetry: add allocation function attributes Date: Fri, 24 Jan 2025 18:11:27 -0800 Message-ID: <20250125021305.76485-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250125021305.76485-1-stephen@networkplumber.org> References: <20250110170603.538756-1-stephen@networkplumber.org> <20250125021305.76485-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use function attributes to catch cases where telemetry data is allocated but not freed correctly. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/telemetry/rte_telemetry.h | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h index 2ccfc73a5f..c4554e4028 100644 --- a/lib/telemetry/rte_telemetry.h +++ b/lib/telemetry/rte_telemetry.h @@ -414,16 +414,6 @@ __rte_experimental int rte_telemetry_register_cmd_arg(const char *cmd, telemetry_arg_cb fn, void *arg, const char *help); -/** - * Get a pointer to a container with memory allocated. The container is to be - * used embedded within an existing telemetry dict/array. - * - * @return - * Pointer to a container. - */ -struct rte_tel_data * -rte_tel_data_alloc(void); - /** * @internal * Free a container that has memory allocated. @@ -435,6 +425,17 @@ rte_tel_data_alloc(void); void rte_tel_data_free(struct rte_tel_data *data); +/** + * Get a pointer to a container with memory allocated. The container is to be + * used embedded within an existing telemetry dict/array. + * + * @return + * Pointer to a container. + */ +struct rte_tel_data * +rte_tel_data_alloc(void) + __rte_malloc __rte_dealloc(rte_tel_data_free, 1); + #ifdef __cplusplus } #endif -- 2.45.2