DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>
Subject: [PATCH v5 08/16] member: add allocation function attributes
Date: Fri, 24 Jan 2025 18:11:21 -0800	[thread overview]
Message-ID: <20250125021305.76485-9-stephen@networkplumber.org> (raw)
In-Reply-To: <20250125021305.76485-1-stephen@networkplumber.org>

Use function attributes to catch cases where member table is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/member/rte_member.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/lib/member/rte_member.h b/lib/member/rte_member.h
index 109bdd000b..0235bb0a81 100644
--- a/lib/member/rte_member.h
+++ b/lib/member/rte_member.h
@@ -341,6 +341,16 @@ struct __rte_cache_aligned rte_member_parameters {
 struct rte_member_setsum *
 rte_member_find_existing(const char *name);
 
+/**
+ * De-allocate memory used by set-summary.
+ *
+ * @param setsum
+ *   Pointer to the set summary.
+ *   If setsum is NULL, no operation is performed.
+ */
+void
+rte_member_free(struct rte_member_setsum *setsum);
+
 /**
  * Create set-summary (SS).
  *
@@ -351,7 +361,8 @@ rte_member_find_existing(const char *name);
  *   Return value is NULL if the creation failed.
  */
 struct rte_member_setsum *
-rte_member_create(const struct rte_member_parameters *params);
+rte_member_create(const struct rte_member_parameters *params)
+	__rte_malloc __rte_dealloc(rte_member_free, 1);
 
 /**
  * Lookup key in set-summary (SS).
@@ -528,17 +539,6 @@ int
 rte_member_report_heavyhitter(const struct rte_member_setsum *setsum,
 			      void **keys, uint64_t *counts);
 
-
-/**
- * De-allocate memory used by set-summary.
- *
- * @param setsum
- *   Pointer to the set summary.
- *   If setsum is NULL, no operation is performed.
- */
-void
-rte_member_free(struct rte_member_setsum *setsum);
-
 /**
  * Reset the set-summary tables. E.g. reset bits to be 0 in BF,
  * reset set_id in each entry to be RTE_MEMBER_NO_MATCH in HT based SS.
-- 
2.45.2


  parent reply	other threads:[~2025-01-25  2:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 17:06 [PATCH] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-25  2:11 ` [PATCH v5 00/16] Annotate allocation functions Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 01/16] fib: add allocation function attributes Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 04/16] lpm: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 05/16] pipeline: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 06/16] acl: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 07/16] bitratestats: " Stephen Hemminger
2025-01-25  2:11   ` Stephen Hemminger [this message]
2025-01-25  2:11   ` [PATCH v5 09/16] mempool: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 10/16] eventdev: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 11/16] ring: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 12/16] reorder: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 13/16] compressdev: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 14/16] telemetry: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 15/16] sched: " Stephen Hemminger
2025-01-25  2:11   ` [PATCH v5 16/16] doc: add release note about allocation attributes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250125021305.76485-9-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=sameh.gobriel@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).